Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27601148rwd; Tue, 4 Jul 2023 05:23:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlGGCgKhiIMLRqrh6ESUpvbl1PebT6J4fLOsdS0nG7P9QkRAn1fB1++1Fp1TKFQvwugQz8gV X-Received: by 2002:a17:903:41c4:b0:1b8:a73e:aaac with SMTP id u4-20020a17090341c400b001b8a73eaaacmr1341834ple.62.1688473439345; Tue, 04 Jul 2023 05:23:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688473439; cv=none; d=google.com; s=arc-20160816; b=CEiVP+aR1VxSz7f7FAs7KGlU4phTdc/o3QrjcHcHd8dz9rRSHeYfI31BIG5uxt5k+O XlbDe3TMqfcxtf79QcCqqtxuT7iIHeD3kZBD76RYl5SAIQI3413Qp95P1WRR7XRCz40X XUWenOenVW6PMgBBpABUCjxCI5VnjotRpaH1qDfElBYaEAF9OUFmEYUw0R76slBJhH7B b09ycZ4+1HFWt0DkcpVhFO8fFFBjn9q++l5/K5w6wCVCXmAUVHKXq6PnklORhFF9W6pA fe+N2ngE3dqmqdWZm2ebKanL/yaeq9sOD2vIRAf7qF9VBFmfXf05PlCEKF8U7C2fbwCJ CG9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AeT8U3XbrJM+IpxFqUmrW6am26kBs6TNymHmIaQUPXs=; fh=TlZnqoAxEXW+wYzgpndrjC0A7teFaEqoOGInmPiMrro=; b=FVz4+QQapO+2XlgMf6ZqKb3HYJvaNOXBjapJ2EUqT1cRryXw3X6ri2PfM3iQFYms0K qGFCa8r2CnjBBBtuX3WM+WRiSqXrwzMSR8jdwDD8Pn+sxgM7A8Mnlcrwsa4P53lRpEuF dAO7uI4oyJYZZQ5OGsmmvko0KTOm8rYpADzp39sF3i8OmCX1a1ov/fXBtrsG2aiuGGHq QwBWra1C9lgQw0hsbIPvxjINHST2Q/nvaTPZb/KxDG1V46mxWTlMG1Az6RZzhqA7r25P 8mM9wqWbGD5bBBZH1HtIxfkp3VVlwXfMn80cJ4Xz0NzV41Jeb9XrB9+oEzLbq91FN/IY e/Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EuDxWAmY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e1-20020a17090301c100b001b850a9687asi12010595plh.350.2023.07.04.05.23.46; Tue, 04 Jul 2023 05:23:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EuDxWAmY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbjGDMOM (ORCPT + 99 others); Tue, 4 Jul 2023 08:14:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231249AbjGDMOI (ORCPT ); Tue, 4 Jul 2023 08:14:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 791AF1709 for ; Tue, 4 Jul 2023 05:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AeT8U3XbrJM+IpxFqUmrW6am26kBs6TNymHmIaQUPXs=; b=EuDxWAmYbZuisMm6kdnNRQdfAy Bt8Qmglfmqzn0VXmuT15QuhZt/G1PgzwTmcglPZAeydtPV5szhEou1GRXfqfK6BGFk3O71eZHHb+5 eTxipTRjPMlHRR4mEkbZBvZSyJWheBhvfuL6XDUyVpGtzlQdGk6RpGSzpkEwrlEaxY5LTa02vi6aJ dWsGA6XYSy150Km/IaEPXwf6fhsQLh4fHXnCm7kuivoF9wYA6DrRLgOvz4OZxS2KaT2ms3qodApVs luasXECj6+ZxO6QNzioH4IAzEv+st3/YJGcqwCwxZvkQwaHhD+zwUmaGTlJClp942Tvtfnx/inNR4 Wx7TPaPg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGeuA-0098BO-RB; Tue, 04 Jul 2023 12:13:14 +0000 Date: Tue, 4 Jul 2023 13:13:14 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: avoid false page outside zone error info Message-ID: References: <20230704111823.940331-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704111823.940331-1-linmiaohe@huawei.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 04, 2023 at 07:18:23PM +0800, Miaohe Lin wrote: > @@ -470,6 +470,8 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page) > sp = zone->spanned_pages; > if (!zone_spans_pfn(zone, pfn)) > ret = 1; > + else > + ret = 0; Surely 'ret = zone_spans_pfn(zone, pfn);' ? Also, did you spot this by inspection or do you have a test-case or bug report? Should this have a Fixes: tag?