Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5fbf1cc-9b79-5fbb-a109-87679caffcc4@talpey.com>
Date:   Tue, 4 Jul 2023 09:58:22 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v1] fs:smb:Fix unsigned expression compared with zero
To:     Namjae Jeon <linkinjeon@kernel.org>, Wang Ming <machel@vivo.com>
Cc:     Steve French <sfrench@samba.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
        opensource.kernel@vivo.com
References: <20230704074057.1162-1-machel@vivo.com>
 <CAKYAXd85gpb2xzPEm8BJV6gsff3p-8b4Aj_rOaEvU=+n43SgBQ@mail.gmail.com>
Content-Language: en-US
From:   Tom Talpey <tom@talpey.com>
In-Reply-To: <CAKYAXd85gpb2xzPEm8BJV6gsff3p-8b4Aj_rOaEvU=+n43SgBQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXkyQXVCRjluTSt0WFU5K3VGL1dncHViN3UvaXh0aGZxM04yaS93d3dyUko1?=
 =?utf-8?B?K0pOUVo3b2UrMGpBKzFjQ3ZLWW1ZU1hYQjlnY3ZVUG9WOWhGdmp2cTNhcS9o?=
 =?utf-8?B?OEQxNHV2YXZZTktuQTJ1MUU3ZE0xN1dLVkhST1lGNjQxSHVkaGdsYkxVZjdr?=
 =?utf-8?B?NWsvSy9JSXJPa0I0ekxEbGlQSjFDSnJXZ2FJZVdyZ2VCeDhCRVR3SlBiQWFE?=
 =?utf-8?B?YTRoWnNZSjZ3SlZSSy9zakhCODBheUZXRmVmd3Izek45eGpQZGp2c0JSTENG?=
 =?utf-8?B?QzJqb2U0ZkE5WlJ0M0NYUHhJUEkxZXp5VTBtTHFkMVBxd0RwMXVnZ2NVUWVp?=
 =?utf-8?B?UG5UK2lkRjEyeVRSM2lzNjFqMEJXMEZJS2JrSUJsRmtNMDQyVVdJdkZMT2po?=
 =?utf-8?B?cllYSmIxM2ZCNHZORVVxaFN2SWoraHkwVll4NTNkMUFCTnVPdVh1Z1M4dDZ2?=
 =?utf-8?B?UGtFZElIMTZ0aXJ4a3ExUlpYYm9YRjZDTm5PVklrWmNSeFI3Ym9xbmMrRG5S?=
 =?utf-8?B?dnRMRlB3VG5DdTBPYXViQStBc21sRkZkNjBDVUwwWmtBOXJJLzA1RVBleVZt?=
 =?utf-8?B?dDYwZHNMTHlYc1RpVXFsYSt5aDVXU1hNUm9VQVptUGRIWk5rN0txS0RJUDlH?=
 =?utf-8?B?MVRLZkFQM1pCNHloWXNHQStYNFhzNDVkT3ZRNnRMR2dZTmhGVXlGOXNOSnVD?=
 =?utf-8?B?ZmlFaDJBZ04xeHc4M3FscTloOW56SkIxQ0hoSWt5TndYalJFNkU0ZzlsT1ZY?=
 =?utf-8?B?VVIyM2grS0NWbUVPaVNENElpSDIzcllKb2VEb2lURzJHQ3JuOVBsaGVwVmh3?=
 =?utf-8?B?Z2pRbW5HNHJHSm5rd1dFQUsrWnhhdUFSbStwRkwvMTFaK0RuV1hxc2U1RkxH?=
 =?utf-8?B?T2RRSmwzUFRNa0MzOWlLeEZlS2VOTEJUYnBLZm9WRThKYjRodS9OcGdwOTFU?=
 =?utf-8?B?Ym80RmhFZFlLM0toRm5pcG8rZ2V3bFRhczFkTGIvQUVhUkpoTXFNVzlqSmEw?=
 =?utf-8?B?SEtla3NhdDJhUGdjMUlvZ1A4aWNQOFljOTBGNWZrQlRSdVVLcXNaTnBjR2RF?=
 =?utf-8?B?RWZEcXY1VVEvOGM3UkhZeCtDZktvWFMrYW5nbXI0akFyUTBqcWQybmxnekdY?=
 =?utf-8?B?QWVMZGpHRGNXaFREMlVVMWR5cGx5TVZFYjlkRVBSU3FNOWJNSXNCTmhsdmtJ?=
 =?utf-8?B?RDZJWmxxYnR3ODMvWU54M3VmQVRrSHczZEFzRVNEOTJEQVEzdllHVTRCK0Qw?=
 =?utf-8?B?QkFERmRWTjVhaTEweXBYZnJTc2s2MHB0WE04K081d0hLZWgzdFlVdnlxWGZO?=
 =?utf-8?B?MlZrc1AwZFJhYmJ1dW9nak4yTEoyQ0Q4VEdyTjRCSjcrWGdmbHVWM3k3ZTZw?=
 =?utf-8?B?d3BQWG52bTkyQXozUUM1WTJlM3B3NFRvdGtvWGFndlVZcnQxZlFDRG5USU1W?=
 =?utf-8?B?R0orYlBhVmRyaGM3N3JsQ1lHbDhoOEIydVJZUDdhRlFGdDloU3ZyL1oxRU1o?=
 =?utf-8?B?VlJobE5vQmR1aWsxaXNpL092Z0lYSWovZEVDcXRyYjkxRExmVThEQTdORmJq?=
 =?utf-8?B?bnFTZUNFbnU1WTYrMlBTUTlWbE5aZzVNV1FRYmNnT0xVNmRVMTJNWFdZWncy?=
 =?utf-8?B?M2t3bitXQUJlRFdhV3ljRVFvcTRZakhaK2I2b3VGYmcwK2V5ZC9mdVZQK01G?=
 =?utf-8?B?Q0lZVldONm5QbHVoZjRJVDB6WlpQajVULzFmTXY5ZWhvMmVEb1VPNGIyWWVS?=
 =?utf-8?B?dk1BWTliSTg4aWdiUDlyVE02WnR6SVNCYmo1Sk9DQ2l6VUg0TUVVdHZ0aVdY?=
 =?utf-8?B?bXRhMURwcWU5U3NQUlA5YUY0NzgyaU1TTUhGd291OCtzTEIrMXB3VGtrTjdW?=
 =?utf-8?B?TTZ6dkJIWk1OdXFkS1g2V1J3ZUt0S0M3R3hOSXdSYWFnWkxLUGFSWi96bDBW?=
 =?utf-8?B?WWJUeHR3UGErYkxJK3BlcmRobDh3aDF6M3RjMHJPK1ExYkwyQlZJQmtVMDl0?=
 =?utf-8?B?dW8xN0J1MUFURWZMK0l6bU9lYVd2dTdqQnZqeGtBNEVPUGhxMWhiWnl6eE9j?=
 =?utf-8?B?bmtuZkkxTWV0YXdpNGxoYlg3d3UyME5WK3hvaG1hNkF0a0dVMlBUWVc4SnVh?=
 =?utf-8?Q?at2NdMPCbAafc41yA3drt/TSE?=
X-OriginatorOrg: talpey.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cb4adaf-69c3-4002-4519-08db7c96bc2a
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4445.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 13:58:25.1279
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2b2dcae7-2555-4add-bc80-48756da031d5
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 41t9vG5J6BCvMiUaPlRlcxFIMIGSgB9RCexXIcy9RmCzcm+gjObAcODHPpm0ao/T
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7523
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/4/2023 4:58 AM, Namjae Jeon wrote:
> 2023-07-04 16:40 GMT+09:00, Wang Ming <machel@vivo.com>:
>> The return value of the ksmbd_vfs_getcasexattr() is signed.
>> However, the return value is being assigned to an unsigned
>> variable and subsequently recasted, causing warnings. Use
>> a signed type.
>>
>> Signed-off-by: Wang Ming <machel@vivo.com>
> Acked-by: Namjae Jeon <linkinjeon@kernel.org>
> 
> Thanks for your patch!
> 

FYI, this is missing my previous Acked-by. The updated changelog
otherwise looks good.

Tom.