Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 21:51:23 +0800
From:   Oliver Sang <oliver.sang@intel.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
CC:     "Liam R. Howlett" <Liam.Howlett@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>, <lkp@lists.01.org>,
        <lkp@intel.com>, <oliver.sang@intel.com>
Subject: Re: [mm] 408579cd62: WARNING:suspicious_RCU_usage
Message-ID: <ZKQj238p843J4eZ1@xsang-OptiPlex-9020>
References: <ZKIsoMOT71uwCIZX@xsang-OptiPlex-9020>
 <CAHk-=wg1_8L+e09_RuX=Z_49oLn8=w82YzCk+kybS-ymSd_zbA@mail.gmail.com>
 <ZKN6CdkKyxBShPHi@xsang-OptiPlex-9020>
 <CAHk-=wjXEzCV7HGPS=2zgJJ8R14e97hAesQ_7fjFZNS=jOADYw@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAHk-=wjXEzCV7HGPS=2zgJJ8R14e97hAesQ_7fjFZNS=jOADYw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?74gxEWPVl8nXqlKPyc6MsYf4uDbK0MbUy1gAS5zf8lZlIG0Q/6VlRY9lU140?=
 =?us-ascii?Q?82SwQWQl6bZEVR69P7YwHk/ZVbUES+RqTRiaLJUfRsdzC3pNaOQOVDJA/OSp?=
 =?us-ascii?Q?YWagZgIheML7bbRHHTYeeKKdDbW2+IGJoURN4vAqvFUWEAavCoOqyQmDAtPO?=
 =?us-ascii?Q?Oxg/ccNQhvvdl8XTVihVSoBz91JRPuSR/8y3Ukn+QMtIjmY4R5D0tR1UUaBt?=
 =?us-ascii?Q?O8XWDRibSngs9A/ol1ntclRmxnGbXNh5sBq28/Jah0BHTFK/+ESLtn5tE1Bk?=
 =?us-ascii?Q?807SrP1ki6AZqn5zCwycbp6fHeNW53mj6el8XwCe8JtNegTArcoLMCCmQQt4?=
 =?us-ascii?Q?x74S+CNeiSGhP+LULjPVTDEsTE4wlpyH3GAxGjDFxVzrrjgz6xK97+Y6cuQZ?=
 =?us-ascii?Q?+W2UNJqDHmhw2feszv01bjIbaz2sBeSF8gxn7EqBRop//c4b/W/fZNY8ZaWx?=
 =?us-ascii?Q?izTY6pBqQ9J73Hn0YyII/7dwoilmgEsF1xzDaHHZ8CdH5LRj1zbkDxT4Yf8t?=
 =?us-ascii?Q?OCZkZhYN5NFYLFCFss0tPxzEL66O5KhHmau9E1IU3VEQAVFOhCQ2wFDjr9kJ?=
 =?us-ascii?Q?brMnJmD0vRFStiGxl9PxLUANN+LyUs8jd2OjOnKAzd1NVNd4kMrPZoyAiOSm?=
 =?us-ascii?Q?rsUf5F2VIeo7dpUutDQ79d0c9e7TkLfb4cM9c9oEJXEWsHy/RwdWUJFxPJj1?=
 =?us-ascii?Q?2CR2NEAfySO5h/QH+ZELV3Z1pX/xcvSPKqegK2AWyHT9rgKP6eut85SVxOEZ?=
 =?us-ascii?Q?vq6sHxwDzVOF9/NrC5BxEhi/ebHO7zunrTfjhHwmhbCAXgwjJvzO/w20Cvjy?=
 =?us-ascii?Q?TEKko6kFTe+jRyfSfTlhbXBZ9Ng1QmVbni2rwDll6pTpFFk0nS6AxymIM6mb?=
 =?us-ascii?Q?oewnJqwzLItgozkZJHpWplQpHXwohJXfF/eA6ZAIH3XN0ZIyl7ueRqoSUX2y?=
 =?us-ascii?Q?+RQ5KaiworBQiXgJL9tO6koZRVAX+PwL6EateTJgx6FmVIZRZxxK4Fn4a8ID?=
 =?us-ascii?Q?hjiPikrtUS+7gO8jePPV+DAypUXtg2Fm2e5GF3cQixBzstivBAFPyx0rs2YS?=
 =?us-ascii?Q?+lV1AgSwMQrHDItSKza3vDvy7W3OYlgJ3Ofy+ldPcC5wNVJR00eWeY1AEmKs?=
 =?us-ascii?Q?/HZwPJgiBFf7XyOgyqE3tWgaWAHhDJzy5qMtEY+rWRz0lxSnClueMRdK3D0G?=
 =?us-ascii?Q?Zpq/vDVEw0fmzoJuzpfvUpYFzRdzRLZYYAGg9lDfu6sPLbMK8f82nerU8T/n?=
 =?us-ascii?Q?0BEyHfF7r8BnYP36zI0mHCcPu6MNHv9mVJhDsQ/KL3KSoxaqv6gbDf9avv4+?=
 =?us-ascii?Q?Wa9jvWc2YypaCVDJ0QzMv62U2xjzTMDu6BoAFTuxJweYPL7QiUAisMf9oQZz?=
 =?us-ascii?Q?KY2nWHWIp/6Pos0dWJ0z0NZL7wX246EPuh8jSAbhYtwUl/atjuoyqoAqrFTP?=
 =?us-ascii?Q?7xVawgnnt2LkBLNmClu1lsp4f2BsiyvTD59HFiRgGgF7mAfPW5v/spCN0Wk0?=
 =?us-ascii?Q?U+IY+I2m3V3ToGeEGcm7gTcaZ6kNzCCt6WJmXruOzbBp4YIrg/5Q4m+iaBoh?=
 =?us-ascii?Q?AYe61ye0eRYqCmCrfBQ8cJ/xEm4iXfW4OjBfcGFvFEwbE2IQChzlJN1Dt3W4?=
 =?us-ascii?Q?fA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 322f9294-1d1e-432d-6012-08db7c95c6de
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6779.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 13:51:33.3913
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7Tq8D2JiudtGUweLyLkM8P40ynrf4depwTLWcxNhTtnMxLDEVe9v7Cbxydr+a+SsU/bYlVjKiqIlEEL7SiZXLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8369
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

hi, Linus,

On Mon, Jul 03, 2023 at 07:29:48PM -0700, Linus Torvalds wrote:
> On Mon, 3 Jul 2023 at 18:48, Oliver Sang <oliver.sang@intel.com> wrote:
> >
> > by patch [1], we found the warning is not fixed.
> 
> Hmm. I already committed that "fix" as obvious, since the main
> difference in commit 408579cd627a ("mm: Update do_vmi_align_munmap()
> return semantics") around that validate_mm() call was how it did that
> mmap_read_unlock().
> 
> > we also found there are some changes in stack backtrace. now it's as below:
> > (detail dmesg is attached)
> >
> > [   26.412372][    T1] stack backtrace:
> > [   26.412846][    T1] CPU: 0 PID: 1 Comm: systemd Not tainted 6.4.0-09908-gcb226fb1fb7a #1
> > [   26.413506][    T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
> > [   26.414326][    T1] Call Trace:
> > [   26.414605][    T1]  <TASK>
> > [   26.414847][    T1]  dump_stack_lvl+0x73/0xc0
> > [   26.415225][    T1]  lockdep_rcu_suspicious+0x1b7/0x280
> > [   26.415669][    T1]  mas_start+0x280/0x400
> > [   26.416037][    T1]  mas_find+0x27a/0x400
> > [   26.416391][    T1]  validate_mm+0x8b/0x2c0
> > [   26.416757][    T1]  __se_sys_brk+0xa35/0xc00
> 
> Ok, that is indeed a very different stack trace.
> 
> So maybe the fix is a real fix, but the first complaint shut up
> lockdep, so this is the *second* and unrelated complaint.
> 
> And indeed: it turns out that do_vma_munmap() does this:
> 
>         ret = do_vmi_align_munmap(vmi, vma, mm, start, end, uf, unlock);
>         validate_mm(mm);
> 
> and so we have *another* validate_mm() that is now done outside the lock.
> 
> That one is actually pretty pointless. We've *just* validated the mm
> already inside do_vmi_align_munmap(), except we only did it in one of
> the two return cases.
> 
> So I think the fix is to just move that validate_mm() into the other
> return case of do_vmi_align_munmap(), and remove it from the caller.
> 
> IOW, something like the attached (NOTE! This is in *addition* to the
> previous patch, which is the same as the one you quoted, just with
> slightly different whitespace as commit ae80b4041984: "mm: validate
> the mm before dropping the mmap lock").

Thanks a lot for guidance!
I applied below patch directly upon ae80b4041984, and confirmed the
WARNING gone. Thanks

> 
>                Linus

>  mm/mmap.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 547b40531791..204ddcd52625 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2571,6 +2571,7 @@ do_vmi_align_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma,
>  	__mt_destroy(&mt_detach);
>  start_split_failed:
>  map_count_exceeded:
> +	validate_mm(mm);
>  	return error;
>  }
>  
> @@ -3019,12 +3020,9 @@ int do_vma_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma,
>  		bool unlock)
>  {
>  	struct mm_struct *mm = vma->vm_mm;
> -	int ret;
>  
>  	arch_unmap(mm, start, end);
> -	ret = do_vmi_align_munmap(vmi, vma, mm, start, end, uf, unlock);
> -	validate_mm(mm);
> -	return ret;
> +	return do_vmi_align_munmap(vmi, vma, mm, start, end, uf, unlock);
>  }
>  
>  /*