Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27747748rwd; Tue, 4 Jul 2023 07:19:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlFs/V9bDbG3idqZGmOYH+BqHG37BQ8Y1X3Xwch03OXiNS68oU+rn4Ph/jw0MWs48mbgtPgd X-Received: by 2002:a17:902:b90a:b0:1b6:9fec:8134 with SMTP id bf10-20020a170902b90a00b001b69fec8134mr13902186plb.46.1688480348459; Tue, 04 Jul 2023 07:19:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688480348; cv=none; d=google.com; s=arc-20160816; b=EPNCb0trw4mLCxdF8gKqxL15fn8Nd59jRn/hER2eNveTbL+PWBPtL5qRCAbpziUM4x CMjvyPYAm+2DuYmnws1Yn3jReGF2Tp5QDv5MxloKxgSPVcPxp2bP3RB0r9IGCotHDdTr iZtw/gEdXaxKC7TMTbOFJDFbqvyqVhTofEmtDDiJ10NLIdfgb/Rj1XFOZIJpW1UZXvRB yfUCfJtbVCMn9MZllKeKWAHLN+L2kknrOcNa1Hau84ux0gC5h7WpTvqPEWmaQ/hejT6C CfQ2ELija8TPoTGw0C9qbt+iHUbJsBYwWZIbj2639Mhr07ya11x91jqx3KoQ62jEMcKC MIIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=TEl+S+7LqucFZh/MHydZLwE8UPzr7gkC90FzPJTSRCM=; fh=2p7x1eD9nFPsVGYCS5JsGvAr6wG4yWbZPt4l9Vb431c=; b=M0jvrRnxbdHeEzt7gGn0/HXDruo59Pszm+D50IKxeYMFNQGcyi9vXXSL49Lt/Bz/JW 6slITzb4ZaLUOtdWfYk+u1yz0fnszyjTWNZN58Uef8CCvLVjC9DyjOAmHGQW7uhOb9fQ jpTyHw3LAh5MGmE5Gs0tBNwAqYBFMG0bltNAFcj94S2roJLQHar5Y7pV3Fa+VpWfqSX4 POTF0mkCzY7GB9SPtMq3YreBe/XXa44gmT5WQQj2nGU7/JaHzbSojPMxLs4dfdT2ktUC ep82o36lggY5GH2PC41Va89R77eqeeeu7yAnFrRkXL1CQRDFS9rHPjERzxLCURvr8t/Y mMTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i13-20020a17090332cd00b001b8a67f1c10si1458043plr.468.2023.07.04.07.18.52; Tue, 04 Jul 2023 07:19:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbjGDOIL (ORCPT + 99 others); Tue, 4 Jul 2023 10:08:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbjGDOIE (ORCPT ); Tue, 4 Jul 2023 10:08:04 -0400 Received: from unicorn.mansr.com (unicorn.mansr.com [81.2.72.234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71A55113; Tue, 4 Jul 2023 07:08:03 -0700 (PDT) Received: from raven.mansr.com (raven.mansr.com [81.2.72.235]) by unicorn.mansr.com (Postfix) with ESMTPS id 6C3CF15360; Tue, 4 Jul 2023 15:08:01 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 253D3219FC1; Tue, 4 Jul 2023 15:08:01 +0100 (BST) From: Mans Rullgard To: Lee Jones , Daniel Thompson , Jingoo Han Cc: Helge Deller , Tomi Valkeinen , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] backlight: led_bl: fix initial power state Date: Tue, 4 Jul 2023 15:07:50 +0100 Message-ID: <20230704140750.25799-1-mans@mansr.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The condition for the initial power state based on the default brightness value is reversed. Fix it. Fixes: ae232e45acf9 ("backlight: add led-backlight driver") Signed-off-by: Mans Rullgard --- drivers/video/backlight/led_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c index 3259292fda76..28e83618a296 100644 --- a/drivers/video/backlight/led_bl.c +++ b/drivers/video/backlight/led_bl.c @@ -200,8 +200,8 @@ static int led_bl_probe(struct platform_device *pdev) props.type = BACKLIGHT_RAW; props.max_brightness = priv->max_brightness; props.brightness = priv->default_brightness; - props.power = (priv->default_brightness > 0) ? FB_BLANK_POWERDOWN : - FB_BLANK_UNBLANK; + props.power = (priv->default_brightness > 0) ? FB_BLANK_UNBLANK : + FB_BLANK_POWERDOWN; priv->bl_dev = backlight_device_register(dev_name(&pdev->dev), &pdev->dev, priv, &led_bl_ops, &props); if (IS_ERR(priv->bl_dev)) { -- 2.41.0