Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Sunil Goutham <sgoutham@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] net:thunder_bgx:Fix resource leaks in device_for_each_child_node() loops
Date:   Tue,  4 Jul 2023 22:14:47 +0800
Message-Id: <20230704141457.4844-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YCjC9m7BE31g3tIBUFwBMAlJ0RZ3YrSMkHjwQd1DHo401e3cEekYjhzJOdZO?=
 =?us-ascii?Q?vAS8QRoib+MM82ZSNYakGgSkzc4WUJBxrumcvQ1aB0mqTC2Q5UxepT69nz7/?=
 =?us-ascii?Q?Do+u9IUFbEChj98xFqsBfWDp9YXW/DSMjjjFuyGp2q269ausI8Z/95VKc1Ko?=
 =?us-ascii?Q?umAdbwaH8vPthSya6BmCKU0BUYuQOkK3isCXfNGv1nKjzF2SmEPv1B6dCM8O?=
 =?us-ascii?Q?N+LPLt3HDPDPuj25s50xbVpYWw0v8T1DtZvky5+pkJHwh1/yM09apetvCw4l?=
 =?us-ascii?Q?mF25VYQQGOV2dpDrdpNi414zH6Wt0fPHw/SwYL/fXs+FXkxq2TxKGuwESfSV?=
 =?us-ascii?Q?PQuox3ow+7FZyqKMmSRp1+84jk6kGR16PJPts/RA8EBmhVOm9FXN+sNbi932?=
 =?us-ascii?Q?xA8wSPh0EbItdSqlbxg9QqBFUkvXHnqwPO3z9K+5hOJt+vlUuRXcBjOjpxKz?=
 =?us-ascii?Q?Kecnop3ijVqjlkoo7rMI9HUGB5P3n0HX0g6+mpLbOFoUtvb0kRBUGujXMn2Y?=
 =?us-ascii?Q?5shWTWFwGW06qAONATQJBG7kYiS/3j4nxmEXZkcvyEgn7QHuGYZgJJo75uTi?=
 =?us-ascii?Q?PmjrgJgKygi+XMVtU7QFReX9BSR4AOMy/PGDR/ATzjUSvMkO4ka2pAYi0RM4?=
 =?us-ascii?Q?zjY2W/Km+57myMZ4YDt7v1H0OHh6NO0N9qAYbUTAOHpjP6QaO0+J/5ke6R+3?=
 =?us-ascii?Q?ctuZCHu4xZkZp7vrPiZNNf2oGcvHv2QcxfFA80rwuEPEewOh39FV096eIoq0?=
 =?us-ascii?Q?mH30l0Pk9K1PJypn7fo0zhN2J6o3KFCbdvjXdRQ7kKPWHT+xWNw/XMFVYWcc?=
 =?us-ascii?Q?U10kHgbBPi7GaJ/7K7N67BlMD8y3/2FmC28bUney7OTMxXdsdtKNQg6/B8nR?=
 =?us-ascii?Q?s+tpaIm7uvEcEqrlX3YLmWoL8X3bs/uJWrCfecE6sbeXjcrkSmrPDuPW+M5A?=
 =?us-ascii?Q?DCqSO9/fbnNRgDJXfLYITT51u8zjCpKsojgDP9pGFtyTzK7mwvADbFohMm9G?=
 =?us-ascii?Q?kalnc5aO23wV5q+rgMi5FHTuV5ztRXKhf+LWVgDHWjsWf0P8zelwoxPtvlMi?=
 =?us-ascii?Q?LtRmNTutvTZCKJ7DyiIGY78+p8CtTYvj1gCebaGV0BigK4kLj6eJ2CyquiwR?=
 =?us-ascii?Q?sZjfiR8w/aaRAPMmDEbBHrfSjda3KdqKyN7Z3hu7326if8dujPefdEG0mAKp?=
 =?us-ascii?Q?lEaADNv8onY/NauxAAyk7J/vvv8lSUPPKbV4Emb54W9vfttVwRer/KqnYo+d?=
 =?us-ascii?Q?bF9/WyI/n/Bqjh7Czs3A/AawxnhEoCcomWi6SUqti7jveTCGRFdU9aNxSOHr?=
 =?us-ascii?Q?l93dbjyKHFyihBnoaGyVrNkMwmM9nrOk4h2Li9IhAwLXVKosDTziv19wrPAx?=
 =?us-ascii?Q?n4wVOR4WufQWKlXn1H3HUHzqg7f6u0S6P7JHYYV6vWhKszbplEarC1UahlwW?=
 =?us-ascii?Q?AXCCpUyk3DPU1VRmFFsGZmohgA+QDT3CWrDvTwpv8woVYq0Efw0JQzINWuhh?=
 =?us-ascii?Q?tAT/G0v1Q/XiFn2yZrGMwzXHh2IxT4u9RPzL3VuFWQTvkC485vYBo4+NSPbK?=
 =?us-ascii?Q?0RO82RR6MM9Xtgz47wIfnehEt0Dtxr1FhxnccakZ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c2d2e9b-5d2b-4d1c-0555-08db7c9913cf
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:15:10.8801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YnqzQmSPnlNU0+dDJWrpdiRmP/z7mtfB8yg5w2jAu9z5YhK/LXHHtqNfVQ3cT3bbzdLLjCDK9ddhGYPDHc90Pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6527
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The device_for_each_child_node() loop in
bgx_init_of_phy() function should have
fwnode_handle_put() before break which could
avoid resource leaks. 
This patch could fix this bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index a317feb8d..dad32d36a 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1478,8 +1478,10 @@ static int bgx_init_of_phy(struct bgx *bgx)
 		 * cannot handle it, so exit the loop.
 		 */
 		node = to_of_node(fwn);
-		if (!node)
+		if (!node) {
+			fwnode_handle_put(fwn);
 			break;
+		}
 
 		of_get_mac_address(node, bgx->lmac[lmac].mac);
 
@@ -1503,6 +1505,7 @@ static int bgx_init_of_phy(struct bgx *bgx)
 		lmac++;
 		if (lmac == bgx->max_lmac) {
 			of_node_put(node);
+			fwnode_handle_put(fwn);
 			break;
 		}
 	}
-- 
2.25.1