Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 11:25:48 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Oliver Sang <oliver.sang@intel.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org,
        lkp@intel.com
Subject: Re: [mm] 408579cd62: WARNING:suspicious_RCU_usage
Message-ID: <20230704152548.afqtyylbrxzunq55@revolver>
References: <ZKIsoMOT71uwCIZX@xsang-OptiPlex-9020>
 <CAHk-=wg1_8L+e09_RuX=Z_49oLn8=w82YzCk+kybS-ymSd_zbA@mail.gmail.com>
 <ZKN6CdkKyxBShPHi@xsang-OptiPlex-9020>
 <CAHk-=wjXEzCV7HGPS=2zgJJ8R14e97hAesQ_7fjFZNS=jOADYw@mail.gmail.com>
 <ZKQj238p843J4eZ1@xsang-OptiPlex-9020>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZKQj238p843J4eZ1@xsang-OptiPlex-9020>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?anbc8hUz/7kJiM3Av4hsdTl56rOeH/1F9cabee0VZjMJ0gzpZMTkzluNad+d?=
 =?us-ascii?Q?EDjYKZtnv52FBvct8BfSsYdhiSsuuJPX9eRbF4jevA8vNEGYjGIXH5yC1eQJ?=
 =?us-ascii?Q?wO7Xm3TaJtv0FdBZbeSzuzmwFCMS010G/H9hmLeKTR+6sM9o9YaVHIMI8Th6?=
 =?us-ascii?Q?dWCtq4BPEX/nkpfjylleNxXQ6Pm60hGXhl79FYH4Qd0XTiBSVlYhdNhaf7Pr?=
 =?us-ascii?Q?hnOnw7rNtQxWQ8BUqQmuH32dejKGqFqKgBUAIWua6rnhEwFXErtVGKqrw4T4?=
 =?us-ascii?Q?MkJahdQTlLu2rS9zmshlvwju8xJ9cH8Z3FZWv23Eh26W5kHwjrfQdtDL+j/h?=
 =?us-ascii?Q?a+KHdFSJhgHweZ7WfIJnbxZ18+LyPm7jgsrcqirzCN7DSwv94XS7DSicOqqI?=
 =?us-ascii?Q?6sihIqP85yK+c4RYmpMaH64TJaCfDuklsGcydwHSia9ixbEe4axS7uK/P3aJ?=
 =?us-ascii?Q?t6pIpLCiqocva7ct9q2XR/bkPpITlFQ+856RLJFtd6K3zh99VXpH9VkkLxnD?=
 =?us-ascii?Q?3UfXpsl5bz8jrXigZtUntVPex7qbQpNYkMI40yoXyfnBUvs7L0wsYYa4L3+V?=
 =?us-ascii?Q?vHQPgXbcH93Qkp+3N79dGHlPOIPKNh97oKFvGlHprSbqerOvEXYJgbsn+wwG?=
 =?us-ascii?Q?YdO4pZQWw1uA5t/33rF02sBZVbug5R9eEWRacI/qcYRFuNMDyIhzWaBKb0ll?=
 =?us-ascii?Q?OYEEx0UoGj1SgyYztoDY7kGSwCBoidOSNGDobk4CCPzCm36DDVZPty3CjAP0?=
 =?us-ascii?Q?MhPjBUBr0m77zlC935Ru0AOy0M41C8VtsaKx6cMumc9WlbRqMf51RikUangH?=
 =?us-ascii?Q?xq0phI/G+1PM11YyznefMsnTdy8qFRZgdkbxE4Dd4rAK5/ZJGNVh4JCXtuRB?=
 =?us-ascii?Q?YAlixIiTAn5+NtbLafP4DWaoDXkIpLUXWsNdHXHvCzR8h9j+vQ++Vrz3akK5?=
 =?us-ascii?Q?fpIayRAUEmNizdxTaK36CKiGUfPtJ+nDG46birYzODDkid/zNj/Tu1pyBPuK?=
 =?us-ascii?Q?4oXZHZjTQjwX9tx/J1UYpTj9KagIN9/wDXBeQmgDosnSpwtpbhcX3Ae+18s6?=
 =?us-ascii?Q?lw9nIw0Zcr2PAkwUM3ckwgHLadaqm/ijmNdr8i6SoyZM6K6irH/lLjB9jzme?=
 =?us-ascii?Q?T3SQ3eZo55MTY+8sIkW7y5dt+awD4Uib+NvWmGVCSWsveH3aVvWhZmpHahsg?=
 =?us-ascii?Q?V9WHhOR+JEnDqxCRCMlq49u/NMGUtyw5NMHV5zBIOG6dnRyPgCkOru6ArY1s?=
 =?us-ascii?Q?/a0d2TgFcj1NPvgLraWvrmuYu1h4HCIJgDqhs9ElpnRYFJA3rK/J6O1yFImy?=
 =?us-ascii?Q?sl3L61ZFEyoq8BqSHzH4zZkciGLtLT3Yw57LylgRn/MFYMAyKCo0Ae+2Rd/n?=
 =?us-ascii?Q?71/f/el3Xs8nAiE+aCPbkzfwU10l5O/8ptXsB9NtGqjyHHbeRHXdBQuvBMeS?=
 =?us-ascii?Q?Zs4HF57Q4fMVpHFUqkel9NdX1uQvii+pOlaAT8OxP5n4gJhf/Sj6lhI4jZAM?=
 =?us-ascii?Q?5HWrysU9HgAIfzI0Dzktel+UHOIHIa9o5ioIyRgF7NTJnf9Z/SKoabRN+lBk?=
 =?us-ascii?Q?SZWgYi0MDWjnLsAJDLbDScJWNFD4VYwPTPvSh960bhcrbjnVvFMof/My2bvZ?=
 =?us-ascii?Q?Eg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: G3cUNxnZD2lzDCtkINUAaEGvXRXbgyNP2c02jyFdNPSjMYcf9WIs8o38CX8oV/bX/+qk7/1R20h+DThH04pVq+MAtc6+ekrqgFIvBIuotAZs7GInp/umE3DoXsAD7UH1wqCsfkW8IQhdHEvsg2z8PetEBfueg/bcWzF+PylRhum+yBFqb/YB3d4VFIL2iiYab3Q8nbkSfLBtIYavN80og2qcCWT0SyqjDCKUvMapS6YSOkBjMQ9CVVLJYK9Mt3k6VHSjrftISZnUInOwZxm/5VTAHS6gtY70K2PkIDXjU+QMMJNFUJRnFF2yAVGNssy+dgCmH/azSVAYHWbz5qfuaOyLPCROuD0UZzYJc8TgFcwG6scSYc+qLXzl2EaZRNiq2FrSEodhwXY2Rl0h4JpMmfSNrw+6XXXr2hZmKJnE5pPN8XkzqP9T82aPOzALXCBM0nutwmEEtYxGFQJ6huWzmDezbsXcpkZBviN66y2RCfKEPJyb+fekV4/CKv8/DTsrb2DTNLlGJ2M+TKDdT+kq6WjEnI3S6kMKgnBhLMgxth1gMHO6CcbbZb/ir9vVJL4YotCghBfHzeZ8aABPeqZBwdP0J8b+lkoj21zqXT6vQSH3rQQf6XbRDg4KV0ypTMpds3GKVEUuikq/cjXgQTEzpXk0ysyle6ClyJdOROBHAV5+rErHDHF9a4elZb1Zdh9F3a/3vRPGbjeEQvJpcjqoME2h4QHz5NUbsMKj+Bk1ZVe4Fa81xBbi802SoBQv/DJoR/XZZ5nBYAC03/iPV29KrdHg/kMmb415w1latKhcOXsfMOr30rkYwoAMafrXGonzyVXBJXMjKkreLo35vBRRW4CddW9OkbufMmfctz8dy5uPYQ5EtmvvUTm1hRbgQ8Q5
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ba644d1-0f81-4165-d490-08db7ca2f2d8
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 15:25:50.4632
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GTAg0018j7JubiVGLc9HTRF61P+UNK4vzX2MlmzcEsiee1GIAfcKTPUkUAGQZcd8Gz1litILyrH+NKnyThyufg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5824
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-04_10,2023-07-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307040133
X-Proofpoint-ORIG-GUID: TshNGlJDLLFmkyfXcQvEt7c5WE2FEzDO
X-Proofpoint-GUID: TshNGlJDLLFmkyfXcQvEt7c5WE2FEzDO
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Oliver Sang <oliver.sang@intel.com> [230704 09:51]:
> hi, Linus,
> 
> On Mon, Jul 03, 2023 at 07:29:48PM -0700, Linus Torvalds wrote:
> > On Mon, 3 Jul 2023 at 18:48, Oliver Sang <oliver.sang@intel.com> wrote:
> > >
> > > by patch [1], we found the warning is not fixed.
> > 
> > Hmm. I already committed that "fix" as obvious, since the main
> > difference in commit 408579cd627a ("mm: Update do_vmi_align_munmap()
> > return semantics") around that validate_mm() call was how it did that
> > mmap_read_unlock().
> > 
> > > we also found there are some changes in stack backtrace. now it's as below:
> > > (detail dmesg is attached)
> > >
> > > [   26.412372][    T1] stack backtrace:
> > > [   26.412846][    T1] CPU: 0 PID: 1 Comm: systemd Not tainted 6.4.0-09908-gcb226fb1fb7a #1
> > > [   26.413506][    T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
> > > [   26.414326][    T1] Call Trace:
> > > [   26.414605][    T1]  <TASK>
> > > [   26.414847][    T1]  dump_stack_lvl+0x73/0xc0
> > > [   26.415225][    T1]  lockdep_rcu_suspicious+0x1b7/0x280
> > > [   26.415669][    T1]  mas_start+0x280/0x400
> > > [   26.416037][    T1]  mas_find+0x27a/0x400
> > > [   26.416391][    T1]  validate_mm+0x8b/0x2c0
> > > [   26.416757][    T1]  __se_sys_brk+0xa35/0xc00
> > 
> > Ok, that is indeed a very different stack trace.
> > 
> > So maybe the fix is a real fix, but the first complaint shut up
> > lockdep, so this is the *second* and unrelated complaint.
> > 
> > And indeed: it turns out that do_vma_munmap() does this:
> > 
> >         ret = do_vmi_align_munmap(vmi, vma, mm, start, end, uf, unlock);
> >         validate_mm(mm);
> > 
> > and so we have *another* validate_mm() that is now done outside the lock.
> > 
> > That one is actually pretty pointless. We've *just* validated the mm
> > already inside do_vmi_align_munmap(), except we only did it in one of
> > the two return cases.
> > 
> > So I think the fix is to just move that validate_mm() into the other
> > return case of do_vmi_align_munmap(), and remove it from the caller.
> > 
> > IOW, something like the attached (NOTE! This is in *addition* to the
> > previous patch, which is the same as the one you quoted, just with
> > slightly different whitespace as commit ae80b4041984: "mm: validate
> > the mm before dropping the mmap lock").
> 
> Thanks a lot for guidance!
> I applied below patch directly upon ae80b4041984, and confirmed the
> WARNING gone. Thanks
> 

Thanks for testing this.

I can clean more of this up now that the mmap locking has been changed.
For instance, we can drop a number of checks before a write (and all
read cases, if any remain) since there is no alteration without the
write lock.

Thanks,
Liam