Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     kernel test robot <lkp@intel.com>
Cc:     llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: drivers/hid/hid-nvidia-shield.c:59:2: warning: field  within
 'struct thunderstrike_hostcmd_resp_report' is less aligned than 'union
 thunderstrike_hostcmd_resp_report::(anonymous at
 drivers/hid/hid-nvidia-shield.c:59:2)' and is usually due to 'struct
 thund...
In-Reply-To: <202307041500.6bKn7nCl-lkp@intel.com> (kernel test robot's
        message of "Tue, 4 Jul 2023 15:13:08 +0800")
References: <202307041500.6bKn7nCl-lkp@intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Date:   Tue, 04 Jul 2023 08:56:39 -0700
Message-ID: <87a5wb7jrc.fsf@nvidia.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2XKQ/XnW4Y3ffgg6lYUOOEoAipShFBrhnfzpRgqUC9CjHfJsrd+TrXi/mq82?=
 =?us-ascii?Q?ZmC9QVkVDxJTxJd4W3owuPCv/8TPB4HStXT1SUoQhWSTJs60QZYdiT/YmJeb?=
 =?us-ascii?Q?EU8f0Rz3ggyhHFQdj2OkGvkH6ZRJ8miC+rI0fB0OToyq5A7j4URqMBfzrKIV?=
 =?us-ascii?Q?/CpVZsPhFSvq7GkJA9Ag6st13H9aoa1U30gxc/fv3WXCcV/ML0bWtxYu+jcT?=
 =?us-ascii?Q?P/q3Aa5DcdABrmxyj4RNUGTPMMhM48M9jG2Ye9pFPSwYih4xrVcYGg6my2ME?=
 =?us-ascii?Q?YA7Jz3U7o54dpf9wEF4UfOoMQwVRaHfCIWZHqwaUdEUCfgO/ZKqROrPa8LF5?=
 =?us-ascii?Q?O8A05RaH/bfZPGT1b71OH09bye3dbMlN7IaoK8VgzYgZWc3d2E2fgTUaXQ+g?=
 =?us-ascii?Q?BaxNCqxC4/YqiXnmZhpdW0Ecje5ZTCWli/Hc4bOFpLda0XuYHR76C5eP1La8?=
 =?us-ascii?Q?rnAAsFN/yT6VHUGMzYjI2pfasP8j2ZDKZyQMBhPbfTCGh4oikkTBRD189CFk?=
 =?us-ascii?Q?L9pJTwVwQRaC+ra0i66NiM/W4fGqBkWChKiwUOzcjSBecYUetsWj7Dnk6DRl?=
 =?us-ascii?Q?TvmFA3gq52xQs4LI1MiXpCl6mpMvaeFumnhKm+0CXvrawoPCyrlz0aZAU7qf?=
 =?us-ascii?Q?F1Yura26YA7FLR2kDBoItrEg4e4Ja+xItVwW+Ch9FhPmRVrzQyKGokLqcxZH?=
 =?us-ascii?Q?qCMEpQcy4DJvCzT22LuNDNJ4EQxMDnzBjsqyahmxx1gXChSwed50Bqqo49wt?=
 =?us-ascii?Q?pKjTpsL6+7fJAjCKLmxYGrG36TIu+jDVF80SBKN6xCB01shSooNAzKZFDEEK?=
 =?us-ascii?Q?2OhYM0Sl6LrEQwU1GopPdT+ol7bU8QB29SQ2WlB7p2/0R4Tg9q2HcJ0m6NH+?=
 =?us-ascii?Q?HV9eoXO2PfDVzCAb1lgsdwW1kRc6FHyZEUg+BqUQnORoVQ352amQX489Boy+?=
 =?us-ascii?Q?OxZTwk58T9OELYe3KBvpYC7Vmc9pDWJ+ULbETh9DWf5spvYOzpWzyLsXjmDe?=
 =?us-ascii?Q?T+YV63NWhgI6DWSw9gG3HwF0KZXuV2BRpBF3rarzj7RkfRRwI8OISzWVPf6x?=
 =?us-ascii?Q?nfYQKazCAPTy9cffgB4nFRZMB/dun1Lg17UeqrceOZ0TQenPfarFx3qXSiqG?=
 =?us-ascii?Q?Ui/K4lMJHURU6TMJaMOgfYJFvvAYRuEYiptqTooHmszBF46C4DWMGj3sb4CF?=
 =?us-ascii?Q?V4hNdJ7Z+Lam/E87U2KgxJxlrRMIm2FiJTsbopkv89YRFlCY+qgQpEAofx92?=
 =?us-ascii?Q?Ja4kpZm8T0HD8f6hoPbYiXiecOIgPKC0P6fl6D+xqu2Fego72ejuQt0xddFv?=
 =?us-ascii?Q?bK6FUqciyxFgpKYt3sRGgk91fMLlYkaVfA/s+aL5eqPUzQ33Mciv+MkS6Kuy?=
 =?us-ascii?Q?9ppxW3yTNRLb8b+OvV11ZQqPYGgBYQGaPaGZ/4lDPaPzw5P6VORr0zG5puBD?=
 =?us-ascii?Q?sExVu1wpdhg76uqXRMSTRLmhswPHK7tQK1sZEWrNztut6jVlhnh6zOysFray?=
 =?us-ascii?Q?cFgMwnT8NRJSsGYipROnyeG0J5ymOVtRpe2T/k50zpebF7WkqTBKQRNg0TqY?=
 =?us-ascii?Q?kd7gLcOJr+MHmhAwvoj1bxvj2v4WEMBnuT+ehRk5?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c73f267-cd10-4cad-c81f-08db7ca74ba3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 15:56:57.5137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7rX/UNoGwTpFAXaPcYoq9ftElVyNrIv7b4R3FU9x1fsWJEztkWuRwq9pz/zPuFbmn70fb+iOCJIuYD8xHOomGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8738
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 04 Jul, 2023 15:13:08 +0800 kernel test robot <lkp@intel.com> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   24be4d0b46bb0c3c1dc7bacd30957d6144a70dfc
> commit: 09308562d4afb1abc66366608fa1cb9de783272f HID: nvidia-shield: Initial driver implementation with Thunderstrike support
> date:   4 weeks ago
> config: arm-randconfig-r014-20230704 (https://download.01.org/0day-ci/archive/20230704/202307041500.6bKn7nCl-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce: (https://download.01.org/0day-ci/archive/20230704/202307041500.6bKn7nCl-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202307041500.6bKn7nCl-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/hid/hid-nvidia-shield.c:59:2: warning: field  within 'struct thunderstrike_hostcmd_resp_report' is less aligned than 'union thunderstrike_hostcmd_resp_report::(anonymous at drivers/hid/hid-nvidia-shield.c:59:2)' and is usually due to 'struct thunderstrike_hostcmd_resp_report' being packed, which can lead to unaligned accesses [-Wunaligned-access]
>            union {
>            ^
>    1 warning generated.
>
>
> vim +59 drivers/hid/hid-nvidia-shield.c
>
>     53	
>     54	struct thunderstrike_hostcmd_resp_report {
>     55		u8 report_id; /* THUNDERSTRIKE_HOSTCMD_RESP_REPORT_ID */
>     56		u8 cmd_id;
>     57		u8 reserved_at_10;
>     58	
>   > 59		union {
>     60			struct thunderstrike_hostcmd_board_info board_info;
>     61			struct thunderstrike_hostcmd_haptics motors;
>     62			__le16 fw_version;
>     63			u8 payload[30];
>     64		};
>     65	} __packed;
>     66	static_assert(sizeof(struct thunderstrike_hostcmd_resp_report) ==
>     67		      THUNDERSTRIKE_HOSTCMD_REPORT_SIZE);
>     68	

Will send out a fix for this soon.

-- Rahul Rameshbabu