Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 08:58:00 -0700
From:   Stephen Hemminger <stephen@networkplumber.org>
To:     Breno Leitao <leitao@debian.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, sergey.senozhatsky@gmail.com,
        pmladek@suse.com, tj@kernel.or,
        Dave Jones <davej@codemonkey.org.uk>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] netconsole: Append kernel version to message
Message-ID: <20230704085800.38f05b56@hermes.local>
In-Reply-To: <ZKQ3o6byAaJfxHK+@gmail.com>
References: <20230703154155.3460313-1-leitao@debian.org>
        <20230703113410.6352411d@hermes.local>
        <ZKQ3o6byAaJfxHK+@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 4 Jul 2023 08:15:47 -0700
Breno Leitao <leitao@debian.org> wrote:

> Hello Stephen,
> 
> On Mon, Jul 03, 2023 at 11:34:10AM -0700, Stephen Hemminger wrote:
> > On Mon,  3 Jul 2023 08:41:54 -0700
> > leitao@debian.org wrote:
> >   
> > > +config NETCONSOLE_UNAME
> > > +	bool "Add the kernel version to netconsole lines"
> > > +	depends on NETCONSOLE
> > > +	default n
> > > +	help
> > > +	  This option causes extended netcons messages to be prepended with
> > > +	  kernel uname version. This can be useful for monitoring a large
> > > +	  deployment of servers, so, you can easily map outputs to kernel
> > > +	  versions.  
> > 
> > This should be runtime configured like other netconsole options.
> > Not enabled at compile time.  
> 
> Do you mean I should add a new option to netconsole line? This is the
> current line format today:
> 
> 	[+][src-port]@[src-ip]/[<dev>],[tgt-port]@<tgt-ip>/[tgt-macaddr]
> 
> If that is the case, I suppose I want to add something at the beginning
> of format, that specify that uname should be sent. What about something
> as?
> 
> 	[u][+][src-port]@[src-ip]/[<dev>],[tgt-port]@<tgt-ip>/[tgt-macaddr]
> 
> Thanks!

Keep it as simple as possible.
What ever program is reading udp socket knows where it is coming from.
The uname is really not needed.