Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27917871rwd; Tue, 4 Jul 2023 09:39:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7XtWVKWbWl2Zt0osDvpH3IlJ4rKmzwhjDG7zEhHgfGOFpvk1Mk+nQqnQAwDak7OGsT88hA X-Received: by 2002:a05:6a20:728f:b0:11d:1b15:4d28 with SMTP id o15-20020a056a20728f00b0011d1b154d28mr21653337pzk.4.1688488788091; Tue, 04 Jul 2023 09:39:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688488788; cv=none; d=google.com; s=arc-20160816; b=nyU3t3C1SHDRojNVCtLrL8jUxxZrO/d98hXViWTuyRUAwbGdMeH+f4StHC97bHbVF1 GPOV13EBKAAl8FSHF4701s0j9DjUH5eWXLFK60ejwM9iN1hNwDHO5QgOaeIZH8Z7Xw90 bCQrMElgkSlKn3uryNXyVyPmoGdiDyEa/4XSwsOeemUMBSv56572+jjcAqoRDYAYnpxB iZ4D3FgF+mG9clrj0JCWmvLVCmHZxf2eOpR71WdtMrAT4eZjNqdsiqzd6H9YLfS4Mv7M uqAf8PIUQyu1kYo+vjg5gVnylgExJyQu64tEGouHnutQO50ydE+BjL95GUiKWj6rvtXP Mlpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=0zoSLxvXdWi/Yl+BEgvp6RDAlMoTsWmGbOp6gCR7ij0=; fh=3o9bn6WUEZkftFe8FkXj8g5pjBUxlCdCjGkfb0LPknA=; b=KnM5ipAGF8nq5VTXCQuvep5731cb3h/zpstSKyhZMJKZfsUxB+gAeeFDPrtqO0nQm+ kDD7Js2pwOGA17Eqonb6qTk7g2INhFngLPhOrkmyowaj5BMEGaVh82gpvNLkl8mxsDPH V9/Ja/wNuCHrRMRnrlbNkBelF4IuGXuCOLvjE+xCNVcDiIxzu1GYj7zANlmAYbl1wGEl Wsg7wb72CfJiWbPinFc4Wen0DTasATPt7/ELn7sJHxGS+a9wBQQwbmauFvOuJ8MXkTHm cbzg48bGngX+VFh5DsYrxtnHT655zF5iA4gY1ZuZuOoFErYF7Jdf3UL/BWoIH/Gt6Jp/ Ct6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@semihalf.com header.s=google header.b=IvxDZs5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p24-20020a63e658000000b0053f812a109esi21245080pgj.796.2023.07.04.09.39.32; Tue, 04 Jul 2023 09:39:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@semihalf.com header.s=google header.b=IvxDZs5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbjGDQRM (ORCPT + 99 others); Tue, 4 Jul 2023 12:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbjGDQRK (ORCPT ); Tue, 4 Jul 2023 12:17:10 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E67F6E5 for ; Tue, 4 Jul 2023 09:17:08 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-99317e738e8so419923666b.1 for ; Tue, 04 Jul 2023 09:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; t=1688487427; x=1691079427; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0zoSLxvXdWi/Yl+BEgvp6RDAlMoTsWmGbOp6gCR7ij0=; b=IvxDZs5FZwr/WzKLQBOPETWNGRsTF6HYbMFn0CA4Rn6PX6e94Z0KzCbI46ct5SNPVC ZFSay5Q+Bcevmw2q5h3dvgLXq53rthbmWoJkH/qKb0W31EbZZj2D6AN4gcBL3yJlxgIB w3xcNxYg/ddD/es0NxpN1vd5LovJvOdD92AiYBbKibxM/fWGE1sLubha+vgKeM3eaKTW Guw89lFVcKe1sOZDjPmk3oUq5ImJ4KhwlKWH1SwRDyFOAxQh16vkF9nirBx6a/G0DMrL FCZ7kvsrIHo9To5kP6rjdqJZ0LO3deobSvbqjthhmG8YyAPT/EyDjoZPg9jcTwXXPmuR QHUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688487427; x=1691079427; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0zoSLxvXdWi/Yl+BEgvp6RDAlMoTsWmGbOp6gCR7ij0=; b=cHU8whVbUPqlhV1UhoATZdnpDB87/FCTurA1kkT3iQB+YDNlL/z+9jiaXvV5DS48Nc WOskBx9NsVbCkISkDXFxsUgsAqNy4IBH6GRm3WioMn+y/cX1G1flueezOT/Q3j9eq1qS pODSa518szVh7AlGdltemUYBXTCZGxGPcFjEAg0kkAFOcS+jON9T+/KeVfLtGfe7Rexb t2pgDPeYW5v01whzA7V3o5sEBmy0PSw8M1il/8wM7TMhD9Ah8Phl/pCzt7lV/pWSi83x jiKKsvN06YZWJjUertvPu9Eznjfz/Tp7EWE6e6DWm0KRbOgFafQT528VhefxknawKZt6 0jWQ== X-Gm-Message-State: ABy/qLbifp58RTKhqEI9Xrvlrp/DhWcRQL1UBNFaomXRy7m1PkCluTH+ k8N4vlxDr8eYkQoFeaZU/e/w7VPFWEcx0UFN4Edz3A== X-Received: by 2002:a17:906:86d1:b0:988:a0d6:c4fa with SMTP id j17-20020a17090686d100b00988a0d6c4famr10290333ejy.13.1688487427344; Tue, 04 Jul 2023 09:17:07 -0700 (PDT) MIME-Version: 1.0 References: <20230630144006.1513270-1-pan@semihalf.com> <20230630144006.1513270-4-pan@semihalf.com> <20230630-scrimmage-antelope-7d1f82d491fc@spud> In-Reply-To: From: =?UTF-8?Q?Pawe=C5=82_Anikiel?= Date: Tue, 4 Jul 2023 18:16:56 +0200 Message-ID: Subject: Re: [RFC PATCH 3/3] ARM: dts: Add Chameleon v3 video node To: Krzysztof Kozlowski Cc: Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dinguyen@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mchehab@kernel.org, upstream@semihalf.com, amstan@chromium.org, ribalda@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 3, 2023 at 2:33=E2=80=AFPM Krzysztof Kozlowski wrote: > > On 03/07/2023 13:44, Pawe=C5=82 Anikiel wrote: > >>> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleo= nv3.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > >>> index 422d00cd4c74..5e66363d4ab5 100644 > >>> --- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > >>> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10_chameleonv3.dts > >>> @@ -10,6 +10,60 @@ / { > >>> compatible =3D "google,chameleon-v3", "enclustra,mercury-aa1", > >>> "altr,socfpga-arria10", "altr,socfpga"; > >>> > >>> + soc { > >>> + video@c0060500 { > >>> + compatible =3D "google,chv3-video"; > >> > >> This compatible does not seem to be documented & I did not see a comme= nt > >> about the lack of a binding in the cover letter. What am I missing? > > > > Yes, the compatible is not documented for now (I'll do that in a later > > patchset), sorry for not mentioning that in the cover letter. > > You cannot add undocumented compatible. This cannot be fixed in "a later > patchset". I meant later revision, I'm certainly not expecting this one to land (I sent is as an RFC). Is it really necessary to document the compatible to get any form of feedback on the overall structure of the driver?