Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 17:57:15 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        neil.armstrong@linaro.org, jbrunet@baylibre.com,
        jirislaby@kernel.org, khilman@baylibre.com,
        martin.blumenstingl@googlemail.com, kelvin.zhang@amlogic.com,
        xianwei.zhao@amlogic.com, kernel@sberdevices.ru,
        rockosov@gmail.com, linux-amlogic@lists.infradead.org,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/5] tty: serial: meson: apply ttyS devname instead of
 ttyAML for new SoCs
Message-ID: <20230704-pogo-zeppelin-5fa281f5c9e6@spud>
References: <20230704135936.14697-1-ddrokosov@sberdevices.ru>
 <20230704135936.14697-4-ddrokosov@sberdevices.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cFEFPb639xHq5Qr+"
Content-Disposition: inline
In-Reply-To: <20230704135936.14697-4-ddrokosov@sberdevices.ru>
Precedence: bulk


--cFEFPb639xHq5Qr+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 04, 2023 at 04:59:34PM +0300, Dmitry Rokosov wrote:
> It is worth noting that the devname ttyS is a widely recognized tty name
> and is commonly used by many uart device drivers. Given the established
> usage and compatibility concerns, it may not be feasible to change the
> devname for older SoCs. However, for new definitions, it is acceptable
> and even recommended to use a new devname to help ensure clarity and
> avoid any potential conflicts on lower or upper software levels.

> In
> addition, modify the meson_uart_dt match data for g12a, a1, and s4 to
> their appropriate values to ensure proper devname values and
> functionality.

IMO, this is a separate change that should be in another patch, had to
go looking through a several of unrelated $subject patches to understand
how the binding patch was going to work.

Cheers,
Conor.

> For more information please refer to IRC discussion at [1].
>=20
> Links:
>     [1]: https://libera.irclog.whitequark.org/linux-amlogic/2023-07-03
>=20
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
>  drivers/tty/serial/meson_uart.c | 33 +++++++++++++++++++++++++++++++--
>  1 file changed, 31 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_u=
art.c
> index 87c0eb5f2dba..361f9326b527 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -82,6 +82,7 @@ static struct uart_driver meson_uart_driver;
>  static struct uart_port *meson_ports[AML_UART_PORT_NUM];
> =20
>  struct meson_uart_data {
> +	const char *dev_name;
>  	bool has_xtal_div2;
>  };
> =20
> @@ -683,6 +684,7 @@ static int meson_uart_probe_clocks(struct platform_de=
vice *pdev,
> =20
>  static int meson_uart_probe(struct platform_device *pdev)
>  {
> +	const struct meson_uart_data *priv_data;
>  	struct resource *res_mem;
>  	struct uart_port *port;
>  	u32 fifosize =3D 64; /* Default is 64, 128 for EE UART_0 */
> @@ -729,6 +731,18 @@ static int meson_uart_probe(struct platform_device *=
pdev)
>  	if (ret)
>  		return ret;
> =20
> +	priv_data =3D device_get_match_data(&pdev->dev);
> +
> +	if (priv_data) {
> +		struct console *cons =3D meson_uart_driver.cons;
> +
> +		meson_uart_driver.dev_name =3D priv_data->dev_name;
> +
> +		if (cons)
> +			strscpy(cons->name, priv_data->dev_name,
> +				sizeof(cons->name));
> +	}
> +
>  	if (!meson_uart_driver.state) {
>  		ret =3D uart_register_driver(&meson_uart_driver);
>  		if (ret)
> @@ -748,7 +762,7 @@ static int meson_uart_probe(struct platform_device *p=
dev)
>  	port->x_char =3D 0;
>  	port->ops =3D &meson_uart_ops;
>  	port->fifosize =3D fifosize;
> -	port->private_data =3D (void *)device_get_match_data(&pdev->dev);
> +	port->private_data =3D (void *)priv_data;
> =20
>  	meson_ports[pdev->id] =3D port;
>  	platform_set_drvdata(pdev, port);
> @@ -780,6 +794,17 @@ static int meson_uart_remove(struct platform_device =
*pdev)
>  }
> =20
>  static struct meson_uart_data meson_g12a_uart_data =3D {
> +	.dev_name =3D "ttyAML",
> +	.has_xtal_div2 =3D true,
> +};
> +
> +static struct meson_uart_data meson_a1_uart_data =3D {
> +	.dev_name =3D "ttyS",
> +	.has_xtal_div2 =3D false,
> +};
> +
> +static struct meson_uart_data meson_s4_uart_data =3D {
> +	.dev_name =3D "ttyS",
>  	.has_xtal_div2 =3D true,
>  };
> =20
> @@ -794,7 +819,11 @@ static const struct of_device_id meson_uart_dt_match=
[] =3D {
>  	},
>  	{
>  		.compatible =3D "amlogic,meson-s4-uart",
> -		.data =3D (void *)&meson_g12a_uart_data,
> +		.data =3D (void *)&meson_s4_uart_data,
> +	},
> +	{
> +		.compatible =3D "amlogic,meson-a1-uart",
> +		.data =3D (void *)&meson_a1_uart_data,
>  	},
>  	{ /* sentinel */ },
>  };
> --=20
> 2.36.0
>=20

--cFEFPb639xHq5Qr+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZKRPawAKCRB4tDGHoIJi
0mZzAP47gQmIoHiEKtf6/SExpFCyadxEql+D7dStRjofvLIEgAD9F25QTpMwc7zH
/3Dk88CYjPnAzUZCHEyVxiL5r2QW9Ak=
=wvA0
-----END PGP SIGNATURE-----

--cFEFPb639xHq5Qr+--