Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 18:02:58 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        neil.armstrong@linaro.org, jbrunet@baylibre.com,
        jirislaby@kernel.org, khilman@baylibre.com,
        martin.blumenstingl@googlemail.com, kelvin.zhang@amlogic.com,
        xianwei.zhao@amlogic.com, kernel@sberdevices.ru,
        rockosov@gmail.com, linux-amlogic@lists.infradead.org,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible
 string
Message-ID: <20230704-cannabis-cannon-19397cd806bc@spud>
References: <20230704135936.14697-1-ddrokosov@sberdevices.ru>
 <20230704135936.14697-6-ddrokosov@sberdevices.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="EumZIp4agBc2nn9+"
Content-Disposition: inline
In-Reply-To: <20230704135936.14697-6-ddrokosov@sberdevices.ru>
Precedence: bulk


--EumZIp4agBc2nn9+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 04, 2023 at 04:59:36PM +0300, Dmitry Rokosov wrote:
> In the current implementation, the meson-a1 configuration incorporates a
> unique compatibility tag "amlogic,meson-a1-uart' within the meson-uart
> driver due to its usage of the new console device name "ttyS".
> Consequently, the previous compatibility tag designated for the
> 'amlogic,meson-gx-uart' configuration has become obsolete and is no
> longer relevant to the current setup.

I don't really see why you would remove the gx-uart to be honest, and
not use it as a fallback. Neil's platform though, so his call :)

>=20
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
>  arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/=
dts/amlogic/meson-a1.dtsi
> index c5567031ba12..6273b9c862b3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -344,7 +344,7 @@ mux {
>  			};
> =20
>  			uart_AO: serial@1c00 {
> -				compatible =3D "amlogic,meson-gx-uart",
> +				compatible =3D "amlogic,meson-a1-uart",
>  					     "amlogic,meson-ao-uart";
>  				reg =3D <0x0 0x1c00 0x0 0x18>;
>  				interrupts =3D <GIC_SPI 25 IRQ_TYPE_EDGE_RISING>;
> @@ -354,7 +354,7 @@ uart_AO: serial@1c00 {
>  			};
> =20
>  			uart_AO_B: serial@2000 {
> -				compatible =3D "amlogic,meson-gx-uart",
> +				compatible =3D "amlogic,meson-a1-uart",
>  					     "amlogic,meson-ao-uart";
>  				reg =3D <0x0 0x2000 0x0 0x18>;
>  				interrupts =3D <GIC_SPI 26 IRQ_TYPE_EDGE_RISING>;
> --=20
> 2.36.0
>=20

--EumZIp4agBc2nn9+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZKRQwQAKCRB4tDGHoIJi
0ni8AP9/Huiz85MEd1lWfxM1nHhevdkGu63rvkUGrwObPKXQFQEA+lioxbMrhHvJ
V5pJjDNClLTeb0b2t8nCYmO1W1jkzgA=
=H4B/
-----END PGP SIGNATURE-----

--EumZIp4agBc2nn9+--