Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp28024910rwd; Tue, 4 Jul 2023 11:29:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlFGyDiZTDhzwAFVabe0RCdJfTCSGPF4jYCZPgF9Yr47R0sjNxsz53pboxYAynaFvaYkWKcl X-Received: by 2002:a17:902:d2cd:b0:1b8:4ee8:8f24 with SMTP id n13-20020a170902d2cd00b001b84ee88f24mr17364434plc.20.1688495379893; Tue, 04 Jul 2023 11:29:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688495379; cv=none; d=google.com; s=arc-20160816; b=VJsz2c1JA9/lG17W6M/gYbwqGjKOnpbkTpVynn56exsUlIDgwH6p5oQK065nBZunhj YVe9ID5d5M/ytPNoN25XSH9mQEya/kSdQlJo0lEiVpIlIef9kn5aglMFIFaBqpjkWs0m XRxx8kSOwjcintyN+euZ7xKI35JGZBMF18AbHwGy+qPvGnA0M1sLz69qo+WqJ+Hjpwpm zKvAsr+S0fsuisml9ghHhp1/K0owKlmooMC5QPIqSFLi2B7R3jwPXKTmeWcrPUVFIVZr hKDzcJj6InN5ekOxHJFxvyEtDrql6kSBmbU8XjA8RgiZrYgKcfYyi26cvC7EtqKBm3eg nZZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/QQ+Y+14Y8wHCcIurGp5zUfHCaeH/cPOa7LyRJZnARI=; fh=EL3x0iXOqwEL+q6Go5RnjgvCn51MaZuMpL+01MWgYDY=; b=iudN/hpECwMP7W2RLRLeMdeZiFQbbMvNUieKwla2Wz7mIMmkXbe6XZngfOrTan+2mX qwE5SZpAHglsfVFRAtqVgxE0cu59bJqzqMPfZQSZB3b1180hn9eBw3WN7tijWkY06pRz 1YgjeEV31IjOYBvjjzaKMq7SwKbtoTN4e3/tG9IcwXLQw2+AqoyrecdP3IyrI04OBlpz DH3EuOH2onjqOcKybpKuJOGq1psA/ndOCevDdSvMrrskKFdJxupcUQbnRMKRI/lt/2d0 xCjuXEB3X4+INyUU8OLurvsT4sh7H+XPTQIvdmJn0V6OQnkBm+EddzEJL883ugRjJWuJ /ZRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Uag6pglI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a170902dad000b001b8a56b9895si2091693plx.616.2023.07.04.11.29.27; Tue, 04 Jul 2023 11:29:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Uag6pglI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231379AbjGDSIT (ORCPT + 99 others); Tue, 4 Jul 2023 14:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjGDSIS (ORCPT ); Tue, 4 Jul 2023 14:08:18 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 549FD10C9; Tue, 4 Jul 2023 11:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/QQ+Y+14Y8wHCcIurGp5zUfHCaeH/cPOa7LyRJZnARI=; b=Uag6pglI2bOJeECLpGyALXzsbc Q0NaPAwHEDf7FUlP/Y++2CoZe9Cm2yM/WfzM38xyNpjxlNRthoaH+6Ace2usGLeqec1FC8j1iUoqi PKmLd3TiNy+i1Bvc/HhE0Dp3EKo6qISsd/heyWV/5mxMOBjFI+C9vlrpIsYCXOvVM8PNh5tNNehfn KxlKgqlat8ndp/Gw1F5SFOXdNoNt/0Izp1KAGsAAhqwjPt4Nf+0iDLq6mK0LzxfNvrCpBIABWINPV PcMg6bT9xJKvE3QNWYHvYjetkckTquJiSqb+wQH3JUVWLFSFaK0RXOeFB/rqP8IwfAygJdhyn5r0c L/MfWmQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGkRf-009MKK-M8; Tue, 04 Jul 2023 18:08:11 +0000 Date: Tue, 4 Jul 2023 19:08:11 +0100 From: Matthew Wilcox To: David Howells Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 00/12] Convert write_cache_pages() to an iterator Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <3130123.1687863182@warthog.procyon.org.uk> <3697885.1687982590@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3697885.1687982590@warthog.procyon.org.uk> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2023 at 09:03:10PM +0100, David Howells wrote: > Matthew Wilcox wrote: > > > I'm looking at afs writeback now. > > :-) > > > fs/iomap/buffered-io.c | 14 +- > > include/linux/pagevec.h | 18 +++ > > include/linux/writeback.h | 22 ++- > > mm/page-writeback.c | 310 +++++++++++++++++++++----------------- > > 4 files changed, 216 insertions(+), 148 deletions(-) > > Documentation/mm/writeback.rst too please. $ ls Documentation/mm/w* ls: cannot access 'Documentation/mm/w*': No such file or directory $ git grep writeback Documentation/mm Documentation/mm/multigen_lru.rst:do not require TLB flushes; clean pages do not require writeback. Documentation/mm/page_migration.rst:2. Ensure that writeback is complete. Documentation/mm/page_migration.rst:15. Queued up writeback on the new page is triggered. Documentation/mm/physical_memory.rst:``nr_writeback_throttled`` Documentation/mm/physical_memory.rst: Number of pages written while reclaim is throttled waiting for writeback. Or are you suggesting I write a new piece of kernel documentation? If so, I respectfully decline. I've updated the kernel-doc included in Documentation/core-api/mm-api.rst and I think that's all I can reasonably be asked to do.