Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4650691f-a025-0a93-33ec-a99ff0ede157@oracle.com>
Date:   Tue, 4 Jul 2023 20:28:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] module: always complete idempotent loads
Content-Language: en-US
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Luis Chamberlain <mcgrof@kernel.org>,
        George Kennedy <george.kennedy@oracle.com>,
        linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
        syzbot+9c2bdc9d24e4a7abe741@syzkaller.appspotmail.com,
        Johan Hovold <johan@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Rudi Heitbaum <rudi@heitbaum.com>,
        David Hildenbrand <david@redhat.com>
References: <20230704092309.22669-1-vegard.nossum@oracle.com>
 <20230704100852.23452-1-vegard.nossum@oracle.com>
 <CAHk-=wgy2q9viwq-bAqaq8X_WQHNqDsu1AzfeYXAcDQRZmCoAw@mail.gmail.com>
From:   Vegard Nossum <vegard.nossum@oracle.com>
In-Reply-To: <CAHk-=wgy2q9viwq-bAqaq8X_WQHNqDsu1AzfeYXAcDQRZmCoAw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWRRbUZjZGZFbG0wa1ZQYmZoNURYbVo5YXVsSlF3MmJuZUhrNnlXQTNDNE1B?=
 =?utf-8?B?bGxIa3dZWXJDT1MwQXJNMHVUcXVZdW9YTGt5eTNTRVNXQWVuc2ttdy9VYlJl?=
 =?utf-8?B?RFF2YXpKeFNKWE9USFFhZ2lwTW82K3NNbncyZHpneEJjb0lXcElISDFnVys5?=
 =?utf-8?B?eE0wMmVHYytYS1BNSi8yVExyYzBIOFdrUlU0SFRhRCtpSnQvNHZleVljaTl1?=
 =?utf-8?B?bTZQeTIwc0U0ZWl3Ky93RWpqZUEyRHdjUjdsSGZXUFZDR0pBNENJL2szRTNz?=
 =?utf-8?B?bWl6czU3am9ZbjdwTXpxSFBKK1JBbVRMbzhFZW5vWng5eTJ2SU11emhmbXRl?=
 =?utf-8?B?T1VmeG1ndTd4dnFoeTRNVkQzT3NZcWo2aU1OVGhBT2JsYUpjRU1pdjV1T0dS?=
 =?utf-8?B?OHpFVlNHbkFuT24yanBOd3ozSjVNVC8wdURZR3ROMzE3eTY3YXBqd0tnQkJO?=
 =?utf-8?B?c1htUWdab1lwbG9DSG1kWnVRbklFL0M1Y1NoVzB1L1pydjVDMUxYSzBCQWhK?=
 =?utf-8?B?eGt1NDNZQ2RoTDRkT0RacjQ3ZkdVTk51Y3BSTFVWSDRDb25FSkZFUis3VENw?=
 =?utf-8?B?WUpwelFUT0VYWGZIQXV1VXZNZ0RBWFZ1VVkzUWRRMTI2UE1sdnQ1M3h0dDc4?=
 =?utf-8?B?T3p5UHMzR3RKNlZHVnJmdStZVVRYZ1ZiUllHWXhsVHVmUENCODdBemZrWVk4?=
 =?utf-8?B?ZEJHRjhyeXdzR2R4OUh5TmxMNWJmR05iaEZTcmtjZWZVNTIreEw1RDNVTDBk?=
 =?utf-8?B?K1RpMjlIaUxwOVFORW1ORlhmMFVSYXRqVGdzL2JiSUNSZEpSeThHNGRiV0ps?=
 =?utf-8?B?MmF0alIyUW5qNjh1dDhNWmNmdVhlZ21sVXZVOXZvZFJ6WmtZbTVnVUdQTjd0?=
 =?utf-8?B?aEo0aTB4TDhMNDlDMnhtQ0ZtUE1zR2xQN01OR1ExNzZsYWFYTUlyaTJGa1F2?=
 =?utf-8?B?NUVqMDFCTmJTZTZ0M0VrLzdTeDJDQjE5eHVES1B6citCQy9QTVM1d0xIdkpU?=
 =?utf-8?B?WVRoZkNhaTk1c3JhRElGY3VvclFKc0liYy9MNDc5cVR2bGNoSjN4QVlYQkdM?=
 =?utf-8?B?Qlg3THlsL3hDTDJVMWw2UHJuZEczNXZPdnpmOXRrVWlmcXVaMmlFQk1MWnkr?=
 =?utf-8?B?QnBUalBlaHI2NTRmOXJVR0VNR3hFUldEWi9NVkNxMnh2NUxJakdSOEMvUWVs?=
 =?utf-8?B?VmhrMkh4ZnBvdkhaWFNKOGsyQ3dQQzZDTlBWWmE5Z2d1UTd6NHI3WE14VlVJ?=
 =?utf-8?B?dTlCRnZybDNyMnhlcytyQW5CR2xJamJ0SWxzRU1sWlFwTWszZEVoM3ZNTzk3?=
 =?utf-8?B?d3prN0hyUkNkVVZWQmVscGtxWXlCSDVEMzU2ZERNNkdJajQ4cUcwejhTMWQv?=
 =?utf-8?B?clRSWHZIeXB1NWVhZkhlNllERnhGVFc4YWF6VDZhK3JMR2p3aGZ3L25ZQTA4?=
 =?utf-8?B?SkhqaHRqeG0wU3lzYXhMcjAzOEtLbk5VTm9aL0tlcEN3d2xUNGk5WlBZUmZE?=
 =?utf-8?B?aDZpV2o2ZnBITktqRkhsMm1uRkdCVEZzckVJYXBFMzMyZm5zMTZ2N1FZWlNI?=
 =?utf-8?B?cWNZNDRzczhzUjl3Ti9MaTJBY2ExTFV5T09XTmtEQ2ViQmovVlNVZ2NvVHNF?=
 =?utf-8?B?L1NxYlk1RVFvMFBQTVJCc0VXSHBodDBGNTNJTnhVWVhQN3lXbFhJWVBYODVQ?=
 =?utf-8?B?eW8xajlpcUR4WTMvYURRU0JLSkNQMnJ4MWxaYzZLejdNcUErbHhqRTBMT3VJ?=
 =?utf-8?B?VlFFUGNqZFJzdzFvZXQyNldTeURRRGROR2VEN05Pek9JdlVuaFY1aHYvcnl4?=
 =?utf-8?B?V0h5cTdyTFBnMWdyU3FpcUh6SThxVlNGQmliaW8xTURYdlVQVXJwQlBFM0xQ?=
 =?utf-8?B?QTBqVEx1ZzJjZytUOUd1aUViRVNDaDhVaXpiN0ZCWFNHUFBQY3FVUUY5cXIx?=
 =?utf-8?B?d2w5Z1NQSnd1VzQxYTZhbTUvK2ZnRDd0ay8wdFBXMjZ1Vm9NU2ZSMjdpbk0r?=
 =?utf-8?B?bG5xVzY3SkI2TE0zQ1kvaWRBVjJpMU5YczNvbUxJZVVNNWtxWHRPMGhoZVNU?=
 =?utf-8?B?aEJNc1hpNjJ5ZjIxRE91aEcwVUNZemNKQU93bXg1b1phdGRjVmZldjdxQ2hY?=
 =?utf-8?Q?T6wT6EwP9AvyNdz7m9arVtplo?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OW1YNFpxYmsvRC9ZUFZ5NGZ4RTg5SEVnc1BwYkl2UFYwdVFrdGVmUnVWMTVX?=
 =?utf-8?B?ZmIvOFh0Y3RJSzVwdGhRM3RqOGFEYU9QRmhIdGRmbWkrekJ0ZnAwSlQrKzNJ?=
 =?utf-8?B?aDgyZVBkczVPTjJsRDNvbWtYenFEZmZUK2FFbExqTkU2djBpanUxcjFLTjk0?=
 =?utf-8?B?SkdsMlRCSWdyNWJ3TlVhVEt1ZG5kSTNLaXY5cVg0WHg3ZDZDVjh3cGFFY1Nh?=
 =?utf-8?B?aUk2U0xicUl3VmhOODFjVlZ6bThLWmJEdFJNSmFXL1A0ZXNaYXcxTUVyQXZU?=
 =?utf-8?B?Y3diQkQxVk10czlzLzV5VzdDYmxHUUNMZUhBdHdiWlVUUzJpN0owaTBpcWsr?=
 =?utf-8?B?ZkhmUEcwTmJCbGhQaVlZNWc4WUNpWDg3SFJIVHUwNnprSlpHTHdtNDFGWmZv?=
 =?utf-8?B?R1JvQ1R5TnZ5b1doNU12eDBaWWRncXZ3Q3VzaUZoOHE1TjlyeUh1NmdGWE8x?=
 =?utf-8?B?ZmhyYWRSTUNsRTNsQUlPVjRXTlVjc2ppTW9kVDJIWFQzOVBxL3hXRHpvZkgw?=
 =?utf-8?B?RnZ5d01USndkcUg3NEhDWkdXVXc2ZTVpTnFvQmhEM2krLzRBaHVMZlVQOGxj?=
 =?utf-8?B?bVk2SUJTZmNDWnJKQlowZXZKcHI2dW54Sy92QmxhVldUajU0NFZYcyt1aWgx?=
 =?utf-8?B?Y0RLSlA4V1lBcTIwRG10aDBDaElNei81b2VZWUdDc0srdS9TZXhaRWtMSlkv?=
 =?utf-8?B?eGhEQ2dnR2NXRE1pMEVPcmU4NnVreWpFS3I2T0VCTml3ZTJ6VHdQNDFpMEk3?=
 =?utf-8?B?MmtqUTB1OU1yRmh5cHZDZVRvV2JpYXp0cEhVdWp6SkJaMjdESXZDODJnOGVL?=
 =?utf-8?B?ZFB1dEthVWV4L3ZEZVZoSUxZWnNZZGhUeEpKMFQzWkViaVVscXFScHdXcG1F?=
 =?utf-8?B?RkF2WGM4eDJQQzhYT3hvZzhydkt0QW5jY2dZWklDQVZPTEtCVlhZQzJnZi9a?=
 =?utf-8?B?MnRDZGpZcFNIU25oQUZQV1kxbUt6WGZPMHJOS2syb0FPMkMyd1Z2S0VSK2Ft?=
 =?utf-8?B?U2gxQnFYdW02L2VDaFB3eDBKUmFUZForNElPbnFSeUt0YnhLUnBuU1NSMndB?=
 =?utf-8?B?ZjRIOXptNFVLamZMN2RVbjhEdGhKYzIrQzhZMGRCZDVUaUMveDNvSkxXWWx6?=
 =?utf-8?B?N3c4YmhBZnAxcW41L3NsV1dGdzlMeWZrTVJ2U0dXakNmNWZWeVNZU1YrVTBG?=
 =?utf-8?B?V2RjdEplWjNUS1NDTnNjb0dzRzFudnlmalVOT0VGcnNOSFN1UXpGRURkYjVY?=
 =?utf-8?B?dkpQY1FiMjV5ZmlZV1FJQzJWbkpYMHlWTkVicVBwbmdzQm1BTUZwTXFlZzNp?=
 =?utf-8?Q?Tm/D3HEnKTknQfFSwGQhODH+Z1zTwnsk9j?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 016e34c8-23a8-4084-7d2d-08db7cbc826a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 18:28:49.4862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7f8OO3bMASC0FuOwIFeYuXgd2e130U0hbzzmNOUZeU2U3pP2wAloBte/c954QwCYGtE/lFrpZTpEzQUBS9NCIVUcygpKPfoy0DBAx7/EM2Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6769
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-04_12,2023-07-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307040160
X-Proofpoint-ORIG-GUID: kSoWf7srYuo8Wcig_c_VtAS0EXD_HU9s
X-Proofpoint-GUID: kSoWf7srYuo8Wcig_c_VtAS0EXD_HU9s
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/4/23 15:37, Linus Torvalds wrote:
> On Tue, 4 Jul 2023 at 03:09, Vegard Nossum <vegard.nossum@oracle.com> wrote:
>>
>> Commit 9b9879fc0327 added a hashtable storing lists of concurrent module
>> loads. However, it didn't fix up all the error paths in
>> init_module_from_file(); this would lead to leaving the function while an
>> on-stack 'struct idempotent' element is still in the hash table, which
>> leads to all sorts of badness as spotted by syzkaller:
> 
> You are of course 100% right.
> 
> However, I'd rather just use a wrapper function and make this thing
> much clearer. Like I should have done originally.
> 
> So I'd be inclined towards a patch like the attached instead. Works for you?

Harshit tells me there's still a crash... and indeed, with your wrapped
version we call file_inode() on a NULL pointer before checking the
fdget() return value.

It's likely you already changed this with the f_mode changes I commented
on, so maybe it's no longer a problem, though.


Vegard