Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Jul 2023 14:47:52 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Oliver Sang <oliver.sang@intel.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH] mm/mmap: Clean up validate_mm() calls
Message-ID: <20230704184752.6lwrytfirr4huu34@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Linus Torvalds <torvalds@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Oliver Sang <oliver.sang@intel.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=wjUp5+tcsHG89ieuwa0wUtSWWBWRt8xOsoZ1nskZbbk-g@mail.gmail.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BmQlJsf6egNLuXB/Mj1ar03fKzoXonqU9Qeu9ZeQEQ519uFPnaNB7RQnJn7x?=
 =?us-ascii?Q?dSxH826IGOmg2ljfdXbGfieFYVDTPJcCUK+3q0tve03ibdrH0QjibNxbI4yZ?=
 =?us-ascii?Q?MaR4IiiA+0VDUjjG286LavQmSnlp6FKPCVrevtAitMOXW1Rjr46ioyB/Kobg?=
 =?us-ascii?Q?FzdTHe9055cQsmSq6jKQJjXARdDndTgBo7T1FXeYxOEZliXEpf9qnRdjtTq9?=
 =?us-ascii?Q?ATfnXq4THLVhtFti7deul0rCEdHtqAZespqWtw0+Z/xIExXxhl+d/yoXCpPJ?=
 =?us-ascii?Q?uMZwLpl5ppzhZIWPtAc408U3hjJLf2HrWuxTey541YQRQIYd1SuP9FaiAZti?=
 =?us-ascii?Q?YtfLzxiR8O4eJ3NV+dxnHbq3JmLKreB/vHT69rLgf9ovkjkALTT0tz6JTnOr?=
 =?us-ascii?Q?3aGcKtb8TOwajSdZTMTHNvjrBAHixqe8g0xinjmOz47p5gUS8cBKg8+aUeZ+?=
 =?us-ascii?Q?w96HDp4XI0mSWCD8J1BEiVNySDDu/dB6tO+JZBep0gsADqSQ7BIbmVdHeo/b?=
 =?us-ascii?Q?6Q2guSrXjMYl4I1Jg/65ZRfxBIsiICLjVskzAgTQ481bgMrypk9PVbFRBeCl?=
 =?us-ascii?Q?6W/zQ2pbzW9iCiXifOqYHB3Y8/jjx4wH9GSA8Q25XiCqxkz9QXWGlpvC8PcM?=
 =?us-ascii?Q?jttTLI/NpSlmWzJgRCq/ESiww5BN+W+cy+5PLgF2tRv7Y8JoLxF60tWVqMjk?=
 =?us-ascii?Q?CN6G2P2CIPkp2FtWAPggUumrYT0rqkgFUAoZlMqlZJaWDVDVIPR5mh8r3Rae?=
 =?us-ascii?Q?TmaiBngavOWGCrU4vKwyNFFAp9jGkXZ9YY1RHI+0tOXrpdm+mslfUUoIGIao?=
 =?us-ascii?Q?wE0/foqeya1v2jqj2aZpXhqQDORBwBVtbYyG0cmAhnhU+Quza5v/wuPikULz?=
 =?us-ascii?Q?iHR15bg0bQml0aJsjJRy3h/opLDrGpa+OOeiUtsv0TcgJAnd5VC5RXItdRuC?=
 =?us-ascii?Q?QjPlijTlsHX908WgpM8CPXimlzXOIOUbEdhX59LBbDACByvzi9TGqdE9xEoh?=
 =?us-ascii?Q?DyFpu/fNEF1npUukJNIeTLEOrYsWCr+gDaqGRrHe4QYLRhZ4fSyh3pVSR1zm?=
 =?us-ascii?Q?78C/TVIbknrD1YbS/SSZG722Ej5cJFIpPDC9tR+OygruNZRDBaPMST59lGjL?=
 =?us-ascii?Q?mSIxY9GPd6sXdw8+GZOQkkCRl1H6IURoRM7NtWX8Vbsa0tymVQYpEN92Oj5l?=
 =?us-ascii?Q?SIW6ui07y3dKCAUUgTdUEOSdd0z0mI3TZQMrTvGkod9aavDtcDIrlMDxcW5K?=
 =?us-ascii?Q?hHA6PiBQ37zpob4OSwJed7ruMamOK+b5/UciYMS+07dfYd3Goc+nzgeVUzCo?=
 =?us-ascii?Q?cqaUJofLE9NNMRVqXuN5CGNjAAejxZatlutTTOgIlAT8YhCNONgvxEwbTZ8l?=
 =?us-ascii?Q?HhXAT23tmHnTrpRwCQUalLNF1kKZul7oaU0utDsG3oYFZqf1avvwtZUd84ql?=
 =?us-ascii?Q?0iLkJPAX5sGF5nVKw1lCwbDuwkv64HTGOT9EClgewVpBiKrYgsOsUftu9qJl?=
 =?us-ascii?Q?y7cQKm9TgZ+jPaFARoR2vkmn4MxqptzV/9IrJweYJD5ObO0FI2hsUQ9ug5hL?=
 =?us-ascii?Q?cWCv9ufF/eiYBywG+tGAY1F/Zbs3eX5KSR7kZaerOIL5+TdUh3VCh2rot4rG?=
 =?us-ascii?Q?0Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ykZb5/tYG2qYie6zOzv8bEdNwo6z11YVpmFEKrE7xZT84o9rBvo1e1fHODpEtFJ06exVcA6i8THkW36u7hgooXYqWb1wX60hDDqZUpmKdYSpVTasjXcZ7zK0aNZ4OUj8Rmho5aP4Z70Ua0Yaval+xioUJSdsRPTF3K3g1DOKKc71IxrbMpBqNYqX/nV5CL8XTmHLMiQ0mG5TU44eEM1L9N/C0s+8Niur6V/9Gf0FVEo7XpLKJFJ4pJrA+7NrFRdxy63WWUMv5zYaZUCHBgKQ+30rrqFILJmD6XJq9MkoG7bCEpJ03Ic6ksjSK6WRuYU1PpHHM8ltqxYvRgz0QFtFJUeUud7CzjIgwda8OPBmgPwL0XunaAdnes6jFr7BhrEuA8CRzTobtC+lHNRxzaMSIx39q7S9K62atN1pcT3nesgvI94uj7N1bhqRRXt5ppdgREMMjAXi7uJsiHV52tHIOAgHyixoMUx3YBiJit+QmMoUWOobjP5ue2XMve4N95Q5lUL5MOztTtYIpYYCOGcOxL6BIhz71RLvjshVKDVBdoC/YWUicjEk3LQX0jLIK7mhk3V4AoPPgefGAkkA21AJh6L6YTIzR/h3iQPqprHRn5AQMd0rP6Vd3Efz3EtfKDh97TjSMngr+y/fpfDl2nyM7vY1JwUjcU1iMO0Nx1hpJgd0cD3oGaky/uQsJoZkXCu6wqnJMQFb6IM5KmCSyydeNv5hm47Va0mqouajSkL/01Tds1gcV1bOJFy05LWjEm3XztHqMR6qh1RGW3t/nst2Nj/G11VKCYQaC38od/p8paWu/Ho/lsJG1zRCQTFwaNIAKUS0IkNVAltUQaUSxtkQo9+HcmFFwlQ1Bo17JzClZbwCGpCJ2nFubiW5/P8X2qLOjGUPJdpQ8kKXKWB7PcX/7w==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 420633ce-4bd1-45b8-a9a1-08db7cbf2d65
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 18:47:54.6065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1yBSJVcitWrkg5QM7v5TqbrsV2B1z2XS0CixzhC/0JrevKgD/rXnyXPNv/Uv85pzHXrutldJDWzZatxNYCxtcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4179
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-04_12,2023-07-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=650
 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2307040163
X-Proofpoint-ORIG-GUID: _0SUtdqwHmqUeqxAuR0rwzsoSrvl5pfg
X-Proofpoint-GUID: _0SUtdqwHmqUeqxAuR0rwzsoSrvl5pfg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Linus Torvalds <torvalds@linux-foundation.org> [230704 14:36]:
> On Tue, 4 Jul 2023 at 11:25, Liam R. Howlett <Liam.Howlett@oracle.com> wrote:
> >
> > validate_mm() calls are too spread out and duplicated in numerous
> > locations.  Also, now that the stack write is done under the write lock,
> > it is not necessary to validate the mm prior to write operations.
> 
> So while I applied the fixes directly since I was doing all the
> write-locking stuff (and asked for the locking cleanup), I'm hoping
> these kinds of cleanups will now go back to normal and go through
> Andrew.
> 
> I do have a question related to the write locking: now that we should
> always hold the mmap lock for writing when doing any modifications,
> can the "lock_is_held()" assertions be tightened?
> 
> Right now it's "any locking", but for actual modification it should
> probably be using
> 
>      lockdep_is_held_type(mt->ma_external_lock, 1)
> 
> but there's just one 'mt_lock_is_held()' function (presumably because
> the internal lock is always just a spinlock that doesn't have the
> reader/writer distinction).

Ah, yes.  I was trying to do just that, but ran into an issue and backed
out of fully fixing this portion up until later.

The issue arises with the use of the same external lock for the munmap()
case where I'm using the second tree to track the VMAs.  Using the
spinlock causes issues with the potential sleeping within allocations.

So, I'm still working out a way to do what you (and willy) asked here.

Thanks,
Liam