Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230704184109.991104-1-m.felsch@pengutronix.de> <20230704184109.991104-3-m.felsch@pengutronix.de>
In-Reply-To: <20230704184109.991104-3-m.felsch@pengutronix.de>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 4 Jul 2023 17:24:36 -0300
Message-ID: <CAOMZO5C21f9+ByLVHMaK9wHcCSF3R9W1c1ZCfirx7TuX=786Rw@mail.gmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: freescale: Add DEBIX SOM A and SOM A I/O
 Board support
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de,
        linux-imx@nxp.com, marex@denx.de, frieder.schrempf@kontron.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Marco,

On Tue, Jul 4, 2023 at 3:41=E2=80=AFPM Marco Felsch <m.felsch@pengutronix.d=
e> wrote:

> +&fec {
> +       pinctrl-names =3D "default";
> +       pinctrl-0 =3D <&pinctrl_fec>;
> +       phy-mode =3D "rgmii-id";
> +       phy-handle =3D <&ethphy1>;
> +       fsl,magic-packet;
> +       phy-reset-gpios =3D <&gpio4 19 GPIO_ACTIVE_LOW>;
> +       phy-reset-duration =3D <10>;
> +       phy-reset-post-delay =3D <150>;

These properties are deprecated. Please move them under the mdio node.

> +               /*
> +                * Since USB1 is binded to peripheral mode we need to ens=
ure

s/binded/bound

> +/* =C2=B5SD Card */
> +&usdhc2 {
> +       pinctrl-names =3D "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 =3D <&pinctrl_usdhc2>;
> +       pinctrl-1 =3D <&pinctrl_usdhc2_100mhz>;
> +       pinctrl-2 =3D <&pinctrl_usdhc2_200mhz>;
> +       vmmc-supply =3D <&reg_usdhc2_vmmc>;
> +       bus-width =3D <4>;
> +       disable-wp;
> +       no-sdio;
> +       no-mmc;
> +

No need for this blank line.

> +       assigned-clocks =3D <&clk IMX8MP_CLK_USDHC2>;
> +       assigned-clock-rates =3D <400000000>;
> +

Ditto.

> +
> +       pmic@25 {
> +               compatible =3D "nxp,pca9450c";
> +               reg =3D <0x25>;
> +               pinctrl-names =3D "default";
> +               pinctrl-0 =3D <&pinctrl_pmic>;
> +
> +               interrupt-parent =3D <&gpio1>;
> +               interrupts =3D <3 GPIO_ACTIVE_LOW>;
> +
> +               regulators {
> +                       buck1: BUCK1 {
> +                               regulator-name =3D "BUCK1";
> +                               regulator-min-microvolt =3D <600000>;
> +                               regulator-max-microvolt =3D <2187500>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                               regulator-ramp-delay =3D <3125>;
> +                       };
> +
> +                       buck2: BUCK2 {
> +                               regulator-name =3D "BUCK2";
> +                               regulator-min-microvolt =3D <600000>;
> +                               regulator-max-microvolt =3D <2187500>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                               regulator-ramp-delay =3D <3125>;
> +                               nxp,dvs-run-voltage =3D <950000>;
> +                               nxp,dvs-standby-voltage =3D <850000>;
> +                       };
> +
> +                       buck4: BUCK4{

Missing space after BUCK4.

> +                               regulator-name =3D "BUCK4";
> +                               regulator-min-microvolt =3D <600000>;
> +                               regulator-max-microvolt =3D <3400000>;
> +                               regulator-boot-on;
> +                               regulator-always-on;
> +                       };
> +
> +                       buck5: BUCK5{

Ditto.

> +&usdhc3 {
> +       pinctrl-names =3D "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 =3D <&pinctrl_usdhc3>;
> +       pinctrl-1 =3D <&pinctrl_usdhc3_100mhz>;
> +       pinctrl-2 =3D <&pinctrl_usdhc3_200mhz>;
> +       bus-width =3D <8>;
> +       non-removable;
> +

No need for this blank line.


> +       assigned-clocks =3D <&clk IMX8MP_CLK_USDHC3>;
> +       assigned-clock-rates =3D <400000000>;
> +

Ditto.