Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp28258383rwd; Tue, 4 Jul 2023 16:16:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlHHMzSyN4OGZ/NuU7ma08Shu8RUEXB0QP0XZWcaDOLz/h5tvD7u4e/XqTLQXl+a/JQR8vyb X-Received: by 2002:a17:902:b288:b0:1b0:f8:9b2d with SMTP id u8-20020a170902b28800b001b000f89b2dmr16069623plr.29.1688512587977; Tue, 04 Jul 2023 16:16:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688512587; cv=none; d=google.com; s=arc-20160816; b=IfcFQxvDtWBCHqLGt1SJ8swM6BNiRPImFjNsaJt7WYn+FARluv2YVTgq7CFFbjK7TU Y3x+YRdXg4xyG9347zTyY5kRbt85zweXXYEf6ss5i9mh4YtDTY6ZLuhoAlAAC2xdOTvH 8NjEHE5sOUix68w58IPUm4Gndo71qrYdcw/bMZgjxMrdVbbHMM9+ZrnPqg/OMcRDOM11 Npl3MFDUqppOBoesm4pEnX98ubSgQentQw+a4QsF1tNKlTGROtMTnH1I+X4pErUWTp6f gDIFQE7n2BSxTZb7tFsHbyf3xgOV/FrJaEcZnM23cdw41iT/C53mboCl1ZW4rPVHhjzF aiJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=l+UWSNWnPBn9YwHrYZ0j4Lv7hwDX/3gV8Kn6aaki1HE=; fh=vltt/tDfm0GlH16apGmd2oXkHeIQ9sXy0ALXZOUJTxM=; b=0jYogrQnc74YSQuMM+fZI0FvHNoCFt+XNzhXB408ZWuCtdCL3cj/BT1pRpAhkDu0BS aMt7HIeyE7GiBRzKuP7afGuYhSoODOHXvhuFdZWbP9Txko8aHsNvrvYCL9XCjWNOKvem q2f3Ufwg3GXFvZU96MdK+i0kHdgzcpUS2ZBrS5+qM57qTNzvnx99dAaYvV9QhApPrh/q KKhIJ30MyPt8cmfzT8G0oKpQ9N/o1rloZ9mdsLecoyZK9tlvl9ebmIU+eMy5q+YvvGTo Xd0KYaiIw0OySmoWhLHn4nIr+qhUmS54GxUkC9GT5kg4ZlMKxF3rccq1D9jt+WUdjWqq koPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WMHxaLp1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a170902744500b001ac4f733007si20880407plt.549.2023.07.04.16.16.14; Tue, 04 Jul 2023 16:16:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WMHxaLp1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbjGDWZx (ORCPT + 99 others); Tue, 4 Jul 2023 18:25:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbjGDWZw (ORCPT ); Tue, 4 Jul 2023 18:25:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 137AAE7B; Tue, 4 Jul 2023 15:25:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9765F61389; Tue, 4 Jul 2023 22:25:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF750C433C7; Tue, 4 Jul 2023 22:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688509551; bh=l+UWSNWnPBn9YwHrYZ0j4Lv7hwDX/3gV8Kn6aaki1HE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WMHxaLp1Csrv16oO4rGOZ+vPwaP2Zr9ieNInLhYuaMs6zfv+FnF2gL2AMG2a8mdSD Bv0zi8vQl52i5JCuuLsSpfalG5lgyixtcUCVgNyfFqXZ/eq2BFPCgwjfk9VYciSpcb Uq18eBCZpSOVftI1qnf2kjg/z7czmLGJfeQnN2GeZL3hxvFxHBmRwfJAZJZTo8RryO J+XIpwMTA6uAhDxOMWgemhgEV0A+OndbJ871VpwP9ZF5V5wYPyk5Jkg0NC1SzJQC77 A4zg/PcJa/s6R1xNSSqLZLq8JD5V2Bh1Z7kGsQWwdP6S6dWAk8D3BntnTBp7Y6NAO+ Ais196WrPJiWg== Date: Tue, 4 Jul 2023 23:25:45 +0100 From: Conor Dooley To: Xingyu Wu Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , William Qiu , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [RESEND PATCH v6 5/7] clk: starfive: jh7110-sys: Add PLL clocks source from DTS Message-ID: <20230704-tribesman-grumbly-86db5a8c1905@spud> References: <20230704064610.292603-1-xingyu.wu@starfivetech.com> <20230704064610.292603-6-xingyu.wu@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dF3s5FbwRnrv/rJT" Content-Disposition: inline In-Reply-To: <20230704064610.292603-6-xingyu.wu@starfivetech.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dF3s5FbwRnrv/rJT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hey Xingyu, On Tue, Jul 04, 2023 at 02:46:08PM +0800, Xingyu Wu wrote: > Modify PLL clocks source to be got from DTS or > the fixed factor clocks. Again, would be good to mention here that the reason we are keeping the fixed-factor clocks is for backwards compatibility with the existing DT. Otherwise, this seems good to me, thanks. --dF3s5FbwRnrv/rJT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZKScaQAKCRB4tDGHoIJi 0hJkAPoCQb991q3ts0PJelvRVhrMb36/OMkra5qkdsjLVOB9IQD+JLRYIxcJoCqE 9oBLSnO1ugEnIbqZGcJ/S6UTfT48eAI= =Dpi7 -----END PGP SIGNATURE----- --dF3s5FbwRnrv/rJT--