Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Borislav Petkov <bp@alien8.de>
To:     linux-kbuild@vger.kernel.org
Cc:     LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] kbuild: Enable -Wenum-conversion by default
Date:   Wed,  5 Jul 2023 00:19:51 +0200
Message-ID: <20230704221951.7396-1-bp@alien8.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

From: "Borislav Petkov (AMD)" <bp@alien8.de>

This diagnostic checks whether there is a type mismatch when
converting enums (assign an enum of type A to an enum of type B, for
example) and it caught a legit issue recently. The reason it didn't show
is because that warning is enabled only with -Wextra with GCC. Clang,
however, enables it by default.

GCC folks were considering enabling it by default but it was too noisy
back then:

  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D78736

Now that due to clang all those warnings have been fixed, enable it with
GCC too.

allmodconfig tests done with: x86, arm{,64}, powerpc{,64}, riscv
crossbuilds.

Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index 7a5a175f708f..428132b3d6dd 100644
--- a/Makefile
+++ b/Makefile
@@ -1082,6 +1082,9 @@ KBUILD_CFLAGS   +=3D $(call cc-option,-Werror=3Dinc=
ompatible-pointer-types)
 # Require designated initializers for all marked structures
 KBUILD_CFLAGS   +=3D $(call cc-option,-Werror=3Ddesignated-init)
=20
+# Warn if there is an enum types mismatch
+KBUILD_CFLAGS	+=3D $(call cc-option,-Wenum-conversion)
+
 # change __FILE__ to the relative path from the srctree
 KBUILD_CPPFLAGS +=3D $(call cc-option,-fmacro-prefix-map=3D$(srctree)/=3D=
)
=20
--=20
2.41.0