Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaolei Wang <xiaolei.wang@windriver.com>
To:     hongxing.zhu@nxp.com, l.stach@pengutronix.de, kw@linux.com,
        bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com
Cc:     linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] PCI: imx6: Add deinit for imx pci
Date:   Wed,  5 Jul 2023 09:06:24 +0800
Message-Id: <20230705010624.3912934-1-xiaolei.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Bq7moxLEdjuLtD9uDxo9FQ+DZolhJYD1DTZhXcLxz4zvLycvmrkm+n3YFY+G?=
 =?us-ascii?Q?qOhDu8HualmIuSUduCL+GBiGMEgT8sgOeDNXEdufP6xmtItYz+GZROOrp24s?=
 =?us-ascii?Q?80rgSQ9wFq7oyepyiFLsPztjwU3Q6AaEcmCBvWaCxQ5B6bEDzB6aKCLiwrBQ?=
 =?us-ascii?Q?eV9g4+716wxy/dcGKRjrO3EioOVfxyOLXm/zPp5NeWDaOxUbIw+mGNeHWLKA?=
 =?us-ascii?Q?ix6taVlXIgnaVWzVbZXfIZ5/PE9LJCmXLZLmxGKcCVMAU76u8H8uD1L+3t+i?=
 =?us-ascii?Q?mrZ0wEn2Zjp9RAkzUfUNuuJxbnXfr0njld6Zs4DZfLT5F0PJzVULniOsB0gQ?=
 =?us-ascii?Q?Rl/vvwd3Qr8vv3DLUkAgNbVN+mH1m5Y+hoG0VpyRjlkwqtIctFBPUl5pEt7y?=
 =?us-ascii?Q?K1TLhMXJTpxIrFbcQCldxvDb7Csk1sFMnfN8qm71YT7rD0wpd69mN7nkr42k?=
 =?us-ascii?Q?QlsFdb/JPcWiB0ZeO5GfbImS44keElUPPmvWebfgYS9PT7+ttawyWDO6kSkO?=
 =?us-ascii?Q?Iv4sn3R+dRks11oUQm4FfZrreHv2PHAsfvlIvxgIrGcdDVE3VGH7kkepH4KK?=
 =?us-ascii?Q?BTlsBWcGjRNNVTieG/cqQcLY8MOAELwXIDMBJuR1SfiXM05ycTtLByzxRqa5?=
 =?us-ascii?Q?HhwpkX1Dikr7emvlaqaZo+ND2G11jaEQ8Rnq/PdPahYvA562MFdZbjyGhz+l?=
 =?us-ascii?Q?NdfnnvPdcOu3CYm2a9Vqc5yzE74Qi729Wyk7plUQG4RuePqzIUjmnCuoKACn?=
 =?us-ascii?Q?Saray9SDU4z1DLgzHXzslaIsOt/U7BRuC3ZSfOIiTew1pM0RuXCl3K/AEYkV?=
 =?us-ascii?Q?9dj2vtjLGjrqOPWAR4Z5PXl8HuVDRaka8a3bdhwzH4mKQD4/UIHoz5xpQep/?=
 =?us-ascii?Q?B4DHv/ZwZg7WFnbHdtyy2fXewWNG7twPDGdCeaGGRqd7H1PzFWPHSxBBn7Jg?=
 =?us-ascii?Q?L0bS+UvKrI7nTbTpV+hPPVnW06RyT9dGYlVWjmxquX1MasXPV10sL6OShB13?=
 =?us-ascii?Q?GbMJ99C8pqd9S1Xu27cFfHUief6eJZQrInLk24hZgRLzMyZ1pBy+p8SjPHtX?=
 =?us-ascii?Q?XJnYjJSDTcry9dxm0if/CzYcb2woD77p88UkHAtORMG23uSyaQw1BJX5oYIL?=
 =?us-ascii?Q?YHR3TesfgwLQhshTaYwD7ybr8OBNWH5hT1KoPlTTrt+pNsP9O9QAeRTgrUIC?=
 =?us-ascii?Q?ZzKbS/UCsAwyhQ+IgdlHui2LnRegsQSuwpPj87FZ3ZlwalUrGr3BEZbhqrey?=
 =?us-ascii?Q?Tr4KCLn40WocTfBom+VhnS3QDATsA8hWCqzkCx2Detq4EkDgiF6JmkB5d9wG?=
 =?us-ascii?Q?RiUPHtwQIFvXJuhYmPsohwbaeurkX0zfr/9bcc8Ofus5vg7b8mydQRZABLN4?=
 =?us-ascii?Q?0fV3ccD19AQbEVRWZeFm58jpqxmHa+dIt+vumqSl9XNQELQ441Vx0mGozOa7?=
 =?us-ascii?Q?GEIOrAYlu8T8BHjjx4rYSzLup3+OV3+cyfJl1n74p0Ip5bFIJh/VFgbXiam7?=
 =?us-ascii?Q?ilzKkiAIZp8THx5n9F38ntzB39/hPaXBNMUtvXXTaE9KSZBndBGvcoaxMFxF?=
 =?us-ascii?Q?dUvhvq2M/Ea5Bz5R2jccogPDWfAPaSCdLszBeXZaq3cBuM+mH5rW6uqruvrM?=
 =?us-ascii?Q?lw=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32577df6-9c4a-4b3c-119b-08db7cf41c47
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 01:06:49.4275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BRbl4outD5KlEh6EP68TOHKPn7ypJliZoIOSIWbpWfTZP1isLbhnHx6SLgw7Nkd6i8cc05x1mOGYnVcmiawNwCMw8VAqs2ijpioAdltd07A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5780
X-Proofpoint-GUID: XkiDhXX_HHi8f8wBIlXXs7-o4WAMKa4t
X-Proofpoint-ORIG-GUID: XkiDhXX_HHi8f8wBIlXXs7-o4WAMKa4t
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-04_16,2023-07-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1011
 malwarescore=0 priorityscore=1501 mlxlogscore=881 suspectscore=0
 impostorscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2305260000 definitions=main-2307050008
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Commit da56a1bfbab5("PCI: dwc: Wait for link up only if
link is started") adds the judgment on the return value
of dw_pcie_wait_for_link(). When no pci device is connected
and pci does not appear link up, the link will be stopped at
this time. Run host_deinit, so add host_deinit callback function.

  WARNING: CPU: 2 PID: 70 at drivers/regulator/core.c:2398 _regulator_put.part.0+0x17c/0x194
  Modules linked in:
  CPU: 2 PID: 70 Comm: kworker/u8:4 Not tainted 6.4.0-rc1-00001-gda56a1bfbab5-dirty #22
  Hardware name: NXP i.MX8MQ EVK (DT)
    Call trace:
    _regulator_put.part.0+0x17c/0x194
    regulator_put+0x3c/0x54
    devm_regulator_release+0x14/0x20
    release_nodes+0x8c/0x13c
    devres_release_all+0x8c/0x108
    device_unbind_cleanup+0x18/0x68
    really_probe+0xe4/0x27c
    __driver_probe_device+0x78/0x12c
    driver_probe_device+0x3c/0x118
    __device_attach_driver+0xb8/0xf8
    bus_for_each_drv+0x84/0xe4
    __device_attach_async_helper+0xc0/0xe4
    async_run_entry_fn+0x34/0xe0
    process_one_work+0x290/0x5c4
    worker_thread+0x4c/0x408
    kthread+0x128/0x134
    ret_from_fork+0x10/0x20

Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 drivers/pci/controller/dwc/pci-imx6.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 52906f999f2b..e4942bd2598d 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1039,6 +1039,7 @@ static void imx6_pcie_host_exit(struct dw_pcie_rp *pp)
 
 static const struct dw_pcie_host_ops imx6_pcie_host_ops = {
 	.host_init = imx6_pcie_host_init,
+	.host_deinit = imx6_pcie_host_exit,
 };
 
 static const struct dw_pcie_ops dw_pcie_ops = {
-- 
2.25.1