Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <974a48a8-7402-6303-10e8-9d5fe475bb42@redhat.com>
Date:   Tue, 4 Jul 2023 23:10:01 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] cgroup/cpuset: avoid unneeded cpuset_mutex re-lock
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>, tj@kernel.org,
        hannes@cmpxchg.org, lizefan.x@bytedance.com
Cc:     cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230704120352.1226787-1-linmiaohe@huawei.com>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20230704120352.1226787-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/4/23 08:03, Miaohe Lin wrote:
> cpuset_mutex unlock and lock pair is only needed when transferring tasks
> out of empty cpuset. Avoid unneeded cpuset_mutex re-lock when !is_empty
> to save cpu cycles.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   kernel/cgroup/cpuset.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 601c40da8e03..e136269c152c 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3521,17 +3521,16 @@ hotplug_update_tasks_legacy(struct cpuset *cs,
>   	is_empty = cpumask_empty(cs->cpus_allowed) ||
>   		   nodes_empty(cs->mems_allowed);
>   
> -	mutex_unlock(&cpuset_mutex);
> -
>   	/*
>   	 * Move tasks to the nearest ancestor with execution resources,
>   	 * This is full cgroup operation which will also call back into
>   	 * cpuset. Should be done outside any lock.
>   	 */
> -	if (is_empty)
> +	if (is_empty) {
> +		mutex_unlock(&cpuset_mutex);
>   		remove_tasks_in_empty_cpuset(cs);
> -
> -	mutex_lock(&cpuset_mutex);
> +		mutex_lock(&cpuset_mutex);
> +	}
>   }
>   
>   static void
Reviewed-by: Waiman Long <longman@redhat.com>