Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Saurav Kashyap <skashyap@marvell.com>,
        Javed Hasan <jhasan@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com (supporter:BROADCOM BNX2FC 10
        GIGABIT FCOE DRIVER), "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org (open list:BROADCOM BNX2FC 10 GIGABIT FCOE
        DRIVER), linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] deivers: scsi: Remove duplicate assignments
Date:   Wed,  5 Jul 2023 11:50:17 +0800
Message-Id: <20230705035017.3262-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jiK+aPK/zX3RqCT9Ctu8PNBhhEn4i/wz6GBYqjpiDAG3Y9SYIeB+oq9lB3nU?=
 =?us-ascii?Q?weI8bmJqSje5ns7/oPf8J6aMMyebSHQUv8wZ6h4drg1NQuO3VxQzhUyIBm/x?=
 =?us-ascii?Q?1r9YC2uOaC1oKuuV9WuQ83Ugz6wHb2EN6MU+14u8Z0HXHkMr6kftWPZRK3P5?=
 =?us-ascii?Q?ay5uHpDZcZiTtIVdoBzfbCDCFlwLEDDKu+ovIM1qNMUDLRSO83uZRb3Z/dG/?=
 =?us-ascii?Q?NVG+sfjgSTUIYSGuCudF5HXYOV3MbNBi410M3KX2lScXfOM/Ao6kWGqI7QIG?=
 =?us-ascii?Q?RP/Je9Gpu3OyF+tZSN3tQbdEYBofOShhRoGX9kkwJGpl/2Q+LXs15t+xPG9U?=
 =?us-ascii?Q?7Y0fVtY5xDGtDlU2RY5WjGxcRG4YuTq7LIkG+c7zPtttIvlLsoftrNOryX/E?=
 =?us-ascii?Q?Dq30xY+j76CyFDg/dR6Da1AT0jrFgDXjD10whhGsgXF0K/LZJG/EMS5lvg/L?=
 =?us-ascii?Q?FhreXWOhqOs3PYrAJKrEJGjp9EOoVxbO8GyuTHRA65jt6wCOEO27tQwOoqZa?=
 =?us-ascii?Q?bwpYdbtOjDZcJvSjowDA8wf3e47DqEsaLRpWX6t2KrxKfvdNpY0D5IwoRAWa?=
 =?us-ascii?Q?sGY7uv0iRe757bsAYsXkhGU4qj842wkZ9Ph521h/sWTuyRDBS4hQCwY1EPfd?=
 =?us-ascii?Q?IpMcn3VxXmP19uJzhNP1N3z03G5TqcJ80+FpB3U6ub5Hprn3oG2be2tddsqk?=
 =?us-ascii?Q?14I7kjt4x5jax7cSgmABtz5sM056lc5oinZ3o+ANJfHrIXeHbJWq7Ty1cNwo?=
 =?us-ascii?Q?4+dGK4Mpi+L+/E5dY7M2eWM8EBVhW8P4+F5bcWf8t5xlbC50SldTvxczEvxT?=
 =?us-ascii?Q?viBp0rtFpivmeKmZZIsa8fhE0UQcZ0et/0fbiOemqm8HXICRVXwacR7ag7FY?=
 =?us-ascii?Q?/qY6uEIGgYOKBn0YdHtae7vxG4qrSDlvaRaLSofIh8ys2XfJ+dJldBNH8fml?=
 =?us-ascii?Q?9Z2B5PBcz31lsC5yD10j/NxSUO8hHgqJeahGwXuscX6XNnHAN1NhBXHcMrbm?=
 =?us-ascii?Q?Hj/n6JQXx+0npxtMuaSHiLcuChUU/ebFf8j7wInSzUX++uQysfRHq4dXEMCm?=
 =?us-ascii?Q?p3fM4/Z0wBgychwnORTpc4SRRewrCTwyViwCkPBptSCvf3P7aAoghavabsAv?=
 =?us-ascii?Q?7D57qofIj5V65nF5Y3vWVVifErCgm1FsiQBB5aWfqxesKwGapVOdNRryBsxe?=
 =?us-ascii?Q?ywAJdbtGJgJeVYEXflgC/FG7/TwPiBb2zh8aL9kPnNo+HJKpFn82xxW8I0bf?=
 =?us-ascii?Q?gDc3B5MVEio61jhxDwB8IqrEVy1TDFMN4Pa4A3kWPdqQt/ZKlAZiO1jjROie?=
 =?us-ascii?Q?ENYsY5gUwhk6U3yVKM+puvP6OMLWc8hFSw01YS6AdkYehMpiWiQ0M/haWGAG?=
 =?us-ascii?Q?WuBWYfpor7Zk/Utj5+wvOWBDC76aOmaXx6ifQTDYcCDSYXDFWLLysruzweOO?=
 =?us-ascii?Q?krKNMaG2bT0AmQjhZHXacXM8GckppoL5CZ2vQ7ySdWi8D7JDJpZzSYmQVW/a?=
 =?us-ascii?Q?8fI1j3fH06jnJsMBuAN0b4ENW5Ay2OSAtvoJwrSlTHNT4XQwKD1out0fCVc9?=
 =?us-ascii?Q?GVNIkLXfqFaMzHyIfdIJ12qMCoOa9d2+cJwL0qZ/?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f8eba92-646e-4fa5-7180-08db7d0af960
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 03:50:29.2802
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xkz6BvLSWsoiqGfVLY2pCR51p4YuDZLrHMwwv4xCF69cLulLybokWwZvRvUWnHzRRlRTjaJBTjJyy88LEXN53A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6272
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

make task->rxwr_txrd.const_ctx.init_flags avoid double assignment.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index 776544385..0474fe88a 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
@@ -1521,8 +1521,6 @@ void bnx2fc_init_seq_cleanup_task(struct bnx2fc_cmd *seq_clnp_req,
 				FCOE_TCE_TX_WR_RX_RD_CONST_CLASS_TYPE_SHIFT;
 	task->rxwr_txrd.const_ctx.init_flags = context_id <<
 				FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
-	task->rxwr_txrd.const_ctx.init_flags = context_id <<
-				FCOE_TCE_RX_WR_TX_RD_CONST_CID_SHIFT;
 
 	task->txwr_rxrd.union_ctx.cleanup.ctx.cleaned_task_id = orig_xid;
 
@@ -1763,7 +1761,6 @@ void bnx2fc_init_task(struct bnx2fc_cmd *io_req,
 				FCOE_TASK_DEV_TYPE_TAPE <<
 				FCOE_TCE_TX_WR_RX_RD_CONST_DEV_TYPE_SHIFT;
 		io_req->rec_retry = 0;
-		io_req->rec_retry = 0;
 	} else
 		task->txwr_rxrd.const_ctx.init_flags |=
 				FCOE_TASK_DEV_TYPE_DISK <<
-- 
2.39.0