Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1688460800.git.pengfei.xu@intel.com> <582ab7050597df7a996c11df048f168995b30747.1688460800.git.pengfei.xu@intel.com>
In-Reply-To: <582ab7050597df7a996c11df048f168995b30747.1688460800.git.pengfei.xu@intel.com>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Wed, 5 Jul 2023 06:28:10 +0200
Message-ID: <CACT4Y+aBNX9U7yeH8jz5y82tV46iChCFXufg92gSXrdRubqJsw@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] x86/kernel: Increase kcov coverage under
 arch/x86/kernel folder
To:     Pengfei Xu <pengfei.xu@intel.com>
Cc:     nogikh@google.com, linux-kernel@vger.kernel.org,
        Heng Su <heng.su@intel.com>, syzkaller@googlegroups.com,
        keescook@google.com, Mehta Sohil <sohil.mehta@intel.com>,
        kirill.shutemov@linux.intel.com, akpm@linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 4 Jul 2023 at 10:58, Pengfei Xu <pengfei.xu@intel.com> wrote:
>
> Currently kcov instrument is disabled for object files under arch/x86/kernel
> folder.
> For object files under arch/x86/kernel, actually just disabling the kcov
> instrument of files:"head32.o or head64.o and sev.o" could achieve
> successful booting and provide kcov coverage for object files that do not
> disable kcov instrument.
> The additional kcov coverage collected from arch/x86/kernel folder helps
> kernel fuzzing efforts to find bugs.
>
> Link to related improvement discussion is below:
> https://groups.google.com/g/syzkaller/c/Dsl-RYGCqs8/m/x-tfpTyFBAAJ
> Related ticket is as follow:
> https://bugzilla.kernel.org/show_bug.cgi?id=198443
>
> Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>

Reviewed-and-tested-by: Dmitry Vyukov <dvyukov@google.com>

I've run a local syzkaller instance with this and I don't see any
additional kernel bugs caused by this and I see coverage in
arch/x86/kernel/* now, in particular, dumpstack.c, perf_regs.c,
signal.c.


> ---
>  arch/x86/kernel/Makefile | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index 4070a01c11b7..00df34c263cc 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -33,11 +33,10 @@ KCSAN_SANITIZE := n
>  KMSAN_SANITIZE_head$(BITS).o                           := n
>  KMSAN_SANITIZE_nmi.o                                   := n
>
> -# If instrumentation of this dir is enabled, boot hangs during first second.
> -# Probably could be more selective here, but note that files related to irqs,
> -# boot, dumpstack/stacktrace, etc are either non-interesting or can lead to
> -# non-deterministic coverage.
> -KCOV_INSTRUMENT                := n
> +# If instrumentation of the following files is enabled, boot hangs during
> +# first second.
> +KCOV_INSTRUMENT_head$(BITS).o                          := n
> +KCOV_INSTRUMENT_sev.o                                  := n
>
>  CFLAGS_irq.o := -I $(srctree)/$(src)/../include/asm/trace
>
> --
> 2.31.1
>