Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 06:39:55 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Astra Joan <astrajoan@yahoo.com>
Cc:     davem@davemloft.net, edumazet@google.com, ivan.orlov0322@gmail.com,
        kernel@pengutronix.de, kuba@kernel.org, linux-can@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux@rempel-privat.de,
        mkl@pengutronix.de, netdev@vger.kernel.org, pabeni@redhat.com,
        robin@protonic.nl, skhan@linuxfoundation.org,
        socketcan@hartkopp.net,
        syzbot+1591462f226d9cbf0564@syzkaller.appspotmail.com,
        syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] can: j1939: prevent deadlock by changing
 j1939_socks_lock to rwlock
Message-ID: <20230705043955.GE15522@pengutronix.de>
References: <F17EC83C-9D70-463A-9C46-FBCC53A1F13C.ref@yahoo.com>
 <F17EC83C-9D70-463A-9C46-FBCC53A1F13C@yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <F17EC83C-9D70-463A-9C46-FBCC53A1F13C@yahoo.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Jul 04, 2023 at 10:55:47AM -0700, Astra Joan wrote:
> Hi Oleksij,
> 
> Thank you for providing help with the bug fix! The patch was created
> when I was working on another bug:
> 
> https://syzkaller.appspot.com/bug?extid=881d65229ca4f9ae8c84
> 
> But the patch was not a direct fix of the problem reported in the
> unregister_netdevice function call. Instead, it suppresses potential
> deadlock information to guarantee the real bug would show up. Since I
> have verified that the patch resolved a deadlock situation involving
> the exact same locks, I'm pretty confident it would be a proper fix for
> the current bug in this thread.
> 
> I'm not sure, though, about how I could instruct Syzbot to create a
> reproducer to properly test this patch. Could you or anyone here help
> me find the next step? Thank you so much!

Sorry, I'm not syzbot expert. I hope someone else can help here.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |