Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <88d0c858-586b-bf59-8d57-d31ec63a9e35@amd.com>
Date:   Wed, 5 Jul 2023 11:18:37 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [RFC PATCH V3 1/1] sched/numa: Fix disjoint set vma scan
 regression
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        kernel test robot <oliver.sang@intel.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Mel Gorman <mgorman@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>, rppt@kernel.org,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Bharata B Rao <bharata@amd.com>,
        Aithal Srikanth <sraithal@amd.com>
References: <cover.1685506205.git.raghavendra.kt@amd.com>
 <8581ca937d4064b3cd138845d5bd418580d177da.1685506205.git.raghavendra.kt@amd.com>
From:   Raghavendra K T <raghavendra.kt@amd.com>
In-Reply-To: <8581ca937d4064b3cd138845d5bd418580d177da.1685506205.git.raghavendra.kt@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnBVTmVBVytPc0ZMUm9aTEpLeGo4SGpZMWIyTGN0Y3VyR3k1VTF5Y1B3Zk1j?=
 =?utf-8?B?MHZuYU00TVpNdHU0R21jWmZ5SUlQRkJXTjFSaTFHdm5HdVpyWlgxOUlNYktC?=
 =?utf-8?B?NWM4MzlOaHh2bmlLUzFEdlB4MzVRbjRDdWdOVmZndzNLUFgzRXFaS2pOVmJt?=
 =?utf-8?B?YUxOSlZpRlJDeS9DdTN2bm1JUmV2R1dKNVo0RVJST3ZZWVlyR0hVOUl3Q25D?=
 =?utf-8?B?T09ya09XakJLMHM0REZTa0tkQmQ5cElNSEZGcmZ3QXQzYWg0bS8wdFRFWmxo?=
 =?utf-8?B?U2JxTjRScGlXTDFQQzFjVXpzRXF3aGlPTWdmV09HNHgxTDI3TWQwbzdrK09I?=
 =?utf-8?B?cmd4ajBEZjQxbHpXNkYvRFFsWW5VQlBnb2JRWTd5N2M4d2UwUnVpUXU5bkYz?=
 =?utf-8?B?bmVkd2N4aEVoTWFtSFJkSVhrck1aQXB5dThDM3ZGdmZGSzdZN0U2aEMvSkRZ?=
 =?utf-8?B?bUlqZkUrOWRkRXpQaGZueFM5R1ZQKzV1eksranVXeFMxdlRPK1VNMS9pV0Va?=
 =?utf-8?B?ZHZHSVdFcVNYT3J6ZWJKNHlVaUJBWlZRWVpMdjBNZ25HeURMTk5GUDRHVkJK?=
 =?utf-8?B?U2RMVnJXcVAwa3FVN25xbVhvaWxwU1pqS3AxcTlzMmMvSjZRcDVNdDVwQ094?=
 =?utf-8?B?SC9ZN1lXYUFJQzZjQkxrc3BoNm13aitDTWV3eStJNkt5QU1TWWhieTBtYmVu?=
 =?utf-8?B?a2RMeTR6UUlObit5cVdOTlRkVXU5OXFyYmFRMWhwbzQ1Ry9GcEE3VDdtSEpD?=
 =?utf-8?B?R2dySWZqR2JWMk9GMWF1UmhnQW1iNzVJbXFuaUVCcDhDWU0xYnRFU2o5OTJY?=
 =?utf-8?B?aDFzOWR0cUhza29JQ2xpaHIzak5OdS9MS0lRUHFMK01NWXZ0NDBEUzdGei82?=
 =?utf-8?B?TDBoeXcya3Y1QzFDcS9MODlNUnNwS1kyVnk2Y2RnRk5EOTFXR3ZHTE9kZStw?=
 =?utf-8?B?cDBJeUY2YWhyOVlJajN3YzZ1eGJidXNLeE5yWEFOd0lIOVpid20wankwYTg1?=
 =?utf-8?B?S2pZZGNUWU8wRlJOQ0RvcG9SWnYySjVZUCsvU0s1dmJLbTkzK0pPMDE1VENC?=
 =?utf-8?B?TGoxbHp5VVY0K043cUwwdVNSVDdRcHhlblFGR2s0bVZoa2d3dkNjdUUvT1ZV?=
 =?utf-8?B?bnVjRTM0aXl5eE1NSVowQmNjQmwyd011SFhUNXZ6OER1dDZpcjQwY0RRYUdK?=
 =?utf-8?B?TG9nMldpK3hRRDVLNmh0RUVqRlViUGFvdTBITnArcDdQMmhpQnp4OXVCUEZB?=
 =?utf-8?B?Z1JqMmF4WmtQZHRjdTk2YWVWd2JOaG5wZE5pT0xUbXFnWlI5aDBGQ3NrR2hi?=
 =?utf-8?B?QkdncVJiRW9LWmc4Smh6b0kxZlVkN1FKb1JENFFZZG9HMmNpVzVnc0JSV3B2?=
 =?utf-8?B?VDRQQ1hBVXFSbXFjUGVnQm1sTHVpbGNMWUMxTjZISUpkVGhYekUrWnpMUDFP?=
 =?utf-8?B?cDNSVlJWTFVrWkdWdUNsSlZYU3dKRzVCV0gzT2haQVYxN3VDLzZ1M09YVzU5?=
 =?utf-8?B?MncrL2xCMGRXYVNybkFNdmIwcFI1UnhSSWFPYzF4UFVnYXlic3pkWG1SeHcw?=
 =?utf-8?B?aXR0TFpzNTlQWEpUMjFPYkwvazh1bkt4VVVhUTNPcDhnR1FxYmJUckp6V0V1?=
 =?utf-8?B?SlZXRmZVT3hZRWhYSlhFRmVyTjJHajNoQVdBdHp0OEN6ZnlIdG5pMHIzdGNI?=
 =?utf-8?B?dTBuWThiTkRHUFVUYXJ5WUY2c005RmxhbHdNaUZ1bklyUE5GS0prU3BlUzVk?=
 =?utf-8?B?MEpua01lQWpxQ2ozOFdKZnRQeGtQb2tVODRHWllEQ1BpenpjOVpuTTZTb0tp?=
 =?utf-8?B?dEQwaXRiUmVIMnBkVVRvSmJkQ1g3aCtqeTE4d2VFUjJ2bytMYzJ3OUtPUk80?=
 =?utf-8?B?cEl4ZmdYSTdNbXRTcEc5aDlKQ1hIRCtGekQrZ0M3RzM2UWpaMkI2MXRZZEJS?=
 =?utf-8?B?a3JGZGdXckxhd1NMS3lGeEZTeWxpYjF6NkZQYnd3YmU2TitpZ3M3N1dsR2Yw?=
 =?utf-8?B?Ly80TlFOd1BZajhIRmxYcDhrTlNMMUsrTmNzZXJOcW4xUDNDc0thVzVhU0xl?=
 =?utf-8?B?aFhCWU5kNEpWYTZNblI0aWR4VE5BQnp0eXM5dVFuVTJ2Y3JweWpwT2w2eXVH?=
 =?utf-8?Q?MU3zBwwrbMrRofyho05Xnvd/K?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 968bed6d-3afe-4c79-73fd-08db7d1b8134
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3008.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 05:48:49.3338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HgQN/eTbXdD2fyEsjgQtCkUsMhNx/gCYotRNNQhM9b9oC8GVWN9CcseFTLFferM9idh4K+Ece4FHzk+r9dEpyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8716
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/31/2023 9:55 AM, Raghavendra K T wrote:
>   With the numa scan enhancements [1], only the threads which had previously
> accessed vma are allowed to scan.
> 
> While this had improved significant system time overhead, there were corner
> cases, which genuinely need some relaxation. For e.g.,
> 
> 1) Concern raised by PeterZ, where if there are N partition sets of vmas
> belonging to tasks, then unfairness in allowing these threads to scan could
> potentially amplify the side effect of some of the vmas being left
> unscanned.
> 
> 2) Below reports of LKP numa01 benchmark regression.
> 
> Currently this is handled by allowing first two scanning unconditional
> as indicated by mm->numa_scan_seq. This is imprecise since for some
> benchmark vma scanning might itself start at numa_scan_seq > 2.
> 
> Solution:
> Allow unconditional scanning of vmas of tasks depending on vma size. This
> is achieved by maintaining a per vma scan counter, where
> 
> f(allowed_to_scan) = f(scan_counter <  vma_size / scan_size)
> 
> Result:
> numa01_THREAD_ALLOC result on 6.4.0-rc2 (that has numascan enhancement)
>                  	base-numascan	base		base+fix
> real    		1m1.507s	1m23.259s	1m2.632s
> user    		213m51.336s	251m46.363s	220m35.528s
> sys     		3m3.397s	0m12.492s	2m41.393s
> 
> numa_hit 		5615517		4560123		4963875
> numa_local 		5615505		4560024		4963700
> numa_other 		12		99		175
> numa_pte_updates 	1822797		493		1559111
> numa_hint_faults 	1307113		523		1469031
> numa_hint_faults_local 	612617		488		884829
> numa_pages_migrated 	694370		35		584202
> 
> Summary: Regression in base is recovered by allowing scanning as required.
> 
> [1] https://lore.kernel.org/lkml/cover.1677672277.git.raghavendra.kt@amd.com/T/#t
> 
> Fixes: fc137c0ddab2 ("sched/numa: enhance vma scanning logic")
> regression.
> Reported-by: Aithal Srikanth <sraithal@amd.com>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/lkml/db995c11-08ba-9abf-812f-01407f70a5d4@amd.com/T/
> Signed-off-by: Raghavendra K T <raghavendra.kt@amd.com>

Hello kernel test robot,

Gentle ping to check if the patch has helped your regression report.

Thanks
- Raghu