Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c74c932-83a1-6b9a-c799-347b25c1979b@xs4all.nl>
Date:   Wed, 5 Jul 2023 08:19:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v1] drivers: usb: remove duplicate logical judgments in if
Content-Language: en-US
To:     Minjie Du <duminjie@vivo.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        "open list:GO7007 MPEG CODEC" <linux-media@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     opensource.kernel@vivo.com
References: <20230704104017.9535-1-duminjie@vivo.com>
From:   Hans Verkuil <hverkuil-cisco@xs4all.nl>
In-Reply-To: <20230704104017.9535-1-duminjie@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Minjie,

On 04/07/2023 12:40, Minjie Du wrote:
> Fix: delate duplicate judgments
> Does the judgment content of this if
> mean requesting confirmation twice?
> I'm not sure, Could you help check it out?
> Thank you!

From what I can tell it tries to send the reset request a
second time if the first attempt fails. Fair enough.

So let's leave this as-is.

Regards,

	Hans

> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/media/usb/go7007/go7007-usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/usb/go7007/go7007-usb.c b/drivers/media/usb/go7007/go7007-usb.c
> index eeb85981e..c85e48e16 100644
> --- a/drivers/media/usb/go7007/go7007-usb.c
> +++ b/drivers/media/usb/go7007/go7007-usb.c
> @@ -653,8 +653,7 @@ static int go7007_usb_interface_reset(struct go7007 *go)
>  	if (usb->board->flags & GO7007_USB_EZUSB) {
>  		/* Reset buffer in EZ-USB */
>  		pr_debug("resetting EZ-USB buffers\n");
> -		if (go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0 ||
> -		    go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0)
> +		if (go7007_usb_vendor_request(go, 0x10, 0, 0, NULL, 0, 0) < 0)
>  			return -1;
>  
>  		/* Reset encoder again */