Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cd9bcc6d-dc69-cd25-d621-d97a7ba2866d@xs4all.nl>
Date:   Wed, 5 Jul 2023 08:21:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v1] drivers: media: remove duplicate assignments
Content-Language: en-US
To:     Minjie Du <duminjie@vivo.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" 
        <linux-media@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     opensource.kernel@vivo.com
References: <20230705044750.8498-1-duminjie@vivo.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
In-Reply-To: <20230705044750.8498-1-duminjie@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/07/2023 06:47, Minjie Du wrote:
> make second_timeout avoid double assignment.

Please post a v2 where you mention the driver name in the subject.

"drivers: media:" suggests a patch touching on many media drivers instead
of just a single driver.

Regards,

	Hans

> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/media/pci/saa7164/saa7164-fw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/pci/saa7164/saa7164-fw.c b/drivers/media/pci/saa7164/saa7164-fw.c
> index 363689484..cc9f384f7 100644
> --- a/drivers/media/pci/saa7164/saa7164-fw.c
> +++ b/drivers/media/pci/saa7164/saa7164-fw.c
> @@ -271,7 +271,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
>  			dprintk(DBGLVL_FW, "%s() Loader 1 has loaded.\n",
>  				__func__);
>  			first_timeout = SAA_DEVICE_TIMEOUT;
> -			second_timeout = 60 * SAA_DEVICE_TIMEOUT;
>  			second_timeout = 100;
>  
>  			err_flags = saa7164_readl(SAA_SECONDSTAGEERROR_FLAGS);