Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <991959c5-37b2-4b41-e329-c088a250cef8@enneenne.com>
Date:   Wed, 5 Jul 2023 09:04:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 3/5] pps: clients: gpio: add option to set capture-clear
 from device-tree
Content-Language: en-US
To:     "Farber, Eliav" <farbere@amazon.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     ronenk@amazon.com, talel@amazon.com, hhhawa@amazon.com,
        jonnyc@amazon.com, itamark@amazon.com, shellykz@amazon.com,
        amitlavi@amazon.com, almogbs@amazon.com
References: <20230625142134.33690-1-farbere@amazon.com>
 <20230625142134.33690-4-farbere@amazon.com>
 <04d52b5d-700c-c5d3-07ae-d4b8ad4fc3cd@amazon.com>
From:   Rodolfo Giometti <giometti@enneenne.com>
In-Reply-To: <04d52b5d-700c-c5d3-07ae-d4b8ad4fc3cd@amazon.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 04/07/23 07:07, Farber, Eliav wrote:
> On 6/25/2023 5:21 PM, Eliav Farber wrote:
>> Enable capture clear events if "capture-clear" boolean property exists
>> in device-tree.
>>
>> Signed-off-by: Eliav Farber <farbere@amazon.com>
>> ---
>> drivers/pps/clients/pps-gpio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
>> index 2f4b11b4dfcd..a61dc1299ce9 100644
>> --- a/drivers/pps/clients/pps-gpio.c
>> +++ b/drivers/pps/clients/pps-gpio.c
>> @@ -112,6 +112,7 @@ static int pps_gpio_setup(struct device *dev)
>>
>>     data->assert_falling_edge =
>>         device_property_read_bool(dev, "assert-falling-edge");
>> +    data->capture_clear = device_property_read_bool(dev, "capture-clear");
> 
> Rodolfo, currently data->capture_clear is false by default, and there
> is no way of setting it in the pps-gpio driver.
> How would you suggest setting it?

I think that driver needs a review... in fact, by using gpiod_*() functions we 
should be able to remove both assert_falling_edge and capture_clear flags.

> Will it be OK to setting PPS_WIDTHASSERT by default?

I think they can both be asserted by default. Why should someone may prefer to 
disable one of them?

Ciao,

Rodolfo

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti