Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c092b860-33d5-77c0-456c-367d545e8b7f@vivo.com>
Date:   Wed, 5 Jul 2023 15:43:38 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3 1/5] genirq/devres: Add
 devm_request_threaded_irq_emsg()
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc:     Krzysztof Kozlowski <krzk@kernel.org>, miquel.raynal@bootlin.com,
        rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org,
        rui.zhang@intel.com, mmayer@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com,
        florian.fainelli@broadcom.com, tglx@linutronix.de,
        matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        bchihi@baylibre.com, wenst@chromium.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20230703090455.62101-1-frank.li@vivo.com>
 <20230703090455.62101-2-frank.li@vivo.com>
 <f4873823-fd7e-c6dd-fbc0-eac4a9be52b1@kernel.org>
 <20230703174347.4m6hcmify4jwsozv@pengutronix.de>
 <11052797-b006-11bb-e4eb-987ddd568b24@kernel.org>
 <20805fef-d6aa-91d8-999e-04b1d6b7a37a@vivo.com>
 <20230704141954.fcmol2yswkpbnpaw@pengutronix.de>
 <20230705101537.000059d2@Huawei.com>
 <20230705073000.oxlb7e7sdkdxurps@pengutronix.de>
From:   Yangtao Li <frank.li@vivo.com>
In-Reply-To: <20230705073000.oxlb7e7sdkdxurps@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M241clFGcDlHcUZsWWUxbzdFdUdBZVVTTUoydlU4NnNkVmVURWZDTEFYWEpG?=
 =?utf-8?B?WDJFcWI0QmZhSUZTcXJTNEVJTHZVM2tmYnAvWExZQ3dHUmxGR0pnT24ycFZ1?=
 =?utf-8?B?SFFQZ1JEQmlhMEltbjlBaGpKVHBENVAyenZjT1ZDS0NJZVhSUCs3aTdsbUtJ?=
 =?utf-8?B?SDl1dDR2QkhZTkpvcHlsSFRaVkdmWXU5bGxrT1RJcmd4TGRpNnR0Q0hGbllF?=
 =?utf-8?B?aXRiQlhlclJXSWpjS3Jzd3RVR1F6WmM2aGhlL1RRVUtXTHNZOHFLUUdkSVlo?=
 =?utf-8?B?eVlhU2JWSTIvWDU1QklaQXZ3RkloQmFiSHp2aWdXVDg3dGNiYVFjT2hNTDN4?=
 =?utf-8?B?cHlMN2djSSsreVIvUjVjSHhOa2oxWVBUYVRGTFlHdXdGTk5kbG1PRVZOaGt1?=
 =?utf-8?B?RmhabmZvcm9BSE1jRGEzY0daUWhkM08rYzFnUGg2SjRlbUFnclFLUTNOM0tD?=
 =?utf-8?B?cjBtb2MwRU9vc2NRRjlMdjE1dWlBUlFzQS9FUG9sa1JBNXl6UWJ1TzBjRzVX?=
 =?utf-8?B?bC96aTM4dWo3MldJc2EraThVdGhhU2VEYWJ5Q3ZpNXRvb3RwRWpWTk5vblpE?=
 =?utf-8?B?VzM4R1hxUkQ0aU1xd1pMeFdvOVFQcnlZdGExSmpiM3hzSmpseWNJc3p5Q2gx?=
 =?utf-8?B?R1B4VHhzd3hzTk1FaVlBa0FDeXN2NGZXTkJNVGRpb1lCT3FRRDBva3JtNm8r?=
 =?utf-8?B?bW55Z3JjeGtTSnAzUWg0Q1pqcGpDc2J3bE5FSzVoUytGVDZiTldKNGlzZ21l?=
 =?utf-8?B?SWhOY1pSajVQZkN2NTJEMHpSN2g2YkxoSFp4by9FUHNMM0JNa2V2Qk1pN0hj?=
 =?utf-8?B?NVMxZXNSdEt0UTlBTmVybTdmeFpWdXJhNlZIMEF2Z0k1Nmdxa1c5dXJGMERU?=
 =?utf-8?B?Rnh2UEtEL3A3QlppYkErdFdsc282akNwMU1Oa0hVY1JDR2UrRERjMElsL1M5?=
 =?utf-8?B?T1U3MlJaOFB6bGlyUU5YZ0JxM0JNTzNacnN4aWNlSHZjZDluSzRjYml2dm9D?=
 =?utf-8?B?RlZiNGNXVXFBOVNmUnhEUlVWL1ZhcVNSRmJibWZUR0hDWU0wQWROQ2pERkVq?=
 =?utf-8?B?MGFFKzQ0dStGWXNWMVY4NlNsSi9BTlB2ZDh5Tm9qWkFucWVpWHdZaFNRaElj?=
 =?utf-8?B?dmQ5Vk15ZmdScWlFaTk3ZTFCejdISVNhcG1MazYzWVo4N3BFWWdYSXpZQmFu?=
 =?utf-8?B?dWk2L0p6NFNuQWpmb3lKbkpYS3FYbGhNcEhDblZReCtlbU9waytWOUgxVm9m?=
 =?utf-8?B?cmt5eEVIelUrVHZ3RVNpUDIyblFYMkdMSVRkRllsY2NhZUcyNXlqeWNoWXlG?=
 =?utf-8?B?SnZGS0RzYUtYT1hMSzNiQVdxZDROMS9sdVJDUG44aG1BWm9yNGlheVdQbGcr?=
 =?utf-8?B?akZCMVB3dE53eGpiSVhFbWRld1N5OHBzamJudERkOEhyU2MzMkVqU1dEVGlt?=
 =?utf-8?B?TXhWTWVLNnd5U2dOQktqbnk0WWw5emlGS295djJxMlcvek5TZTlIbzJ3cTZF?=
 =?utf-8?B?c2FicTNad2NzVVcxS0hENHBXcjlpd1NNeUdJQU54RjQ4UlhVOVh5ZVoxL25L?=
 =?utf-8?B?SUJIVVN2a1g4SkxwVVhVWms4QURGUEYrcFRpUkZjbFNIaWxBakphUUc0THd0?=
 =?utf-8?B?Nk9MVHlmcitkei9MS0JaaHNUVGFOTzh2QlUwbVEvNGl0c0VTTThtOFNUWHhQ?=
 =?utf-8?B?Vmt5Z3FsN3NKLy9uamN1dkRITlVKTGlWQ0RaZTZNWkNLQjE1aFN5TXFDUVBk?=
 =?utf-8?B?bHU4WU82NWgybjJ6Nm82Wmc3aVB3VGJER3pBRHFOcVVHd21CcFMwTGpsNW5k?=
 =?utf-8?B?WEVUamY1bTNLOWx0UU84ekdGSDlieDZrRkVXMW8zL0NzQ0FEc250dEd1cjlu?=
 =?utf-8?B?R2tqV1dLUjJQVXFpL0d5OFB5T1l6d3VkVUpTZFUzVnIrM2FnbElnY0xJZDVZ?=
 =?utf-8?B?dTUxcEl3RkMvenJTeGdXckE4a0w4QXZOVnJJd1V0QXpPdnBnRmo4ZWxHamlY?=
 =?utf-8?B?Q3NvNnhwQXVHcExNV3VXU0UzZ1RIZFBZZGhZU0Z2NVUyb2VMb3N3OFYxYm5P?=
 =?utf-8?B?c2hDeHJJQWtzMUEwaDBHNUNWUEYzOXVXeHd4ZUVrQnBDUXV2VXBpdlNyTnJY?=
 =?utf-8?Q?tw6fyB43rXV9MmQt/GfnC3vvq?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1c4dbd7-c1c9-43d1-926b-08db7d2b8f3d
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 07:43:44.5283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ObvD4hhMqjVw97ZQlWKDqG60dLDWUo3FcL0ABuwDQ82xs3iPJoLzx5qqfUivUJdfWXQbYH8MOVOm+tGpwa5uHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6663
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023/7/5 15:30, Uwe Kleine-König wrote:

> Hello,
>
> On Wed, Jul 05, 2023 at 10:15:37AM +0800, Jonathan Cameron wrote:
>> On Tue, 4 Jul 2023 16:19:54 +0200
>> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>>
>>> Hello,
>>>
>>> On Tue, Jul 04, 2023 at 05:06:12PM +0800, Yangtao Li wrote:
>>>> On 2023/7/4 16:48, Krzysztof Kozlowski wrote:
>>>>    
>>>>> [你通常不会收到来自 krzk@kernel.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
>>>>>
>>>>> On 03/07/2023 19:43, Uwe Kleine-König wrote:
>>>>>> Hello Krzysztof,
>>>>>>
>>>>>> On Mon, Jul 03, 2023 at 02:31:59PM +0200, Krzysztof Kozlowski wrote:
>>>>>>> On 03/07/2023 11:04, Yangtao Li wrote:
>>>>>>>> There are more than 700 calls to the devm_request_threaded_irq method.
>>>>>>>> Most drivers only request one interrupt resource, and these error
>>>>>>>> messages are basically the same. If error messages are printed
>>>>>>>> everywhere, more than 1000 lines of code can be saved by removing the
>>>>>>>> msg in the driver.
>>>>>>> ...
>>>>>>>    
>>>>>>>> +int devm_request_threaded_irq_emsg(struct device *dev, unsigned int irq,
>>>>>>>> +                              irq_handler_t handler, irq_handler_t thread_fn,
>>>>>>>> +                              unsigned long irqflags, const char *devname,
>>>>>>>> +                              void *dev_id, const char *emsg)
>>>>>>>> +{
>>>>>>>> +   int rc;
>>>>>>>> +
>>>>>>>> +   rc = devm_request_threaded_irq(dev, irq, handler, NULL, irqflags,
>>>>>>>> +                                  devname, dev_id);
>>>>>>>> +   if (rc && rc != -EPROBE_DEFER) {
>>>>>>>> +           dev_err(dev, "Failed to request %sinterrupt %u %s %s: %pe\n",
>>>>>>>> +                   thread_fn ? "threaded " : "", irq, devname ? : dev_name(dev),
>>>>>>>> +                   emsg ? : "", ERR_PTR(rc));
>>>>>>> It is open-coding dev_err_probe(). Just use dev_err_probe instead.
>>>>>> dev_err_probe is supposed to be only called in probe functions, while
>>>>>> devm_request_threaded_irq might be called in other contexts (e.g. when a
>>>>>> device is opened). That's why I asked to not use dev_err_probe() in v2
>>>>> True, but then all the callers of this function will forget to set
>>>>> deferred probe reason.
>>> That's another reason for letting the driver issue the error message and
>>> not the request_irq function.
>>>   
>>>> So let's use dev_err_probe?
>>>>
>>>> BTW, any suggestions for names here, keep using
>>>> devm_request_threaded_irq_emsg or change to a new name?
>>> I would have called it devm_request_threaded_irq_verbose() which I
>>> consider easier to understand. But maybe  is just my (green)
>>> bikeshed.
>> If going to use dev_err_probe() internally maybe can just use
>> devm_request_threaded_irq_probe() thus reflecting that and making
>> it different to the devm_request_threaded_irq()?
> I like devm_request_threaded_irq_probe(), thanks for that suggestion
> (even though it's red :-)


devm_request_threaded_irq_probe() also sounds good to me, :-) If there 
is no objection, I think it's time to start working on switching the api.

int devm_request_threaded_irq_probe(struct device *dev, unsigned int 
irq, irq_handler_t handler, irq_handler_t thread_fn, unsigned long 
irqflags, const char *devname, void *dev_id, const char *info) { int rc; 
rc = devm_request_threaded_irq(dev, irq, handler, NULL, irqflags, 
devname, dev_id); if (rc) return dev_err_probe(dev, rc, "Failed to 
request %sinterrupt %u %s %s\n", thread_fn ? "threaded " : "", irq, 
devname ? : dev_name(dev), info ? : ""); return 0; } 
EXPORT_SYMBOL(devm_request_threaded_irq_probe); MBR, Yangtao


>
> Best regards
> Uwe
>