Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp28698787rwd; Wed, 5 Jul 2023 01:03:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GBAmGy5RTRHHXFT3PMA28M5FzX4ZgxMyStRnjESy5w7HvYDkCDfDFUAlXGs20nim6YZrn X-Received: by 2002:a05:6808:991:b0:3a0:34c2:6497 with SMTP id a17-20020a056808099100b003a034c26497mr10935913oic.15.1688544235478; Wed, 05 Jul 2023 01:03:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688544235; cv=none; d=google.com; s=arc-20160816; b=l3AcaeKTnLadzOpWBxkalDPMk8FnswsnS9YalH3R4e1vCPy9WDBoXVlbSspENf6azs umIohOenp07iFJzgy4hsqGnSe9bGHxxNf0pNnLw6MGM9EXKjOL3LGv+2LuIVrysB0gw+ f1aezjh4R53PoKjskm4l/4GFEmViUY9CThsHVZO/jZrVWRc5nj3yJBOTEUp3fl4XyohE iZDkTDzr5sg+cVE8P737DdpzNkPu8N3e9P0rND5i0sTzfikQdedoAFiQmhQkpzgjvWIk hSdzswX0ss7aXf9/yZJ18bKaIucphghu9bhJdOZPW66UXwTHghUMNhltNHsLQ9YBkwZe SCSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=KFLNRV6qIyqwAD5yG3l02YxSxy2zFT/Mrid+n8DZyEw=; fh=g3Zk2Huqk/k4iOcmrPItnDBmHvVOK48PRNd7pSkIzM4=; b=ZAQAtYuWzmwkRe2DeyIz6MIJ24UodueELm3udo5I90NdgFP/3Z4Qy/9EEgUjoWsUz5 ai90ZVXveMRXWh3GzpXU6iQYEC4K+3XbkWSLoB5ceFaXjiuHP/U3yLWfR/JyzgAZSRF4 DN8RG53hD32kbNY1Jvmm1QN8C5MwLX3SSk5Wr2RssGpGZYc2DOjUNG1m5oYapYuE6W6E aDuGid/ypQl1fiJNn5fe5UmUjGRUBkPbfTBpVjq07fRTuLFUZqPd5lMy64bssD47cfAX CBOtscepyd1KYvCl/E2AVulBYamQhhZm/JPLz0o1ycjNTMOuQUvgiP/Gk4A1Wrjmnomg vjoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=oIZjXfDG; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="n/vtpbHy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o21-20020a17090ab89500b00262f7dccaecsi1059178pjr.170.2023.07.05.01.03.43; Wed, 05 Jul 2023 01:03:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=oIZjXfDG; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="n/vtpbHy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231846AbjGEHs3 (ORCPT + 99 others); Wed, 5 Jul 2023 03:48:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232171AbjGEHsT (ORCPT ); Wed, 5 Jul 2023 03:48:19 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13348170E; Wed, 5 Jul 2023 00:48:15 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 947075C01A1; Wed, 5 Jul 2023 03:48:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 05 Jul 2023 03:48:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1688543291; x=1688629691; bh=KF LNRV6qIyqwAD5yG3l02YxSxy2zFT/Mrid+n8DZyEw=; b=oIZjXfDGcWPaXU8zA9 UNDTRrZX9Ud9Z0LlOrS1RgBs2fLTKLZ3KS3A+//mmYOp4Or4ZkaZ7zj4LQ6MmSDy 3hs961nwu0pDbadJxg38tSahgZbUdpzWkAFIY2b89hWzQ886ZbVDqEzK2v0sHkb/ mGu74J9Y/rI+K5DjvBGeap6VWXK6HD+tAAzL4gZqY+NwdYoV2UDPy35K9Bd2HOPL VPoTH1gPAh3mJX0dpjM+KuM3fcRWT1y+lqzNJ+U/kU8Cl4GefEHxo0y6twfnlBAO 4OKzcc2b5/O+yByBI4yBtlBIF3ysGSMQ1WzPot6Ca4m132tsMkhcjCvYJdFcW/rW KMIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688543291; x=1688629691; bh=KFLNRV6qIyqwA D5yG3l02YxSxy2zFT/Mrid+n8DZyEw=; b=n/vtpbHyrHd3DUNG8ekLGrMqj8Wnq J2Iq+cpyrw4AH0TGn6uhpMrCoGMEs8kmANyZiWCCCWVP6IScR16YwGynWon1fbwb sN2ldPSyQ0Rcl5WI37k8lgF+6GXFXv9tiHdPePSPXXjQikLy5fjrxHb/WnoX4NEY 8i71qbK+cxXgSHx61oeID1i/2G5TfaDmRhaaIY/hVVY5x6zG7RgYALVwEBUn24x+ zEy8NDwy8A1pZW/rG25BZEPK+YB2Ku9bCkFbNIxBWHYV9x4vrnFELnMd9X/KBwRy uElWAP5s8t4Lvl1AcR6N5k+c4PJh6N5PiTo1WLDmAUIcUoBXHgrK+Dcug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehgdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtsfertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeeuveduheeutdekvefgudevjeeufedvvdevhfejgfelgfdtkeevueegteek gfelfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jul 2023 03:48:10 -0400 (EDT) Date: Wed, 5 Jul 2023 09:48:07 +0200 From: Maxime Ripard To: Yongqiang Niu Cc: Chun-Kuang Hu , CK Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , Sumit Semwal , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Hsin-Yi Wang Subject: Re: [v5, PATCH] drm/mediatek: add dma buffer control for drm plane disable Message-ID: References: <20230705060719.14700-1-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ezt5bj6i4x32plog" Content-Disposition: inline In-Reply-To: <20230705060719.14700-1-yongqiang.niu@mediatek.com> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ezt5bj6i4x32plog Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jul 05, 2023 at 02:07:18PM +0800, Yongqiang Niu wrote: > dma buffer release before overlay disable, that will cause > m4u translation fault warning. >=20 > add dma buffer control flow in mediatek driver: > get dma buffer when drm plane disable > put dma buffer when overlay really disable >=20 > Fixes: 41016fe1028e ("drm: Rename plane->state variables in atomic update= and disable") > Signed-off-by: Yongqiang Niu I think we need more details in the commit message about what the issue is exactly and how it's fixed. This definitely feels like it's not something drivers should have to do. Maxime --ezt5bj6i4x32plog Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZKUgNwAKCRDj7w1vZxhR xV9gAQCAWEWYfF2KLjV9WKYKh0fUDFpBhF7eQHAc8CjPAuRs2wD7BD2SfZEq8/6J HC9N7/Gkq8EGh2R3CfWFFDxJBgqxawo= =zLuL -----END PGP SIGNATURE----- --ezt5bj6i4x32plog--