Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754135AbXJWHPm (ORCPT ); Tue, 23 Oct 2007 03:15:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752840AbXJWHPe (ORCPT ); Tue, 23 Oct 2007 03:15:34 -0400 Received: from brick.kernel.dk ([87.55.233.238]:3139 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbXJWHPc (ORCPT ); Tue, 23 Oct 2007 03:15:32 -0400 Date: Tue, 23 Oct 2007 09:14:07 +0200 From: Jens Axboe To: Heiko Carstens Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@elte.hu, Christoph Schmitt , Swen Schillig , Martin Schwidefsky , linux-s390@vger.kernel.org Subject: Re: [PATCH 04/10] [SG] Update drivers to use sg helpers Message-ID: <20071023071407.GF25962@kernel.dk> References: <1193076664-13652-1-git-send-email-jens.axboe@oracle.com> <1193076664-13652-5-git-send-email-jens.axboe@oracle.com> <20071023062857.GB24546@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071023062857.GB24546@osiris.boeblingen.de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 38 On Tue, Oct 23 2007, Heiko Carstens wrote: > On Mon, Oct 22, 2007 at 08:10:58PM +0200, Jens Axboe wrote: > > Signed-off-by: Jens Axboe > > --- > > You forgot s390's zfcp driver. But unfortunately the trivial fix below > doesn't work. No more I/O possible. Swen and/or Christof could you > provide a correct fix for this please? Thanks! > > --- > drivers/s390/scsi/zfcp_def.h | 4 ++-- > drivers/s390/scsi/zfcp_erp.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > Index: linux-2.6/drivers/s390/scsi/zfcp_def.h > =================================================================== > --- linux-2.6.orig/drivers/s390/scsi/zfcp_def.h > +++ linux-2.6/drivers/s390/scsi/zfcp_def.h > @@ -63,7 +63,7 @@ > static inline void * > zfcp_sg_to_address(struct scatterlist *list) > { > - return (void *) (page_address(list->page) + list->offset); > + return (void *) (page_address(sg_page(list) + list->offset)); > } return sg_virt(list); would be better. I'll fix up the driver, no worries. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/