Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Minjie Du <duminjie@vivo.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        alsa-devel@alsa-project.org (moderated list:SOUND),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] sound: seq: check struct system assignment problem
Date:   Wed,  5 Jul 2023 16:50:22 +0800
Message-Id: <20230705085022.13078-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4XMqQH3AN5/wZ7ALvzPv4v5PjcYXJXeYHtl7MecLDDhnGDxYRKZ/X5Dd5t4A?=
 =?us-ascii?Q?gDPcsY44bJl+ljLSm/9kJ1UDqHFvFu+oeo3MEPRtSeCSUeiYcF0VdEr5hFHF?=
 =?us-ascii?Q?znOYoh27S0LZvAvdXZqsGoLFYHi4z+mffPnEJ4zkR3AF/RroukEujgN6ULuS?=
 =?us-ascii?Q?Nfj46HFZI8ocbo8hy3SbzRbsfflKYUxrEyu8kEujdqTLG+/L2IKr/TkBajA1?=
 =?us-ascii?Q?fgkd1sKWEJO5SUU2iC4hHCkt9SwkiepivEjZj4Z+72nhKA9bxY8VVkh62UIy?=
 =?us-ascii?Q?34Gp6V5Xi9rcwBsxdRDsgIYVzOvDJyITttF3sV0xb6JsJHAEb1l5N8HEe//J?=
 =?us-ascii?Q?snuXR51g1ZDLWNyW7fzJRF7QqtwJ2vt1JmOZ1GO91EsG4v3tKOgUUSCy6MSS?=
 =?us-ascii?Q?uFjPbYF4gxL9zYRNMe1hv3HjWBTU8H/eqLeVrjzYrC2t2e1O0APGamdZQlEO?=
 =?us-ascii?Q?bRp6MszHy4TAITOYDXDa8wp0qCER3Ja3xf3k79pifsMUQOhm1qK5wwq1jLlZ?=
 =?us-ascii?Q?T3bpMQaNr0pSGpybVKuzJlAz3mmL7/n2Vb5nAo9e5ciY2pIKS+0IDkqDAtn3?=
 =?us-ascii?Q?Dm53+0VnzoP83hQGLkx0SErKsm8Z5aEiShM5DRxaoJaryKRJjAtR6vZH/e4f?=
 =?us-ascii?Q?dlHr2BbiUTEn3kWX0raUEPh1XEIUkveDeadO3dPXUT/UrjfnTbb2lgUmAqWD?=
 =?us-ascii?Q?93gdKdF1wcPykd/SWt8T+iEWqe4WdH1r6lxARIAEOYTolPm5wLiz16pupAyO?=
 =?us-ascii?Q?NJHvmnjXt0MIkinGQTVCECfl/FbxkHp051YwSPftLrbQdYl+x676kMHHJMRk?=
 =?us-ascii?Q?11Qrw48mygNzLkhajsuWe4q//4PjhtFt+8JBYZyFfsppI9z+8ZnyWyodraKx?=
 =?us-ascii?Q?D+fHkky6nauT5xW7wmNz4cDU1i1g5td0RSbBWBOwl2rJwNdyKFfOKF4OTNLJ?=
 =?us-ascii?Q?e55zOOuvGmccEmrIJ+asxBHPOvYu8kmfgbkTl0IDscbQg4A2i2DIbaCUwor7?=
 =?us-ascii?Q?7wIqclhoWZ7xnrLlooDhfrHnOejliwsw9S3WlgUzqwzCD3Yy/6W5zDrRz8sS?=
 =?us-ascii?Q?rJhdYVIExB51zj1WiwEKztJqVUcCxGy3pwJN75dw/4kfhHzSKft9g9h4F/83?=
 =?us-ascii?Q?Tz/dl1BrFTPiU/nUWwyuFCBsm9tA2C2zqZQ/GoMLtJ8uYXAZfdPrqGkSBQyw?=
 =?us-ascii?Q?+NvjR/hVSqhovqsYlhAmPCYGSeyUQRMMjTzs1x4p3TlrIQ3TlqK0B1UiMmh0?=
 =?us-ascii?Q?uRDREB5bVw0ikZ15tMHsQh5WeFPHryClLbxPnSE/DTBKTartpQeJRplP5dhi?=
 =?us-ascii?Q?QONy1hoknZOZUDQk/g46gDvn2yERFkTRagzk/bHfwynaLmEAmYPf2j64w/6g?=
 =?us-ascii?Q?77nsBi4kHulRy4UBNiGOPL+OKP8pS/yXznjrKJojAmdZpveSHnrAlKXUn0jd?=
 =?us-ascii?Q?tplEk+SVpafLrn/p61xgD4VRuU3j+ptotWULvazUkV5JO1lcoNp7Xe3BwgbL?=
 =?us-ascii?Q?1voP/0sWdhhK+YZY3QQPe5U4II8Fjbm8L9DN5+dgX9JoJoSkLRk4h/Q66SLj?=
 =?us-ascii?Q?zRNOYp8WA751A7GtF6+6assb/ixf31pHfMMZHHyP?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 936f4a2a-be03-43d3-1b95-08db7d34e433
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 08:50:32.8764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kk7atITCcsRTWHqhBWYo5qzf6CndMPUQjsEGmJQzBykyUoB2H+B9RaZ70Czvp+raB7E9t05q1f3QxMwynxu8Jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6282
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

make data->system.parm1 avoid double assignment.
but note writes "RT message with two parameters to UMP"
is one of assignment is for system.parm2?
I'm not sure, Could you help check it out?
Thank you!


Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 sound/core/seq/seq_ump_convert.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c
index eb1d86ff6..60e637149 100644
--- a/sound/core/seq/seq_ump_convert.c
+++ b/sound/core/seq/seq_ump_convert.c
@@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
 				     unsigned char status)
 {
 	data->system.status = status;
-	data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
 	data->system.parm1 = event->data.control.value & 0x7f;
 	return 1;
 }
-- 
2.39.0