Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 05 Jul 2023 10:55:37 +0200
Message-ID: <87a5waohyu.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Minjie Du <duminjie@vivo.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        alsa-devel@alsa-project.org (moderated list:SOUND),
        linux-kernel@vger.kernel.org (open list),
        opensource.kernel@vivo.com
Subject: Re: [PATCH v1] sound: seq: check struct system assignment problem
In-Reply-To: <20230705085022.13078-1-duminjie@vivo.com>
References: <20230705085022.13078-1-duminjie@vivo.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 05 Jul 2023 10:50:22 +0200,
Minjie Du wrote:
> 
> make data->system.parm1 avoid double assignment.
> but note writes "RT message with two parameters to UMP"
> is one of assignment is for system.parm2?

Yes, that should be rather parm2.
Could you resubmit with that typo fix instead?


Thanks!

Takashi

> I'm not sure, Could you help check it out?
> Thank you!
> 
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  sound/core/seq/seq_ump_convert.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c
> index eb1d86ff6..60e637149 100644
> --- a/sound/core/seq/seq_ump_convert.c
> +++ b/sound/core/seq/seq_ump_convert.c
> @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event,
>  				     unsigned char status)
>  {
>  	data->system.status = status;
> -	data->system.parm1 = (event->data.control.value >> 7) & 0x7f;
>  	data->system.parm1 = event->data.control.value & 0x7f;
>  	return 1;
>  }
> -- 
> 2.39.0
>