Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 13:51:46 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Minjie Du <duminjie@vivo.com>
Cc:     Markus.Elfring@web.de, Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "open list:QLOGIC QL4xxx ETHERNET DRIVER" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Subject: Re: [PATCH v2] qed: Remove a duplicate assignment in
 qed_rdma_create_srq()
Message-ID: <20230705105146.GN6455@unreal>
References: <20230705103547.15072-1-duminjie@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230705103547.15072-1-duminjie@vivo.com>
Precedence: bulk

On Wed, Jul 05, 2023 at 06:35:46PM +0800, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_rdma.c | 1 -
>  1 file changed, 1 deletion(-)

This patch should be resubmitted after merge window ends.

Please specify net-next target in patch subject and add changelog
that describes the differences between versions.

Thanks

> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> index 5a5dbbb8d..41efced49 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> @@ -1795,7 +1795,6 @@ qed_rdma_create_srq(void *rdma_cxt,
>  
>  	opaque_fid = p_hwfn->hw_info.opaque_fid;
>  
> -	opaque_fid = p_hwfn->hw_info.opaque_fid;
>  	init_data.opaque_fid = opaque_fid;
>  	init_data.comp_mode = QED_SPQ_MODE_EBLOCK;
>  
> -- 
> 2.39.0
> 
>