Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp28890116rwd; Wed, 5 Jul 2023 04:23:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlGWi64R/tnFN/JNK7y9H2RWqeb72Qnl1C1L2npkE3YKtqOLP28f8a9s/7CGZ5YfiUr0/Kzh X-Received: by 2002:a17:902:dac4:b0:1b8:9195:1dd8 with SMTP id q4-20020a170902dac400b001b891951dd8mr6009836plx.51.1688556215208; Wed, 05 Jul 2023 04:23:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688556215; cv=none; d=google.com; s=arc-20160816; b=BsB9OkSAa3QxdrBGTkgYWjNOf3PKhy28fipOwfMZZt+lSjRUSIXJ6PpmgpCFNSDL6y bmEaHk1bueK50EJJoDq4Aaah1UnLNZ1OzwEohmktPPcrz30DhzNxvIaLmp6D0ISqTu5u YgfyDpotIeOes+LGrj4xUB4o9+Zfd5aaSmOKbmi/XcOds1Sh0ZtTW+NJYfnuRH5PHnQ0 u8p2Dar34AfxGVDLjznU4liFcf2IPMPuQEMxFPp4J5xURO354AvFHZE9zpMutJNii49E SQmwtDq9TCufBOMvSBBIAM9/xRKcRVvUsTsTW/8xzuBTZfef0PNSiSnq2X7C0Xh/owTu qkVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=gsTtDLFIoqBZ7ioWaGrzG/SavqWPx1AAh28HhZTyGMg=; fh=qGJg2abTeWNEotcBTSlMVa8sntYweZ9cL2Sa6M/unEA=; b=hAH6aqsrkC8MNTA7+zbaAlWh0x+Q+WfeI8uLZ1cOS7xQIP3Wc6qDDdkIIKkoyZA/Fc Tndm4KZa0WmXr7/TeHSGTDubyNsRLkMmIBgYQ6kIgvFYAJM+h1woZhYavoI60NirOYod rxcImOWw3WC/JVmXE4cWv7sDonC5MB+kRDtz4wS6kj1I95ZH6F/htAPlAuGapmJj3zzO BGZXq+E33Clx58amY84eWw0PvNVAwxI8gw5fVWY2ePtSFVE9YtVSvBFZfHhdMqmOVGiX YqZWU+u8ELgSXlPgdY+Dud7UpTqWHZOyLXnPw1SxPK792HJ2FnDOVeut6PDyIXRq/hlD cLkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=YiHJJz6h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14-20020a170902f64e00b001b5656e7d76si23528419plg.293.2023.07.05.04.23.20; Wed, 05 Jul 2023 04:23:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=YiHJJz6h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232259AbjGELCw (ORCPT + 99 others); Wed, 5 Jul 2023 07:02:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231539AbjGELCu (ORCPT ); Wed, 5 Jul 2023 07:02:50 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67262170D; Wed, 5 Jul 2023 04:02:49 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3654N0w9025646; Wed, 5 Jul 2023 11:02:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=gsTtDLFIoqBZ7ioWaGrzG/SavqWPx1AAh28HhZTyGMg=; b=YiHJJz6h/wWeP+WZ7H+5CGbocdwfD9fgbA/EHrHr7Jo9P9/E2CO3ZRgJCiAiaWf8seAU qy51XP1pp7cVtcWcsSk/jv6SpMTW6nLbffzUs1s6+sVwgUxE2p1mbXB0GSAPSK72cHJV gPSZMfz1UqybPZkih2TYdQrQDUn51npe3HIZDMd7dplIc7nj5iBY4Pn4447TOyzdzz5B K1q4FmwTnGjnoqXM6xvKibM3vX/wvGoCgcK8OZ8EIELxU2/5JSgs+2tbrPqP+1efFnRn rq8Up8/89jdw4xlH9z118kBAfNKkjhRdvPZJ99hXlaBeoRZKrbL69PNN+T1JZNj7Pt4S 8Q== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rmfqjju7u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jul 2023 11:02:45 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 365B2hvQ031215 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Jul 2023 11:02:44 GMT Received: from [10.214.67.128] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 5 Jul 2023 04:02:40 -0700 Message-ID: <9ae07f5c-ab40-7089-fe6b-9b85aa077d95@quicinc.com> Date: Wed, 5 Jul 2023 16:32:37 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region Content-Language: en-US To: Dmitry Baryshkov CC: , , , , , , , , References: <20230705053914.9759-1-quic_kbajaj@quicinc.com> <20230705053914.9759-2-quic_kbajaj@quicinc.com> From: Komal Bajaj In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Optqru8VJaMv6Xpqg4RHhK71O8NHibNa X-Proofpoint-ORIG-GUID: Optqru8VJaMv6Xpqg4RHhK71O8NHibNa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-05_02,2023-07-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 bulkscore=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 mlxlogscore=781 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307050096 X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/5/2023 3:12 PM, Dmitry Baryshkov wrote: > On Wed, 5 Jul 2023 at 10:06, Komal Bajaj wrote: >> >> >> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote: >>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj wrote: >>>> Add missing reserved regions as described in QDU1000 memory map. >>>> >>>> Signed-off-by: Komal Bajaj >>>> --- >>>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> index 1d22f87fd238..3f5512ec0a90 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> @@ -448,6 +448,32 @@ &qupv3_id_0 { >>>> status = "okay"; >>>> }; >>>> >>>> +&reserved_memory{ >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + ranges; >>>> + >>>> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ >>> no_underscores_in_node_names. Ever. >>> >>> Also, if you have checked other platforms, you'd have seen that other >>> platforms use a much more generic node name for 'memory' nodes (which >>> you should have used too). >> These memory nodes are new to QDU platform, so will it be okay if I keep >> these names without region suffix? > Just use 'memory@abcd'. Sure, will update like that. > >> Thanks >> Komal >> >>>> + no-map; >>>> + reg = <0x0 0xe0000000 0x0 0x20000000>; >>>> + }; >>>> + >>>> + harq_buffer_mem:harq_buffer_region@800000000{ >>>> + no-map; >>>> + reg = <0x8 0x0 0x0 0x80000000>; >>>> + }; >>>> + >>>> + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ >>>> + no-map; >>>> + reg = <0x8 0x80000000 0x0 0x50000000>; >>>> + }; >>>> + >>>> + fapi_buffer_mem:fapi_buffer_region@8d0000000{ >>>> + no-map; >>>> + reg = <0x8 0xd0000000 0x0 0x20000000>; >>>> + }; >>>> +}; >>>> + >>>> &sdhc { >>>> pinctrl-0 = <&sdc_on_state>; >>>> pinctrl-1 = <&sdc_off_state>; >>>> -- >>>> 2.40.1 >>>> >