Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 12:48:38 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Lee Jones <lee@kernel.org>
Cc:     Hans de Goede <hdegoede@redhat.com>, Pavel Machek <pavel@ucw.cz>,
        Mark Gross <markgross@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/1] leds: simatic-ipc-leds-gpio: add new model BX-21A
Message-ID: <20230705124838.0e05177d@md1za8fc.ad001.siemens.net>
In-Reply-To: <5109f2da-3b7f-421f-555c-810484d92b4c@redhat.com>
References: <20230531155457.31632-1-henning.schild@siemens.com>
        <20230531155457.31632-2-henning.schild@siemens.com>
        <5109f2da-3b7f-421f-555c-810484d92b4c@redhat.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AAvImsFdIldwBM3uAezndf1/1iSEbqSkA6Qke8gAmKV2xQThCvbv6hqFIHef?=
 =?us-ascii?Q?gS96kntWRhiwIrN2LPfPMcf7lCJLFAAcsNKXqsJBSGR0/wrC9w5YN5JrTJj7?=
 =?us-ascii?Q?PlJLOUZ3BwEH8u+vPGC5rVO5uIH5lWval3qi3TkFQgDbsNTwy66DbvWQhtSa?=
 =?us-ascii?Q?szchE0fDpny9N6LYf8LP1azCRxUsWugg3uK6WD71nKY4daUKPaDTN+MWzFRB?=
 =?us-ascii?Q?vBjNa2QxqS7MBNPEBKTdsVP4RMjpOeLjvB89PJIGLYi3YEcgb2tU4sujSEVw?=
 =?us-ascii?Q?D4aeJArjIVFEZnTNOjKmt9aM0avsPda0q+wVdnkfyWD83/+cDcrq4c56iJDH?=
 =?us-ascii?Q?Z7L3TohtTkWQSl8NAx1/wC+SRBx2thC5N17Sw9j2mvu6IQMdoAguA6FMvj2J?=
 =?us-ascii?Q?JBMhhCjep9fKaJelC06dSCnjrMfwJxstZAQR1OVRUZ4uwVuSoADH+i/ZXTcu?=
 =?us-ascii?Q?qsBmZ6xXZkoQdbuftroFY03/HzhQEserQ1L2v2zYgcp7NAQ3z8y1GV45cj30?=
 =?us-ascii?Q?1bzD3a1/+5WLLYfd6EMdkgq2hP4XJ2D+LONk1Suj5GB58aHjUXAKjXNGab10?=
 =?us-ascii?Q?ds/DFMcfjkCFUFnMHHisoDf5wvgEhZRw+2btxVD7ewtKt/x/As3QlLR/kTjS?=
 =?us-ascii?Q?sfB8K4DCc/novaOp0N9hy6wSgGtKn5p77favbIeRO4VLEznIUWszXMIASf+A?=
 =?us-ascii?Q?Cg1PfPKrCG3/W/87/F4dt0GSPcjIAp6vEgaj+5+qsaA/5NxBNDXjQuB/snkF?=
 =?us-ascii?Q?MtldWS5qPUh2IdQNtOYVtEYLTXC2Ntk86oY3J+FRSCqs9Y3fzPILDupEJSKR?=
 =?us-ascii?Q?PQ8PH4ck0roSNOFt2ySAA4EQ8Q8FjdOfzgPjF/MXjPVGx9A0j1xe3R0kmMH2?=
 =?us-ascii?Q?TKcIRhSH7kYXmGjXEngJg7sWKQlUnuhYqeyRkX+zhNnNw603P+/xDOpdYxIW?=
 =?us-ascii?Q?Py7NaFYMliATmoi5NmGcZ/vgEMzIRpq2AvypslZDKm/aEspoX16hlDsKgb7J?=
 =?us-ascii?Q?tmSM7WAdYFmwO9pgb7Z91mNiezbDsgsqq+H6fKzbmBF7JI0uoTG4DaNiMWwB?=
 =?us-ascii?Q?BDQfxcllxH5hlSOq8YSBjzn2CdGq64iWf5GKoKmehll1udP8Vs84fsQlkkHx?=
 =?us-ascii?Q?L3MB15foG8WUZNnQPYVkuHfU6M20UiYD10toY2jH7B93c90tv2CGx/Jexsd2?=
 =?us-ascii?Q?6aWbT9vRoGpMHT63ROrYhkXoIrV2wGv2w/Yx9oNT+h9uYw1cVwkPbrFqXsrj?=
 =?us-ascii?Q?bURolKGgNg9KwvZw6F3tX13Pb//Gk7Clab2ReCrmFOHv40NykCK9f4zH5eUX?=
 =?us-ascii?Q?/5EQ1645KnpcoSrjyjqN5SqkEmaElqJ7/R5bQrh3AFpGsfKYU8Ew+uUNcRBq?=
 =?us-ascii?Q?oQOBrJnp4/eQzEDP/OIf+Zx/8RSMCKIg1g7ADyWjfGEXX7LrN3gk+UYUi6h8?=
 =?us-ascii?Q?CAFo/ccUxJCF/so4yky+fXLFN3iYZy+lQ1soehht/txCLZZRxa9i5ap+osgJ?=
 =?us-ascii?Q?gfDOzXe5rT07fbDWkQq3Gtr86t8tLdeoLvXsT1mO2yenyF5FFeEb/wtip6Hr?=
 =?us-ascii?Q?bxyTfYFIbrXDJ2ZKVj3UVpGn6l1SEmFkBVqUtqd1ntyppv/JjeK8eOdn4rE2?=
 =?us-ascii?Q?qEXvicmIraFB0ru1OXdsLYX+h3BsrFgQ8FRLInzOjrltMnE8f2ycsr9QQzEE?=
 =?us-ascii?Q?oFXCcQ=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94f5abc6-0636-4612-9bdb-08db7d456977
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 10:48:48.1777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nLRt+UIRHAyIFKJstz8YDeCddGaPK/444EssozgWL2LmBXFTB/oq09Yx5eaBjqHB9afZ8EdRJTQQV4iGYMVxKgAPpgxxkVNacQHIx4drm98=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR10MB8147
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Thu, 1 Jun 2023 10:53:48 +0200
schrieb Hans de Goede <hdegoede@redhat.com>:

> Hi,
> 
> On 5/31/23 17:54, Henning Schild wrote:
> > This adds support for the Siemens Simatic IPC BX-21A. Its LEDs are
> > connected to GPIO pins provided by the Intel Elkhart Lake pinctrl
> > driver.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>  
> 
> Thank you for the patch.
> 
> Since this mostly touches files under drivers/leds I believe it would
> be best for this to be merged through Lee's LEDs tree.

Lee i saw that your tree got merged recently. This one was not yet part
of it.

Henning

> Here is my ack for merging the pdx86 bits through that tree:
> 
> Acked-by: Hans de Goede <hdegoede@redhat.com>
> 
> Regards,
> 
> Hans
> 
> 
> 
> 
> > ---
> >  drivers/leds/simple/Kconfig                   | 13 +++++
> >  drivers/leds/simple/Makefile                  |  1 +
> >  .../leds/simple/simatic-ipc-leds-gpio-core.c  |  4 ++
> >  .../simatic-ipc-leds-gpio-elkhartlake.c       | 57
> > +++++++++++++++++++ drivers/platform/x86/simatic-ipc.c            |
> >  3 + .../platform_data/x86/simatic-ipc-base.h      |  1 +
> >  include/linux/platform_data/x86/simatic-ipc.h |  3 +-
> >  7 files changed, 81 insertions(+), 1 deletion(-)
> >  create mode 100644
> > drivers/leds/simple/simatic-ipc-leds-gpio-elkhartlake.c
> > 
> > diff --git a/drivers/leds/simple/Kconfig
> > b/drivers/leds/simple/Kconfig index 44fa0f93cb3b..626ab18ac09d
> > 100644 --- a/drivers/leds/simple/Kconfig
> > +++ b/drivers/leds/simple/Kconfig
> > @@ -34,3 +34,16 @@ config LEDS_SIEMENS_SIMATIC_IPC_F7188X
> >  
> >  	  To compile this driver as a module, choose M here: the
> > module will be called simatic-ipc-leds-gpio-f7188x.
> > +
> > +config LEDS_SIEMENS_SIMATIC_IPC_ELKHARTLAKE
> > +	tristate "LED driver for Siemens Simatic IPCs based on
> > Intel Elkhart Lake GPIO"
> > +	depends on LEDS_GPIO
> > +	depends on PINCTRL_ELKHARTLAKE
> > +	depends on SIEMENS_SIMATIC_IPC
> > +	default LEDS_SIEMENS_SIMATIC_IPC
> > +	help
> > +	  This option enables support for the LEDs of several
> > Industrial PCs
> > +	  from Siemens based on Elkhart Lake GPIO i.e. BX-21A.
> > +
> > +	  To compile this driver as a module, choose M here: the
> > module
> > +	  will be called simatic-ipc-leds-gpio-elkhartlake.
> > diff --git a/drivers/leds/simple/Makefile
> > b/drivers/leds/simple/Makefile index e3e840cea275..783578f11bb0
> > 100644 --- a/drivers/leds/simple/Makefile
> > +++ b/drivers/leds/simple/Makefile
> > @@ -2,3 +2,4 @@
> >  obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC)			+=
> > simatic-ipc-leds.o
> > obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC_APOLLOLAKE)	+=
> > simatic-ipc-leds-gpio-core.o simatic-ipc-leds-gpio-apollolake.o
> > obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC_F7188X)		+=
> > simatic-ipc-leds-gpio-core.o simatic-ipc-leds-gpio-f7188x.o
> > +obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC_ELKHARTLAKE)	+=
> > simatic-ipc-leds-gpio-core.o simatic-ipc-leds-gpio-elkhartlake.o
> > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio-core.c
> > b/drivers/leds/simple/simatic-ipc-leds-gpio-core.c index
> > 2a21b663df87..c552ea73ed9d 100644 ---
> > a/drivers/leds/simple/simatic-ipc-leds-gpio-core.c +++
> > b/drivers/leds/simple/simatic-ipc-leds-gpio-core.c @@ -57,6 +57,7
> > @@ int simatic_ipc_leds_gpio_probe(struct platform_device *pdev,
> > switch (plat->devmode) { case SIMATIC_IPC_DEVICE_127E: case
> > SIMATIC_IPC_DEVICE_227G:
> > +	case SIMATIC_IPC_DEVICE_BX_21A:
> >  		break;
> >  	default:
> >  		return -ENODEV;
> > @@ -72,6 +73,9 @@ int simatic_ipc_leds_gpio_probe(struct
> > platform_device *pdev, goto out;
> >  	}
> >  
> > +	if (!table_extra)
> > +		return 0;
> > +
> >  	table_extra->dev_id = dev_name(dev);
> >  	gpiod_add_lookup_table(table_extra);
> >  
> > diff --git
> > a/drivers/leds/simple/simatic-ipc-leds-gpio-elkhartlake.c
> > b/drivers/leds/simple/simatic-ipc-leds-gpio-elkhartlake.c new file
> > mode 100644 index 000000000000..6ba21dbb3ba0 --- /dev/null
> > +++ b/drivers/leds/simple/simatic-ipc-leds-gpio-elkhartlake.c
> > @@ -0,0 +1,57 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Siemens SIMATIC IPC driver for GPIO based LEDs
> > + *
> > + * Copyright (c) Siemens AG, 2023
> > + *
> > + * Author:
> > + *  Henning Schild <henning.schild@siemens.com>
> > + */
> > +
> > +#include <linux/gpio/machine.h>
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/leds.h>
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/platform_data/x86/simatic-ipc-base.h>
> > +
> > +#include "simatic-ipc-leds-gpio.h"
> > +
> > +static struct gpiod_lookup_table simatic_ipc_led_gpio_table = {
> > +	.dev_id = "leds-gpio",
> > +	.table = {
> > +		GPIO_LOOKUP_IDX("INTC1020:04", 72, NULL, 0,
> > GPIO_ACTIVE_HIGH),
> > +		GPIO_LOOKUP_IDX("INTC1020:04", 77, NULL, 1,
> > GPIO_ACTIVE_HIGH),
> > +		GPIO_LOOKUP_IDX("INTC1020:04", 78, NULL, 2,
> > GPIO_ACTIVE_HIGH),
> > +		GPIO_LOOKUP_IDX("INTC1020:04", 58, NULL, 3,
> > GPIO_ACTIVE_HIGH),
> > +		GPIO_LOOKUP_IDX("INTC1020:04", 60, NULL, 4,
> > GPIO_ACTIVE_HIGH),
> > +		GPIO_LOOKUP_IDX("INTC1020:04", 62, NULL, 5,
> > GPIO_ACTIVE_HIGH),
> > +		{} /* Terminating entry */
> > +	},
> > +};
> > +
> > +static int simatic_ipc_leds_gpio_elkhartlake_probe(struct
> > platform_device *pdev) +{
> > +	return simatic_ipc_leds_gpio_probe(pdev,
> > &simatic_ipc_led_gpio_table,
> > +					   NULL);
> > +}
> > +
> > +static int simatic_ipc_leds_gpio_elkhartlake_remove(struct
> > platform_device *pdev) +{
> > +	return simatic_ipc_leds_gpio_remove(pdev,
> > &simatic_ipc_led_gpio_table,
> > +					    NULL);
> > +}
> > +
> > +static struct platform_driver
> > simatic_ipc_led_gpio_elkhartlake_driver = {
> > +	.probe = simatic_ipc_leds_gpio_elkhartlake_probe,
> > +	.remove = simatic_ipc_leds_gpio_elkhartlake_remove,
> > +	.driver = {
> > +		.name = KBUILD_MODNAME,
> > +	},
> > +};
> > +module_platform_driver(simatic_ipc_led_gpio_elkhartlake_driver);
> > +
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_ALIAS("platform:" KBUILD_MODNAME);
> > +MODULE_SOFTDEP("pre: simatic-ipc-leds-gpio-core
> > platform:elkhartlake-pinctrl"); +MODULE_AUTHOR("Henning Schild
> > <henning.schild@siemens.com>"); diff --git
> > a/drivers/platform/x86/simatic-ipc.c
> > b/drivers/platform/x86/simatic-ipc.c index
> > c773995b230d..4402cd354104 100644 ---
> > a/drivers/platform/x86/simatic-ipc.c +++
> > b/drivers/platform/x86/simatic-ipc.c @@ -48,6 +48,7 @@ static
> > struct { {SIMATIC_IPC_IPC477E, SIMATIC_IPC_DEVICE_NONE,
> > SIMATIC_IPC_DEVICE_427E}, {SIMATIC_IPC_IPCBX_39A,
> > SIMATIC_IPC_DEVICE_227G, SIMATIC_IPC_DEVICE_227G},
> > {SIMATIC_IPC_IPCPX_39A, SIMATIC_IPC_DEVICE_NONE,
> > SIMATIC_IPC_DEVICE_227G},
> > +	{SIMATIC_IPC_IPCBX_21A, SIMATIC_IPC_DEVICE_BX_21A,
> > SIMATIC_IPC_DEVICE_NONE}, };
> >  
> >  static int register_platform_devices(u32 station_id)
> > @@ -72,6 +73,8 @@ static int register_platform_devices(u32
> > station_id) pdevname = KBUILD_MODNAME "_leds_gpio_apollolake";
> >  		if (ledmode == SIMATIC_IPC_DEVICE_227G)
> >  			pdevname = KBUILD_MODNAME
> > "_leds_gpio_f7188x";
> > +		if (ledmode == SIMATIC_IPC_DEVICE_BX_21A)
> > +			pdevname = KBUILD_MODNAME
> > "_leds_gpio_elkhartlake"; platform_data.devmode = ledmode;
> >  		ipc_led_platform_device =
> >  			platform_device_register_data(NULL,
> > diff --git a/include/linux/platform_data/x86/simatic-ipc-base.h
> > b/include/linux/platform_data/x86/simatic-ipc-base.h index
> > 57d6a10dfc9e..00bf18ecb160 100644 ---
> > a/include/linux/platform_data/x86/simatic-ipc-base.h +++
> > b/include/linux/platform_data/x86/simatic-ipc-base.h @@ -20,6 +20,7
> > @@ #define SIMATIC_IPC_DEVICE_127E 3
> >  #define SIMATIC_IPC_DEVICE_227E 4
> >  #define SIMATIC_IPC_DEVICE_227G 5
> > +#define SIMATIC_IPC_DEVICE_BX_21A 6
> >  
> >  struct simatic_ipc_platform {
> >  	u8	devmode;
> > diff --git a/include/linux/platform_data/x86/simatic-ipc.h
> > b/include/linux/platform_data/x86/simatic-ipc.h index
> > a48bb5240977..1a8e4c1099e3 100644 ---
> > a/include/linux/platform_data/x86/simatic-ipc.h +++
> > b/include/linux/platform_data/x86/simatic-ipc.h @@ -2,7 +2,7 @@
> >  /*
> >   * Siemens SIMATIC IPC drivers
> >   *
> > - * Copyright (c) Siemens AG, 2018-2021
> > + * Copyright (c) Siemens AG, 2018-2023
> >   *
> >   * Authors:
> >   *  Henning Schild <henning.schild@siemens.com>
> > @@ -34,6 +34,7 @@ enum simatic_ipc_station_ids {
> >  	SIMATIC_IPC_IPC227G = 0x00000F01,
> >  	SIMATIC_IPC_IPCBX_39A = 0x00001001,
> >  	SIMATIC_IPC_IPCPX_39A = 0x00001002,
> > +	SIMATIC_IPC_IPCBX_21A = 0x00001101,
> >  };
> >  
> >  static inline u32 simatic_ipc_get_station_id(u8 *data, int
> > max_len)  
>