Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e285a22e-4943-4c9e-50d6-2dcac30703d3@linaro.org>
Date:   Wed, 5 Jul 2023 13:08:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory
 region
Content-Language: en-US
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Komal Bajaj <quic_kbajaj@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230705053914.9759-1-quic_kbajaj@quicinc.com>
 <20230705053914.9759-2-quic_kbajaj@quicinc.com>
 <CAA8EJpo406gV-5H8+y4SJbbRqnWFRo5wrR6a9KJ2arbN61tS2Q@mail.gmail.com>
 <db283531-36a2-0535-4fe2-d1571b3fa8cb@quicinc.com>
 <CAA8EJpotQs_C_b+qvR1gXcasOtcw6SA8hCgJfuHFa7PnvPeobQ@mail.gmail.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <CAA8EJpotQs_C_b+qvR1gXcasOtcw6SA8hCgJfuHFa7PnvPeobQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5.07.2023 11:42, Dmitry Baryshkov wrote:
> On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>>
>>
>>
>> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote:
>>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>>>> Add missing reserved regions as described in QDU1000 memory map.
>>>>
>>>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>>>> ---
>>>>   arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++
>>>>   1 file changed, 26 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>> index 1d22f87fd238..3f5512ec0a90 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>> @@ -448,6 +448,32 @@ &qupv3_id_0 {
>>>>          status = "okay";
>>>>   };
>>>>
>>>> +&reserved_memory{
>>>> +       #address-cells = <2>;
>>>> +       #size-cells = <2>;
>>>> +       ranges;
>>>> +
>>>> +       ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{
>>> no_underscores_in_node_names. Ever.
>>>
>>> Also, if you have checked other platforms, you'd have seen that other
>>> platforms use a much more generic node name for 'memory' nodes (which
>>> you should have used too).
>>
>> These memory nodes are new to QDU platform, so will it be okay if I keep
>> these names without region suffix?
> 
> Just use 'memory@abcd'.
Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml

  Following the generic-names recommended practice, node names should
  reflect the purpose of the node (ie. "framebuffer" or "dma-pool").
  Unit address (@<address>) should be appended to the name if the node
  is a static allocation.

Konrad
> 
>>
>> Thanks
>> Komal
>>
>>>
>>>> +               no-map;
>>>> +               reg = <0x0 0xe0000000 0x0 0x20000000>;
>>>> +       };
>>>> +
>>>> +       harq_buffer_mem:harq_buffer_region@800000000{
>>>> +               no-map;
>>>> +               reg = <0x8 0x0 0x0 0x80000000>;
>>>> +       };
>>>> +
>>>> +       tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{
>>>> +               no-map;
>>>> +               reg = <0x8 0x80000000 0x0 0x50000000>;
>>>> +       };
>>>> +
>>>> +       fapi_buffer_mem:fapi_buffer_region@8d0000000{
>>>> +               no-map;
>>>> +               reg = <0x8 0xd0000000 0x0 0x20000000>;
>>>> +       };
>>>> +};
>>>> +
>>>>   &sdhc {
>>>>          pinctrl-0 = <&sdc_on_state>;
>>>>          pinctrl-1 = <&sdc_off_state>;
>>>> --
>>>> 2.40.1
>>>>
>>>
>>
> 
>