Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     michal.simek@amd.com, Lizhi Hou <lizhi.hou@amd.com>,
        Brian Xu <brian.xu@amd.com>,
        Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
        Vinod Koul <vkoul@kernel.org>,
        dmaengine@vger.kernel.org (open list:XILINX XDMA DRIVER),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/ZYNQ
        ARCHITECTURE), linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return value
Date:   Wed,  5 Jul 2023 19:39:12 +0800
Message-Id: <20230705113912.16247-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lZppXqosjFM0N4SNcILeJ+5zj/mFjSaoxyWjHAojPEHb6/w09SptgowDJ+fo?=
 =?us-ascii?Q?HrbxKYfSVRY6odCFbKOY5pc1+4GQ+xgUKNAixwP1kfikBPmA8t9mz1AGIOB9?=
 =?us-ascii?Q?R8bPCoJ5TIHWzFw8uB4BDERC9u70P2AupecUHWhPqh8+xkDd8BTqEswY5xFv?=
 =?us-ascii?Q?zaTYeLwkTLwyCtCA360Gl2jxFrcTt9Adn2A3g4ftt2WC80f2Etc44L2BjzQA?=
 =?us-ascii?Q?WZeHxmCBD96Jly77Zc95fLULkeySknCDBwNEzO8R9+Xr7ptSzW5JuXyCGSxB?=
 =?us-ascii?Q?+KSO4dp5yn3wPnubFYfNi35OIJ+17BUanXS1E7kMZt9N6uyKV90E+qwivYYL?=
 =?us-ascii?Q?arIw20HgW/Bg6pDpHfcUJ2qB6/sqZl0ZdolFiXzBzSlY6ssIE8TCoh33A9FJ?=
 =?us-ascii?Q?QofGCXTb1t0bRyDyuiXg5x7nHn1kK6PixwAj0+Y2k/0USRP73C4V5h5wkCM3?=
 =?us-ascii?Q?s8Y1cLOhYDVId9yluD1XDqR81rzNHOmO2Pq1syctIPpRaY0u3TWGNewiO3tv?=
 =?us-ascii?Q?Z1i538rDfEZaDHUvtEz5KbzGg++oKRtQLRKAS3vOHserxT2j64QvZCjul3kJ?=
 =?us-ascii?Q?SMD4gcosifEYw3X/d1SqQ7tKAfjVNPJwDXxRxgPE+9xl8Bpkjp0/eNcDXHGe?=
 =?us-ascii?Q?RCQyyjsfZkiEuQDBj5gQgKAtLK1Xo3KTfSEBI9e8LfQjDkYmocEBC87FcCvf?=
 =?us-ascii?Q?8IVohCsORdqClcROpU1noI08+zwY/1NcCA5jsmrNGVqlxOj0Jq+3xnNAzNyc?=
 =?us-ascii?Q?vz5Ez7DlaRTfp0LBZO7/qbxfQ65vNlD8msdl88/K5J6wvXY1smmnZzY82v8m?=
 =?us-ascii?Q?0lmFzOGjrfjdzdxSz3C73Xs2g9GRDI5VsusfGnxzHDL9PBnceZxMuJsKH5nc?=
 =?us-ascii?Q?1Af9QiWk7Asw8G/xPXGKkQlcXfb/JoUdbM+w1j7hjbgL1DAfTvwo4t7/TeG+?=
 =?us-ascii?Q?feJYpnWAX5nKEgw1QWV+mX7ll6rj1nlgOPPsjP1i5OfQIq5h2DezTBlYtEo1?=
 =?us-ascii?Q?nbQnh9aGn4mZXPvvVErxBj7Iclqx+L/IwBXAZ1BF3Jlta2HMSAO35nd8aNw6?=
 =?us-ascii?Q?tf2hEKh+bEKWs+bS+tluzet0Ha4sOWZpgeB0pG+q3t3TpmuDg5H9kDYeou3b?=
 =?us-ascii?Q?yZcyzW2/+tomwm5OzAvLqbGd/yPLcEYSoKZAZPJp6k2TBKlIEhhsN3XNyVr7?=
 =?us-ascii?Q?JzyCb4vDQhfs2jIhVNAHD5s9Q0Y73ezb5XLvVSZW9Qk7a08/rOWsofebC7Jn?=
 =?us-ascii?Q?LvVAHsxkCVLWrTKtpesQFgYs+3BohqFWw8eHrAM/D45wMh5Xk7tujCd7pcZB?=
 =?us-ascii?Q?oflX0Dy89OcYbv0EkTquzSa7JZqIsMw8BFN6rtJQTgk8396uucV42GydnRq0?=
 =?us-ascii?Q?tBxj8PPfxgoU1ocw+Xqh8m5XHxQICqVrPm1r6l8/gOGS7s+QKLwceOgngQsF?=
 =?us-ascii?Q?pGcKPjbu5HPzuQuLG/yJBwo8v5GpoZ7JpBmIGymwX0k9tKdE5czf3Rf/YJs0?=
 =?us-ascii?Q?nN50g4KQ5j/WLM4x7Er6UYxLDTbHPYpsz0iLYHzWhyQ1w6+Eumpmq64LkY24?=
 =?us-ascii?Q?lZQJHpcyx3mreNCI7uEAxNxA8oPaUdRZIzH8Js3F?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26ca1e91-5926-46e9-7df3-08db7d4c7e01
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 11:39:29.0115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ckRm8K87QdUAxREh5AyViPw4U3kz09+3O+OPF6Mzy8bozdN4tvDrk0HXo7hPIh0SiIPWwEKrEJeBXmcrQGVwCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6504
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix: make IS_ERR() judge the devm_ioremap_resource() function return.

Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/dma/xilinx/xdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
index 93ee298d5..ad5ff6335 100644
--- a/drivers/dma/xilinx/xdma.c
+++ b/drivers/dma/xilinx/xdma.c
@@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
 	}
 
 	reg_base = devm_ioremap_resource(&pdev->dev, res);
-	if (!reg_base) {
+	if (IS_ERR(reg_base)) {
 		xdma_err(xdev, "ioremap failed");
 		goto failed;
 	}
-- 
2.39.0