Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 19:38:52 +0800
From:   Pengfei Xu <pengfei.xu@intel.com>
To:     Dmitry Vyukov <dvyukov@google.com>
CC:     <nogikh@google.com>, <linux-kernel@vger.kernel.org>,
        Heng Su <heng.su@intel.com>, <syzkaller@googlegroups.com>,
        <keescook@google.com>, Mehta Sohil <sohil.mehta@intel.com>,
        <kirill.shutemov@linux.intel.com>, <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 1/1] x86/kernel: Increase kcov coverage under
 arch/x86/kernel folder
Message-ID: <ZKVWTL9fMQ++oQJ0@xpf.sh.intel.com>
References: <cover.1688460800.git.pengfei.xu@intel.com>
 <582ab7050597df7a996c11df048f168995b30747.1688460800.git.pengfei.xu@intel.com>
 <CACT4Y+aBNX9U7yeH8jz5y82tV46iChCFXufg92gSXrdRubqJsw@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CACT4Y+aBNX9U7yeH8jz5y82tV46iChCFXufg92gSXrdRubqJsw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ReIYkEBc4jHp6Ch6wBLsqkO3qz8u/LL2lqOZaN1uJ1vV9ez95hvTNTPpEdFp?=
 =?us-ascii?Q?8cV6eL1Nb9enItLQMLAD5R0xTCQtw7G/vv1XJgFjcpmeWZYVVt+biE47+ooR?=
 =?us-ascii?Q?HncPDjQlxVZDjojtPDXV1CXnD+7XTjQKUa/+PVjS4kQzrxriCl5Pw3/s5rWl?=
 =?us-ascii?Q?8+0BnGUJT4H0LoJqTaAHXNGognPy9V9wVCUb3gRsPHzhNJkKYDwBkfU3QoJa?=
 =?us-ascii?Q?9BtFRkY5w9b8fFSVoFfWUKF6tXMpDAPnIIHs05OsB1PDYDY7me280/orffFi?=
 =?us-ascii?Q?6Yz8ZbfmdIdFdjhSUVRr+1cFl9v4w09TF8+Ho59yp2cGwCKfTaxhLuGxYmPs?=
 =?us-ascii?Q?0DmyLJjRrzLPCaRXy+n0ocWfsQVENo8EwmI7EIZpVkgo3oeBAK4fzLlslesZ?=
 =?us-ascii?Q?c9eFhrCRNCiEPuEmblZgwvQ0LXUjvESJBV6PSjXw988DBhkb/6VBtLiy8f0s?=
 =?us-ascii?Q?6L4Pofe5U9qszcrko3OG+Cbdqb/jd2xSAY6RhsfUJlx0VBS1LRXubki1MC1K?=
 =?us-ascii?Q?rsi5xCeeX/XORZeLY4grZsAxvzFb0h1/GLuUO10oM4eAWm0cTRX6UAMPHDbK?=
 =?us-ascii?Q?k8J1ZamzRT5Ri15ffH+Zfv9dhNQSmHjzXWt8ymmgfjOD2kvCtqevJB8z9oNK?=
 =?us-ascii?Q?A1vhzDEDAOcaHjhI3On9W8BgBO73Nq+a55z+boBZFSPMP6PpUaih823CmPwl?=
 =?us-ascii?Q?Cdoz+dwmLcu6oF7r+Jg85IGNcpr43bBFxabwmqg/C7LHrMTwam6TR/AsV4eu?=
 =?us-ascii?Q?7AfSaSkoVa68GllMvRkIzp6Uea+gviRe+ePrUHuH//VH6anjeq3viI9PxTrD?=
 =?us-ascii?Q?WRLGrsm0w50ZvN4qYWG38M8YlJjkk9c+GQEN1gYF4RgDaTBDvNEZuJad5gcE?=
 =?us-ascii?Q?jAC9IjJ9e4oQ4g6EOHtA9nLiWT2uHXgnSNq4OBCziGK+1omsBBGBf02QCcur?=
 =?us-ascii?Q?87kDDFQ5gnncxZPqfuOHJS3CChAdq9GwUV5c+3KWFOh+ffuywAyREHcT4fuD?=
 =?us-ascii?Q?DUgaq3mSEdJQV7FwuqtDRwHcQ+czSrTMdAxGlM02eiLebetzNycoQtkwL3Jt?=
 =?us-ascii?Q?OVENazX9OIueL3uZavizT9NsM8F/zCiVss7qHKaX/jNcS1387g7pYhEYfaES?=
 =?us-ascii?Q?XFqbqt9gu6JU2Kgwg0RFDm1oDsA6LqpUZQOhQ5Vh+9nDqiYPW369BNJ07c+8?=
 =?us-ascii?Q?guDbgvfX7sIufvUcJycwJu4sKsCL6RdjNqDaYX0zTshjoy3VGzbyxtbsH5cm?=
 =?us-ascii?Q?cNR3Tau9XsWMFO/fTXyuHdcrQV8a3w+Z9oNIGEsvEiYXfrg7jd6Q+IeIIAEl?=
 =?us-ascii?Q?NbacSz+QpM80Su6QBVKwt0thFx8MUsEmO/rljPq7qiXSiQMbFY89VEFDnt6l?=
 =?us-ascii?Q?pilsVTv9pK5LFMaVhPCAlKTSqNObgMBWL3CLG0CW9IbOxWP/DaMvxg16E9st?=
 =?us-ascii?Q?Uu1Vh0jlTR2cQf4DVWkJHM1ZwHbaHIw2/5e+rj0+2n7odoL5ZsMOepgs4Ub2?=
 =?us-ascii?Q?GbF5Ux8dZ/dQicixnUff8TfiTmRTf9SCR3VxuqvR5BuFPPYW7RLKVHdSoQJw?=
 =?us-ascii?Q?XZOgR9P3GPSWyMdLiEh8hW9ThSjRcaPeZ52SIyN/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ea26ade-ab71-442e-fa54-08db7d4c1d17
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4839.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 11:36:46.4212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QvE0xVeVy+9bICLlT6xL7ZH3DhUiE8JKEDSABDWgpUrhLU2sB+5ednUkUyVDUc3L1S3Y+QZFhi5GHC9Abeghtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6774
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dmitry,

On 2023-07-05 at 06:28:10 +0200, Dmitry Vyukov wrote:
> On Tue, 4 Jul 2023 at 10:58, Pengfei Xu <pengfei.xu@intel.com> wrote:
> >
> > Currently kcov instrument is disabled for object files under arch/x86/kernel
> > folder.
> > For object files under arch/x86/kernel, actually just disabling the kcov
> > instrument of files:"head32.o or head64.o and sev.o" could achieve
> > successful booting and provide kcov coverage for object files that do not
> > disable kcov instrument.
> > The additional kcov coverage collected from arch/x86/kernel folder helps
> > kernel fuzzing efforts to find bugs.
> >
> > Link to related improvement discussion is below:
> > https://groups.google.com/g/syzkaller/c/Dsl-RYGCqs8/m/x-tfpTyFBAAJ
> > Related ticket is as follow:
> > https://bugzilla.kernel.org/show_bug.cgi?id=198443
> >
> > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>
> 
> Reviewed-and-tested-by: Dmitry Vyukov <dvyukov@google.com>
> 
> I've run a local syzkaller instance with this and I don't see any
> additional kernel bugs caused by this and I see coverage in
> arch/x86/kernel/* now, in particular, dumpstack.c, perf_regs.c,
> signal.c.

Thanks for your tag! Yes, it can cover more code in arch/x86/kernel/.

Best Regards,
Thanks!

> 
> 
> > ---
> >  arch/x86/kernel/Makefile | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> > index 4070a01c11b7..00df34c263cc 100644
> > --- a/arch/x86/kernel/Makefile
> > +++ b/arch/x86/kernel/Makefile
> > @@ -33,11 +33,10 @@ KCSAN_SANITIZE := n
> >  KMSAN_SANITIZE_head$(BITS).o                           := n
> >  KMSAN_SANITIZE_nmi.o                                   := n
> >
> > -# If instrumentation of this dir is enabled, boot hangs during first second.
> > -# Probably could be more selective here, but note that files related to irqs,
> > -# boot, dumpstack/stacktrace, etc are either non-interesting or can lead to
> > -# non-deterministic coverage.
> > -KCOV_INSTRUMENT                := n
> > +# If instrumentation of the following files is enabled, boot hangs during
> > +# first second.
> > +KCOV_INSTRUMENT_head$(BITS).o                          := n
> > +KCOV_INSTRUMENT_sev.o                                  := n
> >
> >  CFLAGS_irq.o := -I $(srctree)/$(src)/../include/asm/trace
> >
> > --
> > 2.31.1
> >