Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        Wang Ming <machel@vivo.com>, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] selftests:bpf:Fix repeated initialization
Date:   Wed,  5 Jul 2023 20:33:57 +0800
Message-Id: <20230705123432.1655-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PRtPWpdqwNthhecCc/YE5as2yQtxORJ9a6QqPjfggA2W1gvmNpCNS8XiPJTn?=
 =?us-ascii?Q?EiwEQ951tIER8Pyfr6slRruRZLrRJ8i02gWA/F9dY1H2KIg2IGhwNqjTTe2B?=
 =?us-ascii?Q?KO/yBHTjPYfIvCrOTaJp30AkS5Ja4//pBSO/n8Q63rwg2gx3i3/y7zpWatYE?=
 =?us-ascii?Q?ejYz8RLX0IU0/Qg6jxy0Mr+en49F0rdHdRbyWF57HAGLg1IjbachKQa58ZPj?=
 =?us-ascii?Q?8dPdULa3OOnMMZmJEBSBt3pZi3fCt5a4ZqEKKY15z/ki0T2NvtRhWX3Dr8o+?=
 =?us-ascii?Q?7zmdPguitME7kxzGU5jXG6ykVPl3/vG9HuUuyKOVG2jPx7COZQ1mQ2yZ7YcL?=
 =?us-ascii?Q?4VVfsFQYxGn0g66mLvNo46lVvkHV+L/effTzywbDQ+2SD6fFRRxLjTmzRogT?=
 =?us-ascii?Q?oiSf8CWdigTxi4vrL0Mn/wPMC1YwgxkV46oNF/tew8QBWf+Hs5Rmtw+Y+Cin?=
 =?us-ascii?Q?T4injlDH5Kd+1n7RHmrB/g66wPYxHasBbxlcJtwKYzscYrqfRB14P1tm1n/o?=
 =?us-ascii?Q?TZvinaPoaKdnBoMrsi7TSKqyRlaZ2G0zfKIAanAfy5EYP4GgDPBe3kMYLJNJ?=
 =?us-ascii?Q?oKleSoOTTv6tHEyVCtPmYaUNm096rp4cirrLjzF+5AIpEuK5qpMbSpK11sV1?=
 =?us-ascii?Q?+IF/tUyI/WwyuKVSzmVBtNtOy1GW/miYqs4duVGsVlHA1WyuexOa/pE8FV36?=
 =?us-ascii?Q?gFaXmX7VMAYEYlhgpcbBd8zYwJJr501tjyZDoiwYECTH9yF2shFQjKRemq3n?=
 =?us-ascii?Q?Grf95ZwXpK9W5sxbYD/Yu2meJaYBGgYD81Rgwl84hWlXFBfGdy8Cx3ZDkeu0?=
 =?us-ascii?Q?k35xZ+WTKh7pnRe4JUQ4GRjrO+YeXYmsgMELXVBiZ8ppco76MqI/+/yq7A5c?=
 =?us-ascii?Q?U+l0Oc85OD7UeLsE5U1SW4O1ExRhsjSZAGQrOQDJ93h9m283z92RZfI4kuA5?=
 =?us-ascii?Q?/DAtnVSfNGzfej65OBPhzSIHTrZaSLT6rTBdU4ltA/MLcMLlcTk7xM+a2YGU?=
 =?us-ascii?Q?mtikbrbMZPK8dkObN5++c6+ZxbiflP6jDoFy4in7LIjtRR1lN7zdRunIH4bS?=
 =?us-ascii?Q?OmBMDxok5EQYWcD76qsNKZLYyXKU/ldUTb4mSajiTHCJ1m/TFXGNCPykkoOu?=
 =?us-ascii?Q?sX6aGXQLjM7pBEozny5TOocpr2WL8ooK4BNr8hd4kiXri1yQUv+MM2hJAuJ3?=
 =?us-ascii?Q?5qaZT1Lie7ba42ncLaCz4mJLszcotBVz89gWfjZ2cm3OIXW8QAcrrrfrK1zi?=
 =?us-ascii?Q?mgII2ZYd8LoxBT9ZeB74ALNT/oIW9Uvmkw1xfhktOlLFFNQ4MfttRcEqTW/f?=
 =?us-ascii?Q?V0mG+bkESZbknXGBuKQ6853o1v2EmWj0VGN2YYVevby6CtzM5OdA7Lp5nrTu?=
 =?us-ascii?Q?KPadBpgnjM0HZ5UjjGvqDEvQPQFTdTNbSUChXgyDZqV1vhplCIIXkFS7a0yk?=
 =?us-ascii?Q?9pMZhZijr6IkPXVjn6JD3+zJsA5ZYA/RM893hiWGHVMRZb+IkMDxdpdY+GmQ?=
 =?us-ascii?Q?nVUWqfHqzwEqwlJFpkabLorY47Yy/HQnNPuvXM+Oolog20M5293sGGQbnERp?=
 =?us-ascii?Q?fmbKuvRRw1viSeuLbDhtdiBVybKZjtbX/BITr3Od?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c769e6f5-d712-444b-d2ca-08db7d544d30
X-MS-Exchange-CrossTenant-AuthSource: PS1PR0601MB3737.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 12:35:23.0769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BCcht/UgTtl5WeORJlKaTRo5/DcknxxseGTbQjawZrC8et4sH1GVNKy4WBnag8nrj4b5op6iYeEewey8U7Lqxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5616
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In use_missing_map function, value is
initialized twice.There is no
connection between the two assignment.
This patch could fix this bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 tools/testing/selftests/bpf/progs/test_log_fixup.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/bpf/progs/test_log_fixup.c b/tools/testing/selftests/bpf/progs/test_log_fixup.c
index 1bd48feaaa42..1c49b2f9be6c 100644
--- a/tools/testing/selftests/bpf/progs/test_log_fixup.c
+++ b/tools/testing/selftests/bpf/progs/test_log_fixup.c
@@ -52,13 +52,9 @@ struct {
 SEC("?raw_tp/sys_enter")
 int use_missing_map(const void *ctx)
 {
-	int zero = 0, *value;
+	int zero = 0;
 
-	value = bpf_map_lookup_elem(&existing_map, &zero);
-
-	value = bpf_map_lookup_elem(&missing_map, &zero);
-
-	return value != NULL;
+	return bpf_map_lookup_elem(&missing_map, &zero) != NULL;
 }
 
 extern int bpf_nonexistent_kfunc(void) __ksym __weak;
-- 
2.25.1