Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Wed, 05 Jul 2023 15:22:01 +0200
From:   Michael Walle <michael@walle.cc>
To:     Mamta Shukla <mamta.shukla@leica-geosystems.com>
Cc:     tudor.ambarus@linaro.org, pratyush@kernel.org,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        bsp-development.geo@leica-geosystems.com,
        Mamta Shukla <mamta.shukla@leica-geosystems.com>
Subject: Re: [PATCH] mtd: micron-st: enable lock/unlock for mt25qu512a
In-Reply-To: <20230705130010.2999839-1-mamta.shukla@leica-geosystems.com>
References: <20230705130010.2999839-1-mamta.shukla@leica-geosystems.com>
Message-ID: <419d80f252f12f091b9c555da0965c84@walle.cc>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am 2023-07-05 15:00, schrieb Mamta Shukla:
> mt25qu512a[1] supports locking/unlocking through BP bits in SR.
> 
> Tested using mtd-utils- flash_lock/flash_unlock for MT25QU512ABB8E12.
> 

> [1] 
> https://media-www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/mt25q/die-rev-b/mt25q_qlkt_u_512_abb_0.pdf?rev=b259aadc3bea49ea8210a41c9ad58211

Link: tag please

> Signed-off-by: Mamta Shukla <mamta.shukla@leica-geosystems.com>
> ---
>  drivers/mtd/spi-nor/micron-st.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/micron-st.c 
> b/drivers/mtd/spi-nor/micron-st.c
> index 4b919756a205..5d1dc8e0bbba 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -218,6 +218,8 @@ static const struct flash_info st_nor_parts[] = {
>  		MFR_FLAGS(USE_FSR)
>  	},
>  	{ "mt25ql512a",  INFO6(0x20ba20, 0x104400, 64 * 1024, 1024)
> +		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_4BIT_BP |
> +		      SPI_NOR_BP3_SR_BIT6)

With the changes above:

Reviewed-by: Michael Walle <michael@walle.cc>

Unrelated to this patch, but could you please dump the SFDP tables,
see [1].

FWIW, I noticed the difference between MT25QU and MT25QL here. But
I don't think we can do anything about it. It is just another example,
that the name is mostly irrelavant/cannot be trusted. Vendors tend to
reuse the id for different (software compatible probably) parts. Maybe
we can get rid of it entirely. Tudor, Pratyush?

-michael

[1] 
https://lore.kernel.org/all/4304e19f3399a0a6e856119d01ccabe0@walle.cc/