Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 15:33:55 +0200
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Ratheesh Kannoth <rkannoth@marvell.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sgoutham@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <sbhatta@marvell.com>, <gakula@marvell.com>, <schalla@marvell.com>,
        <hkelam@marvell.com>
Subject: Re: [PATCH net] octeontx2-af: Promisc enable/disable through mbox
Message-ID: <ZKVxQ2HtG+GtumCj@localhost.localdomain>
References: <20230705033813.2744357-1-rkannoth@marvell.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230705033813.2744357-1-rkannoth@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U/dR+HeRKIlusAMdDeQMavYBviEQAqS/BqOm8ESfG9baHIrasgnz7vgdhasu?=
 =?us-ascii?Q?Z2IPQ7yD5Uh1dwU6Kk/atYWxPcUkwju4gWpOOnT/fsRYRTZEs7NoqMscs5YN?=
 =?us-ascii?Q?SJ2aDpp8AdmW1yoOkYrsibVrDCbk3kPqJufXve4WZcd/VSjY7c4GxvOvotqf?=
 =?us-ascii?Q?TGqS6AX5d/8NCTbje59kfpicd/skT8p1aYp/DvpLxh32Trb8ReN/UbSpD+D4?=
 =?us-ascii?Q?NQ6wZXUUYKW46tSMIcn+S4NvlzPqnJBAyYowBlHt+pitQsUAUwrBS0R7rRDz?=
 =?us-ascii?Q?mdRS1QWtFu6SwEzI3Nk6mfdpRRWD0GVf9RvCZ9m3LdN/6l0mmUcR6cogsXJe?=
 =?us-ascii?Q?4NRWHwfBQis/j+JhAGBrkz5E+lWIcAkl649qNVR1AyzTxe67Rg77Qb3E7NPc?=
 =?us-ascii?Q?fRafRnRtAIAYhcATtkrV+GEGIJg+P3nTsUPCc2vhGXVt3ftEC8dNAOSbtfed?=
 =?us-ascii?Q?jHqMlDeqXjxAgd5OAoMEGDvaetbDTZq6fEdodxVGd9OCeVJjijubx65cpyrV?=
 =?us-ascii?Q?yFUOl2lo1m/YaYPuIoqQDothkT5TNnAuH4Ei61/mQ1aGQ3ZDtIxYUw23e/tt?=
 =?us-ascii?Q?KWHyYYHcYTz8NsGa1W1iCPNj6BctzUpsUrDgciwGLKTgNcIEcrj334aUFqWl?=
 =?us-ascii?Q?RebxbwspP1jDGzqlnpzqnDQP8u99Ofzl5tVlMpc7G03QWvPVnVxYyRoiGbUe?=
 =?us-ascii?Q?JzkwrwNUGR7kO5syT27EE5yQ06uvwyxGlBDaa274bCM4dVpLqbXTZ/Zn2eDU?=
 =?us-ascii?Q?9PJl6sd1Qd/QXr3JEGp8IvCnRxSDDO9oPFAgTZn7OEzquGT/z6BAPeVcXW23?=
 =?us-ascii?Q?vuh13yBNYIkallNW5Qn9Ij0NchBFCc/vccysRpPoPiQsjL5nV65Z1yKrcGZN?=
 =?us-ascii?Q?D4ZLvE3Rzgo62SCvgMloVBRLSk0TyIQ0NzXSICymATA++UQOFXmR5FjnAQi4?=
 =?us-ascii?Q?FxJYCsyoFJ9eT7Aqu0dMOA6K5aK1JB1hiO6lQqRIcD7VM0lZGBpbDA1ifsmL?=
 =?us-ascii?Q?OI6jKlKVzidhVLTjQO7yMYogI6maC2uOoTAPIkmh2j8WUtpFyplTJJzFl+5i?=
 =?us-ascii?Q?byBLuT1Qux8jvz7g0VWGx9pr5Lv5nSQbdxX8I6rZ0/4gIKFYMq0AvSdhMyX5?=
 =?us-ascii?Q?sz+hzzQEfu8WDkrJxzB6Wj7Djmi+E3DZQW9jkpcgYydZoVHB0WJrOD73ozUB?=
 =?us-ascii?Q?6KfRt8G+oLZHtnRC5gDayut2kKzHdeaejCM8vW0XgvzO+HC24rDUoWhv2DqI?=
 =?us-ascii?Q?MIEjmJZaLyGfvjwtRwczEKpn8DDVBfPmVUgh3s9p0W61hOZlGbidTRsDxe71?=
 =?us-ascii?Q?/EF0CZT5I8iQ0beimhdncMlS1DV0l5ksM8iaILI/Til3QPwGep40odo9CLBc?=
 =?us-ascii?Q?sPZ+KClipi1hDVMl8zf0hgkHkAuZ+abWF4kb5IHdN7bvnx+KXKEMmihyjXv0?=
 =?us-ascii?Q?m1bKXf+4xJgYiXH4aYAh9iQ804su9faJCQQIGQ14Y1fnnBmoFLY/2CcwyI1p?=
 =?us-ascii?Q?ixoAd+4qxdH+IUHVZwNzbhFX/0QQy+5Y/IfD4Qmps0uSeXBonL6MGI2ND0hp?=
 =?us-ascii?Q?dXxPCuTsVUoavrZKIZLKhzmZkU1rjpzS5WRjcbNnahEOdRfihYoD0puNNq4i?=
 =?us-ascii?Q?WQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 07c5e601-86e7-4a4b-b48b-08db7d5c81fa
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 13:34:07.6130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bMTbLnhAwjatxlzoluUFxffrEFxuVbCcZulghmJlONUZA/xbFdGtqmJRx9lYsVrJmJgzrOTxaMui6fmDvEl1Bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7268
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 05, 2023 at 09:08:13AM +0530, Ratheesh Kannoth wrote:
> In Legacy silicon, promisc mode is only modified
> through CGX mbox messages. In CN10KB silicon, it modified
> from CGX mbox and NIX. This breaks legacy application
> behaviour. Fix this by removing call from NIX.
> 
> Fixes: d6c9784baf59 ("octeontx2-af: Invoke exact match functions if supported")
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>

Please follow the Patchwork report.
There are several lines exceeding 80 characters.

Thanks,
Michal

> @@ -1177,13 +1179,16 @@ static u16 __rvu_npc_exact_cmd_rules_cnt_update(struct rvu *rvu, int drop_mcam_i
>  
>  	*enable_or_disable_cam = false;
>  
> -	/* If all rules are deleted, disable cam */
> +	if (promisc)
> +		goto done;
> +
> +	/* If all rules are deleted and not already in promisc mode; disable cam */

Line length above 80 characters.

>  	if (!*cnt && val < 0) {
>  		*enable_or_disable_cam = true;
>  		goto done;
>  	}
>  
> -	/* If rule got added, enable cam */
> +	/* If rule got added and not already in promisc mode; enable cam */
>  	if (!old_cnt && val > 0) {
>  		*enable_or_disable_cam = true;
>  		goto done;
> @@ -1462,6 +1467,11 @@ int rvu_npc_exact_promisc_disable(struct rvu *rvu, u16 pcifunc)
>  	*promisc = false;
>  	mutex_unlock(&table->lock);
>  
> +	/* Enable drop rule */
> +	rvu_npc_enable_mcam_by_entry_index(rvu, drop_mcam_idx, NIX_INTF_RX, true);

Line length above 80 characters.

> +
> +	dev_dbg(rvu->dev, "%s: disabled  promisc mode (cgx=%d lmac=%d)\n",
> +		__func__, cgx_id, lmac_id);
>  	return 0;
>  }
>  
> @@ -1503,6 +1513,11 @@ int rvu_npc_exact_promisc_enable(struct rvu *rvu, u16 pcifunc)
>  	*promisc = true;
>  	mutex_unlock(&table->lock);
>  
> +	/*  disable drop rule */
> +	rvu_npc_enable_mcam_by_entry_index(rvu, drop_mcam_idx, NIX_INTF_RX, false);

Line length above 80 characters.