Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] media:Fix repeated initialization
Date:   Wed,  5 Jul 2023 22:21:31 +0800
Message-Id: <20230705142142.3526-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MFn0oBIIkv5/oRFTxlN+04QHfTqWx3744Nt70vCDSoJ1HOXvQFubAxSOgK4D?=
 =?us-ascii?Q?VBki54K4exrr3pcWJxS68gTQME6I1Ed/fynWvxX2iaOcYR5jIzmp/MI1T28P?=
 =?us-ascii?Q?KqRZRhYT/tuiIMWVh0IxCD34CvN+iy3dbT0WMgBhrq43W08Qr/PS1NjPA7Hk?=
 =?us-ascii?Q?kYbwcUizpuE40br9WAdodbeoEq8ZoCz062LR4UQ80v8LLFt5HfwBBU7/WEEs?=
 =?us-ascii?Q?xHak4F3nw5iZjTXiPEroG6iRiN+/b9zJjchH8oRAAzzmqXit7vkBh984wrv9?=
 =?us-ascii?Q?tVuKigM7zfJWhSiMdCMbiMyuTikfQZWYHbLKrMlGOSVjve2F9o6MmM/89D93?=
 =?us-ascii?Q?i/msCPw9X9ev3Uu8SjIkDxqmB0RTGgRAHXapOcchOhwzqNz40mzJgCnjixhe?=
 =?us-ascii?Q?oI/loVzeLWhwUyWNE7702sKm1bLNclBMY6lqOffcEUElETEa+dSYAX2+VTbq?=
 =?us-ascii?Q?j+u4f+eg87LWEPVu6Y2wnM+UXo9+7j07h38D1Igk/bxmAI98/zuNRcWDaTuY?=
 =?us-ascii?Q?ZeWVt//twF3bu5RIMmpUzN7UZr7izKy2WAz2P9ZXNn8hYz4D5iMELLNOBRjf?=
 =?us-ascii?Q?aP/INorrMTQzmcEi9is7nbSP5j1yqX/x4DXxcvHO0wK0c6eD3aPE+HuDEAod?=
 =?us-ascii?Q?+5EEsKgTPcZgU6DhiU5j1oJzC/Z4LTgc6ZysRnTWvAwj6JKCluKy/jjVZc+O?=
 =?us-ascii?Q?fHhOhKlyoWAE+OL6isNxUeJAqnZDqVNRQd/Obwx7GzJypeezuaHzfIO2SQOh?=
 =?us-ascii?Q?a0cNVGTnkZyPphw2mfoSMvit6hrEQ3Ku/14V0/43VDeTBo3h1LG1i8jBtIFh?=
 =?us-ascii?Q?CKR+5rIFAqxg51YFrdpQIBlsbYdsM4+FVYvc6pTl1By85SM49il7Yx1fpqUm?=
 =?us-ascii?Q?ALTn/kT6JXFXJV6ntCh2Ngk4LJFbFMBmObTk2WLEJ+Jln6Z/YC3gmeLII+j0?=
 =?us-ascii?Q?gh5aV4MKLlytVvc1dTcIL63kcbtPufixLKN9bJxKCxjnmo/u0S9jPKQe3wEA?=
 =?us-ascii?Q?JUJTqHPukqFhvsHsgDXOzpaqw8FANLQBuI/kdLT6Qrvo5+XO+I+pKaPk7UOq?=
 =?us-ascii?Q?2FQg9eaYMaLvXUdLeaheIM+Fb5UKM91UExOagLOak3s8eyq5xk6c8Lf0NSit?=
 =?us-ascii?Q?KuP37sti+DIHdEEGKelv64FK/LoxJ2XMUmZIVnN8tfBcw5Ny398DYDKIZc8H?=
 =?us-ascii?Q?kUJKLOkvp3RxKYz7ZSlAC91u8S8D6ZSgHWsBfandN+0I46RBX1xcuA6BkGrB?=
 =?us-ascii?Q?4uaaqY4ssAhHsfhYt3kcOwXe+O/f2abQFSDWT9VlX+mDeXE8t7jfVwOezlrD?=
 =?us-ascii?Q?d0kG3SnhtjfgYk8cUJ9bVbBdpkfH9NPoTThUOM4KgmyZ9ujqqvnejRergasj?=
 =?us-ascii?Q?Huhi4MLql6qHX0cu3Wxeib/F14agt+L/em78Ohrn5z6X5ICVCPPcvlF/39An?=
 =?us-ascii?Q?07MEuuPc1v75+/b0W3JiGlmZQMs5E6Una4DZy7Mcesz6N+DU5/T5LNxZYpZ2?=
 =?us-ascii?Q?NIYeTfaDNH/IkCLtEeKDJvgXAA3hDilpb0FRuB1u9y7RRrW4JaPStb+ahqlQ?=
 =?us-ascii?Q?UzjRbHsaqDokAbzoECt78+VitfTsiPgpo+yNcxaz?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8838d06c-a76d-47f1-acf9-08db7d636a50
X-MS-Exchange-CrossTenant-AuthSource: PS1PR0601MB3737.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 14:23:34.3661
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H/g7SzJISPcwvXF+duNxTPQPdf4jXwb/mn38Edkm8KLI7atB0SZZHi55G6Qq5cEHrDTXqwk5nIcQGrWTC7lzQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4335
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If the first report returns NULL,
there is no need to execute the
fimc_capture_try_format() function
again.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 .../media/platform/samsung/exynos4-is/fimc-capture.c   | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-capture.c b/drivers/media/platform/samsung/exynos4-is/fimc-capture.c
index a0d43bf892e6..5ce2f04afa1e 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-capture.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-capture.c
@@ -825,10 +825,12 @@ static int fimc_pipeline_try_format(struct fimc_ctx *ctx,
 		tfmt->height = mf->height;
 		ffmt = fimc_capture_try_format(ctx, &tfmt->width, &tfmt->height,
 					NULL, &fcc, FIMC_SD_PAD_SINK_CAM);
-		ffmt = fimc_capture_try_format(ctx, &tfmt->width, &tfmt->height,
-					NULL, &fcc, FIMC_SD_PAD_SOURCE);
-		if (ffmt && ffmt->mbus_code)
-			mf->code = ffmt->mbus_code;
+		if (ffmt) {
+			ffmt = fimc_capture_try_format(ctx, &tfmt->width, &tfmt->height,
+				NULL, &fcc, FIMC_SD_PAD_SOURCE);
+			if (ffmt && ffmt->mbus_code)
+				mf->code = ffmt->mbus_code;
+		}
 		if (mf->width != tfmt->width || mf->height != tfmt->height)
 			continue;
 		tfmt->code = mf->code;
-- 
2.25.1