Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ecd0aa48-90a4-50cb-7a4e-b7a6419576ce@gmail.com>
Date:   Wed, 5 Jul 2023 22:43:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH V2 1/9] x86/hyperv: Add sev-snp enlightened guest static
 key
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
        "arnd@arndb.de" <arnd@arndb.de>
Cc:     Tianyu Lan <Tianyu.Lan@microsoft.com>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>
References: <20230627032248.2170007-1-ltykernel@gmail.com>
 <20230627032248.2170007-2-ltykernel@gmail.com>
 <BYAPR21MB1688570E8D0D0C49B68DD548D72EA@BYAPR21MB1688.namprd21.prod.outlook.com>
From:   Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <BYAPR21MB1688570E8D0D0C49B68DD548D72EA@BYAPR21MB1688.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/4/2023 10:17 PM, Michael Kelley (LINUX) wrote:
> From: Tianyu Lan <ltykernel@gmail.com> Sent: Monday, June 26, 2023 8:23 PM
>>
>> Introduce static key isolation_type_en_snp for enlightened
>> sev-snp guest check.
>>
>> Signed-off-by: Tianyu Lan <tiala@microsoft.com>
>> ---
>>   arch/x86/hyperv/ivm.c           | 11 +++++++++++
>>   arch/x86/include/asm/mshyperv.h |  3 +++
>>   arch/x86/kernel/cpu/mshyperv.c  |  9 +++++++--
>>   drivers/hv/hv_common.c          |  6 ++++++
>>   include/asm-generic/mshyperv.h  | 12 +++++++++---
>>   5 files changed, 36 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
>> index cc92388b7a99..5d3ee3124e00 100644
>> --- a/arch/x86/hyperv/ivm.c
>> +++ b/arch/x86/hyperv/ivm.c
>> @@ -409,3 +409,14 @@ bool hv_isolation_type_snp(void)
>>   {
>>   	return static_branch_unlikely(&isolation_type_snp);
>>   }
>> +
>> +DEFINE_STATIC_KEY_FALSE(isolation_type_en_snp);
>> +/*
>> + * hv_isolation_type_en_snp - Check system runs in the AMD SEV-SNP based
>> + * isolation enlightened VM.
>> + */
>> +bool hv_isolation_type_en_snp(void)
>> +{
>> +	return static_branch_unlikely(&isolation_type_en_snp);
>> +}
>> +
> 
> Vitaly had suggested some renaming of this and related variables and
> functions, which you had agreed to do.  But I don't see that renaming
> reflected in this patch or throughout the full patch set.
> 

Hi Michael:
	Thanks for your review. I am preparing a separating patchset to rework 
hv_isolation_type_en_snp() and hv_isolation_type_snp() according to 
Vitaly suggestion because it will touch more files and not affect 
SEV-SNP function.

Thanks.