Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Sunil Goutham <sgoutham@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH net v2] net:thunderx:Fix resource leaks in device_for_each_child_node() loops
Date:   Wed,  5 Jul 2023 22:34:56 +0800
Message-Id: <20230705143507.4120-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/YriYSgCxkO8upNSU8q6n0e48Irng8SvFGHz7TIPGEcIL2ufhsHp5ch1Mjrj?=
 =?us-ascii?Q?l0N80/aGdSr0gAVJ69FXW+bOX4R4JVhyxWdsmXJ3yIwWuzDETgMmaN/v/BBu?=
 =?us-ascii?Q?toPwd+RpFfVMWmnTLRFhtironl/XZgqozKyLt5bcWR7XrVbMZ71iQ8TmHr0c?=
 =?us-ascii?Q?aqNpURfSWDjWnNWUdyQtDcsl71RNlO3dNY18IQPiCttdBH84+Cth4VjryvKk?=
 =?us-ascii?Q?iXj0iX/DgaC4JjkvKar160EmOIh+XNI+ZQjC1EreR9vJrvW1rAwRX+QODBzC?=
 =?us-ascii?Q?/UlBXbh9VC6vqek+HtGkqVSeBwPDeY78zFelm/e5JPlW5anlHHphs9U9Zgm1?=
 =?us-ascii?Q?dv9yNFZdbw6tytXUMeU2Axj49biQ+scZXE+y93DODRhYuGAbq8OS33kLroF0?=
 =?us-ascii?Q?60gH2kiCl0bqFpCyRoAuaYfzgQ12vGR1f0JRjnN76mDeY9JKtoD5069/SrIr?=
 =?us-ascii?Q?JMLDMDP8Yu5UtFJGd/+Wly4AJ2/rhP6NXJufacivRV1lB4bPtBZT23mTlK6q?=
 =?us-ascii?Q?Kf23piPnotlE3SFbrbem7/cPKnwLGd4yge5KYt3rHSpwIZJkbMt2OVQA+eU3?=
 =?us-ascii?Q?BG+9NqOjuSlC+a88snTXLTdQsrnfFN+LJ5YPJ7K8oVRiurNkhNXPV5Tt+E0u?=
 =?us-ascii?Q?zz9yQ3PhPV/R7HR/jrYG559pOANxUwtPXS90jia7P2vcMO03EyThISe6k2Jb?=
 =?us-ascii?Q?3qLWPO7S9Pl+QvTsKzX/cS59bow1iGMpUiMxUiBTNw2ni4+ikSZebj20gKWy?=
 =?us-ascii?Q?wNKX3P5+JAHR2yLWyD2ZSGECuxy/rRoOhZcZ3PLw6ua1m5VvnXfW4dl6IobW?=
 =?us-ascii?Q?1Vp4iBitFXnPY/28aG+++EK9zh+NCiguz8oeAJzbQScmqgeSIE8/NKRG5Gnv?=
 =?us-ascii?Q?xNEmIGw+wkQnGOp71y3V07WwRaqX20Z36UPr9P0QSBnCnWZwbnl6npx7bKrm?=
 =?us-ascii?Q?KbiGMim0oJdycfw3y3cftSPoBMiVbnrxAmj2OSBTYCbx1jfoN2ut9yCq9z+i?=
 =?us-ascii?Q?7ONy4YXF5vEcz80BgA3BDn3sG2pKESQLu8tUV48j/LKIJfJEhxSCJhslaOoL?=
 =?us-ascii?Q?+29OhG3dBeUdCGDA1bKTc0/iPbdtU+oRhZkWFn8CuCYSnXeLzDrivBMs9XH+?=
 =?us-ascii?Q?LlETX4xKGF8O056zmrKeTFD7wzsx4pGTBIa+3zOePrGo4xWo8DbvXNlAd+Qu?=
 =?us-ascii?Q?BrsqZD3avqicyeeH8jLmt8fMuCceIg0Lq/G9tviOQgOBwKTTOrheh+NMFfKQ?=
 =?us-ascii?Q?E1lpr8qX4JYJBGu7L/OZoHa+LLv0uB6SUV1A1LPl1QS2ZcSYhWkyDe9t9leW?=
 =?us-ascii?Q?OeNd81L4X5BfewNqY26wsGhbf6wiV5MVKgPJVt+RLCtW40CTG5mxnmWIQc/4?=
 =?us-ascii?Q?NPOQUj+onCq4mbiK24jmRbhpY1zu1XLfGtz7UrVBFnCamiVCjqGPXVKNyiVS?=
 =?us-ascii?Q?hWnMa2xtcXyEt9Vq5QlaOv3Wygpic+pzCg3iaQTCipMyaAxt3ZP5KNN3m9F+?=
 =?us-ascii?Q?cU7WF2653DQxaYdNoC4m9j4YGJ/f8MOPJ/sVOX3aEBAZuDP7Jeq97DcvE2D9?=
 =?us-ascii?Q?w3aBhbqGb5VGvr2YC6SQZmwsGVFKcBCCMC90o3d/?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22d67199-ca64-4752-65c0-08db7d650e72
X-MS-Exchange-CrossTenant-AuthSource: PS1PR0601MB3737.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 14:35:19.2520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nZz3RPWUwLtvslYw6mjSKaPRvDcdmb+7jjDF0qjyQy60N9s57Rk+U/P0NbeATZf3NmdD6E1LCGdUZJG7a9iFBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6583
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The device_for_each_child_node() loop in
bgx_init_of_phy() function should have
wnode_handle_put() before break
which could avoid resource leaks.
This patch could fix this bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index a317feb8decb..dad32d36a015 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1478,8 +1478,10 @@ static int bgx_init_of_phy(struct bgx *bgx)
 		 * cannot handle it, so exit the loop.
 		 */
 		node = to_of_node(fwn);
-		if (!node)
+		if (!node) {
+			fwnode_handle_put(fwn);
 			break;
+		}
 
 		of_get_mac_address(node, bgx->lmac[lmac].mac);
 
@@ -1503,6 +1505,7 @@ static int bgx_init_of_phy(struct bgx *bgx)
 		lmac++;
 		if (lmac == bgx->max_lmac) {
 			of_node_put(node);
+			fwnode_handle_put(fwn);
 			break;
 		}
 	}
-- 
2.25.1