Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e816aa75-4588-dae4-2d01-6f5ba9d4a4f3@intel.com>
Date:   Wed, 5 Jul 2023 07:53:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.12.0
Subject: Re: [PATCH] dmaengine:idxd: Use local64_try_cmpxchg in
 perfmon_pmu_event_update
To:     Uros Bizjak <ubizjak@gmail.com>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>,
        "Zanussi, Tom" <tom.zanussi@intel.com>
References: <20230703145346.5206-1-ubizjak@gmail.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230703145346.5206-1-ubizjak@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHRIa2pKMmd0WGVKUUhZd0RnYkNBelVhNFd1bTM4RjFLeGtCUmV5MzJhbExz?=
 =?utf-8?B?UDFLVkYxTWYxVmJSeGV5dDFDVXVQWmdUbHYvTWQvcit2aVdEVXJyTFZvUmRh?=
 =?utf-8?B?RVVsdnRWZzRPYVJkWGxTNENzSXBSL09lR2NmdmpoNXdDNFFMdlJkU0dsK2Ns?=
 =?utf-8?B?eURodlRKYUlvQXRsUzMvY2x2VUpqUFRJc2czM2hSd3NNc2xiNUtEd3R5Qmdw?=
 =?utf-8?B?OXMzbkJ4M09ITmtNa05sVzhzUUJteHZ1eGtDa0t3OVZtVEJ3NytrT3RsMk1i?=
 =?utf-8?B?S254ZFE3dVNBVW9kaXR5RWhJMkxpSWoyNlU4VERRV1FFU254SHkyMjk0YzdY?=
 =?utf-8?B?Lzh1L2JrM0lmSndYZmdPa1BlQnJJUmVKaFBuN1pHWmxWcFU3SGpxOWhqREU4?=
 =?utf-8?B?L1VWbGx0Zi9JdGdvaTFhYkxuQjJObCszS0w4azUwMTN0THlZamI4RVRHazVx?=
 =?utf-8?B?VTN4RFRKUENpU0xoWFh2Qy9xOXovVUFZQ3RBbkNkQUVLS2FnMXQyNFhHOVho?=
 =?utf-8?B?RGNMVmxqQ3RBSkJXUW85YXNuZmFSMEtORGdkMUI2NUI3bjNOSk9KN0JBK1Bh?=
 =?utf-8?B?ZG93OWFtZksxN1lhU3cyamxIdXg5UW1oaFB0MzBib2c2SlE2c1ViRVdIWElY?=
 =?utf-8?B?b1hqRmQ3c25jbi9SSXlMQXVNWmt2eE9uUFJyVXhZcjJKTEphRm8wQ2FYVnk3?=
 =?utf-8?B?OUVEd0xLKzd6Z1NHa1hvQkc1ZGJjQy9jemdGTnpWV1RXczVJOHR5U3pTc0xX?=
 =?utf-8?B?eHpEbkMvUEs3Y08yMk05VW8reitYY1g5ZTNyT1BsZ2JWcTBYR3E5VlFxUW5Q?=
 =?utf-8?B?azVTSkU1VzRNT0FsMzdjMGo5THNSU3EweVN5TG5PZVBkeTlodS9ZV3lOUUg3?=
 =?utf-8?B?UVFDUFFqSnVZc09aOU9lVmpSWW44aFdYLzhSTWdySVFHS0VEZ3R3VEcyTFNi?=
 =?utf-8?B?aEh2WWVpckkya2pvMHRpWTFTZnpMVWV3OE0xUVlBUGhkaEUxZVRWc2hNME9r?=
 =?utf-8?B?SWZDdGl3ZEVzR3B3NENpc2MwNEFGT2xRUGJyWlB0UWJSWGx6Z0VGL3lDL0d5?=
 =?utf-8?B?MXcrY1pRTWNrK2MzdGx4OWM0ZVcveCtHdnZDcGYrOFV0Q25aNklSS3hBM3Aw?=
 =?utf-8?B?bnExUFJ2TUluUEtHUTJUZG9qbmJIcnhJV3BWRll1ZzJTZERScFlpUldQWTc5?=
 =?utf-8?B?RXVQTnV5TFN4RENZS1JuTVY3NlpLUUw1YzB1bVhyNjh5eG5mV3NzNWlUMDI5?=
 =?utf-8?B?d0FGMW1aQXhRbk9EWXZaTUdwYWo3b3cyOGcxUStFdGxtdWhnZ1daSHhIZUw3?=
 =?utf-8?B?N3Y0N1gzQ3lvZkpYU0p3YnRKcE5zUmdnOWQydHM3cnJiaTNjUm5VbHNTc28y?=
 =?utf-8?B?Tll3bXBvRVNma3hlRHY2emI0Nk5yUjJaYyt2T3pGOFBLZWVCK0diMU5PU3dp?=
 =?utf-8?B?SVRBV1U4RG8wN3p3cnI1cnlWVnE0RWpJOXhJZnRyQkVQZlA4WHE1Mk1qckRI?=
 =?utf-8?B?VFhLWXp1SFBsSVZ1Smx5RGVIR2tsVlI0NkxyZW9wZ2ZCK3NVQnFTRlcvMjRJ?=
 =?utf-8?B?TXd2RmI0cmZSc29CejNoRWZLNzh0UDlPaVdic21wb1FkUlh5SzRuanVWa0xY?=
 =?utf-8?B?Y1B3SXVCcU93czNkRVA3VWIxeDBZZTc3dGpRT2ZadmxIWGdoQ3BJNTBHNWRO?=
 =?utf-8?B?eDlXckZEN20zTFZ5K2wwQ1FjYUtPNUU0SWFsbFpZUXZ2czZ4WGVtS1gvTUF2?=
 =?utf-8?B?SjRYK2RDNWZYNGRnc085UTY4NmcxTW5weXUwUUtvVTNBbGlRa0pNY0s0NzNE?=
 =?utf-8?B?YTYvSS8xbStvV1V2dTNPMDc0MC83NUxaQzgyOFExNm9KWmc5V2FtczI3ZlRx?=
 =?utf-8?B?SEFteElreVdHcjZqMFRUckR0dTFKRnR3N1dCbDYza0F5ZFN5MlpYNURDSTR2?=
 =?utf-8?B?WlpiTzlIRVRtWHNvVkFCQThLSnBsUk94ZnY2eDNzTUdNdE1NdDZyV0NydjJS?=
 =?utf-8?B?R3J2b09iMHI4SHVEQ1FpSFRsZXo0NFJZSmc0MTgwWlk4VEZhT1JwWVVEbTAy?=
 =?utf-8?B?RUVRQzAzMnhaWXdxbkhuNzVTTUx0bXdQd1ZSTWR3RGljSmJDQ0ZRNUExUlhS?=
 =?utf-8?Q?vL537DWYGk30lW70Kel+cbOOo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7289277d-c584-4f5e-355a-08db7d6793b3
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 14:53:21.8626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: opl/Hv8SOheLGSnu4LHKsifjlkCXRdewfeIzRIHtJhrfOQC7uMAVZUWOIkefLr0zaCeObLuE6rCm5s64rCEeZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8405
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/3/23 07:52, Uros Bizjak wrote:
> Use local64_try_cmpxchg instead of local64_cmpxchg (*ptr, old, new) == old
> in perfmon_pmu_event_update.  x86 CMPXCHG instruction returns success in
> ZF flag, so this change saves a compare after cmpxchg (and related move
> instruction in front of cmpxchg).
> 
> Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
> fails. There is no need to re-read the value in the loop.
> 
> No functional change intended.
> 
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>


Cc: Tom Zanussi

Tom do you mind review this patch? Thanks!

> ---
>   drivers/dma/idxd/perfmon.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
> index d73004f47cf4..fdda6d604262 100644
> --- a/drivers/dma/idxd/perfmon.c
> +++ b/drivers/dma/idxd/perfmon.c
> @@ -245,12 +245,11 @@ static void perfmon_pmu_event_update(struct perf_event *event)
>   	int shift = 64 - idxd->idxd_pmu->counter_width;
>   	struct hw_perf_event *hwc = &event->hw;
>   
> +	prev_raw_count = local64_read(&hwc->prev_count);
>   	do {
> -		prev_raw_count = local64_read(&hwc->prev_count);
>   		new_raw_count = perfmon_pmu_read_counter(event);
> -	} while (local64_cmpxchg(&hwc->prev_count, prev_raw_count,
> -			new_raw_count) != prev_raw_count);
> -
> +	} while (!local64_try_cmpxchg(&hwc->prev_count,
> +				      &prev_raw_count, new_raw_count));
>   	n = (new_raw_count << shift);
>   	p = (prev_raw_count << shift);
>