Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 09:52:35 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     "Yin, Fengwei" <fengwei.yin@intel.com>, willy@infradead.org
Cc:     akpm@linux-foundation.org, willy@infradead.org,
        ackerleytng@google.com, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        oliver.sang@intel.com
Subject: Re: [PATCH v2] readahead: Correct the start and size in
 ondemand_readahead()
Message-ID: <20230705165235.GA6575@monkey>
References: <20230628044303.1412624-1-fengwei.yin@intel.com>
 <20230703184928.GB4378@monkey>
 <d6957a20-db31-d6ac-8822-003bdb9cd747@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d6957a20-db31-d6ac-8822-003bdb9cd747@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bh6i4TO91Tw8vbdPyqlTi2i59jlXjP6aH7MOfXZV4ICmWS5OkvnL8W5AdQ2a?=
 =?us-ascii?Q?cnGsiYn04CaCENz+SxRO760RXH5WNt8u5Tk2/d2cQfTk68XAm/Fwfzx5v/A/?=
 =?us-ascii?Q?hxvu/RuF2vLlD6mTPuXEa+F9WEohM2rac1Xluz9aYyNTJcXlpTuqn0BYln4E?=
 =?us-ascii?Q?rRcecLuDoLeDuKWHh/R58HFh1bv7Xmm563XPWfurzNUeKiCvjAFhgmOAH2y2?=
 =?us-ascii?Q?7279ebRwg/s9JiCS8wFrAidkAxhyYMjJUzUwXzwU9YQjA20IAiyyqzwH3l4t?=
 =?us-ascii?Q?oSwsHJ4W2xyNzF+vsJfdpJg6T/a8LNTPJUFqSJqMgWvLYtel3KPM3j0f6Z31?=
 =?us-ascii?Q?6BHPJA+9qfdBmlX6C3NB9ZX2xhhaZHjDDW4Wzm49RR7symZZjFBlJUvYCrNw?=
 =?us-ascii?Q?gqxyUEZ/sJdfPyU2N5HuAy7G/OGC0UfHPkJuLBDCPgpL8Vhk0NREqpSmdPSP?=
 =?us-ascii?Q?NtT7XphCbku7FsqpTowiyMseFuCswo78dQw/5Npx/RPcDj0Fg+kmS5uaC244?=
 =?us-ascii?Q?n8KI7XUcDdZkrRYi+hX5byVb5DQw489VREg2rASdsr+Tcmj8dmXPDEUCgxso?=
 =?us-ascii?Q?SFZDW2QK1T7VExEvPJzY8K7T9FXLLFDUIZA/4KPukdLd4YwOGzg1VznjpQa4?=
 =?us-ascii?Q?eyLu4/08hufkFG+4BGJjCCeBByEmWRc7tvdl65EpsjM78FiAyUylWUDGZZpw?=
 =?us-ascii?Q?nQyM3ulWCLodLs9Uk14Awv1Z5d0fJC5mLAKf0mbuCg4wRQYhta+RDAf0ndHN?=
 =?us-ascii?Q?ZnDIIlQ6VmMDvkb3Y/D+rYgSPayAICq7pUP/Y3+4Enbo06mf8DoM+4m8ayKa?=
 =?us-ascii?Q?rBuhyjMAcRpwLYbEIXmH73Qxf8wF/qJD6/ImWI37x0lNevSXmTMAnoYPJv0b?=
 =?us-ascii?Q?vnYayoWTksG4IxE2t2D0ZRaD9oqnsLh+XfOsUvtOs35Jar0MtavOP6ZHNL9R?=
 =?us-ascii?Q?HzAnSRYMjfK71B3lrxmRdMStmBf+o1Jm1BKOcTng95KEoaAISD1uCKNrURgU?=
 =?us-ascii?Q?GbgTgaylCJ+qSHMY0/Cb3/v+fC/DbxFZU6/GAL9cABhTgToGjaGWCFimPM9b?=
 =?us-ascii?Q?hJ6rxBY2dpZMb5QmFtaUMlpT2OfTYrVvmyOVIbR7tVo2RToq5Z4JoG9+8k8P?=
 =?us-ascii?Q?ebfMvhCiaoMQnrdICag0QELsSnqxeQVEb3Frrie3+Z3PAYqG5zHuLcgYOG81?=
 =?us-ascii?Q?cGurNF2mNc9Pg+lVKv+J0rEXBQgp8dBd+ada7y4W6U2KyxNGq6V4co0B3CM/?=
 =?us-ascii?Q?ptN+uqj5W6TaiP+6AsKh1QnYBEqcvCzb55Gx7wnB8+c1EMVsMk/LznOABR8b?=
 =?us-ascii?Q?8HQ2e6naSyGL4qIw0vCJXzEZ86nBKhXySjSKAwEJ5oAEM/sRURnqeFyArBCi?=
 =?us-ascii?Q?w7GY+UiY99j6JQbzHotlAE2xDrYCZMbUSv++qYo2SlOVR4t0jL/L+1mlKEOK?=
 =?us-ascii?Q?iuZ43gQgBcWkPP1XLm4LNo6wJK6oMk2kZbA2NISAm91JwZ0hiycHVfaKPWGk?=
 =?us-ascii?Q?mrkAYqyVKfjYHZm0Dh33xMcg0OmE3m7yg9/MST4I5V910HPUtIDW6dcrdkQK?=
 =?us-ascii?Q?3iSndBfr4cLkLEjPSNXm/wWOyKGXT+sWP0yxw1+P?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?watm6Pe5k7C+2fsJw7Ijr8jrNaRZh4k+yp4GG3TIipJieq6/SA9Ws8pNsC/m?=
 =?us-ascii?Q?5yZkMyJ+Uh4Xzdr2zcK2muDi0GGAI9ZcvTD8kTGt5U3pNOkHyoJ3M/rPol/6?=
 =?us-ascii?Q?UAmeI/1ZjuIwgyT+cJQT6wGTEdhbZQVajEYTa3518xROSJt8/psA+D8eiiKd?=
 =?us-ascii?Q?BwYn5JyaB5vKBCIPWDd7+fNtbAe2ZrCZqVBCBN4MWGgUKegJae42MDIu1nnq?=
 =?us-ascii?Q?o2wsTwJ5izs0px3zqQcrf8FTe/XYoUpkjWoAViU9G35uEl6tjIIBbTUhXELC?=
 =?us-ascii?Q?mPGWIrslb9fSSRRT/Gk8hyxePb1/ttkUwGZi8DwMV9BzxvCRkDzSsv+KxLyS?=
 =?us-ascii?Q?OwMzUeQQrZDMszAFyvyh3ximzgiTkmxPalnQBlwSQqdwHAdM8LHUpwRubseU?=
 =?us-ascii?Q?9m4as4UsFdTNBSENMj87LYnZyVRy5oeNKAba/VVc4+SCElDh7VILiTg8cGJW?=
 =?us-ascii?Q?uv8j9g585IU9b50FAMNFhHED+3EU0QJJ6DmZWphhu3cq8nkkEa9DWGc5rNZ8?=
 =?us-ascii?Q?N3PxiZSZuQ+sa2HgLuvrvQqNsWatHkxUW5eO6xBGlgVbT1aFL5MAhmMTIAOe?=
 =?us-ascii?Q?hb8joAtVwOQzfFtPOdpp9Is92S55chNM6zkPOb/zDzBJbPxqD31iv/eDppaM?=
 =?us-ascii?Q?QNFt2xSlaMPieS7XsUZxIGngiOm6mjXN4lSA+u62rkoyab//NBoRnONtj50y?=
 =?us-ascii?Q?fpwfOoqXwuylBQoezEGpfq3NuO+0mUDL5riA0g52lkgSAY1Sz3pUhhyCxwUL?=
 =?us-ascii?Q?ZcETcP4Hj9sDeoaD08yp2ZhS7PshOwA2j4xy3NpA8ck188CND40JixI2MJK1?=
 =?us-ascii?Q?yHAjfw7UrO1FfBWwAbQULvUWSeDDd7P7sEcL0qBQFb5cRXGAoj4DakBBtsF1?=
 =?us-ascii?Q?P6BMGZrA+SPUjzOmTfEm9V72XwwmnNJMCxQgc7IM1rSXyjLEgJ0iEoLTzapC?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08b5a4de-ca64-43df-0cf1-08db7d783d37
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 16:52:38.1699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WNDdBx4oeLaqXcNlwRmjbJ2j/mO5SxYxaW6bX23qD/b4stx8UCn/wleR26ENP1p5XAAANSDhs6snvdY5ORsLOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7047
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-05_08,2023-07-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=894
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307050153
X-Proofpoint-ORIG-GUID: 3wUiio_cAs2N2zW3-G3XEi3DJkFYvqJT
X-Proofpoint-GUID: 3wUiio_cAs2N2zW3-G3XEi3DJkFYvqJT
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/04/23 09:41, Yin, Fengwei wrote:
> On 7/4/2023 2:49 AM, Mike Kravetz wrote:
> > On 06/28/23 12:43, Yin Fengwei wrote:
> > 
> > Thank you for your detailed analysis!
> > 
> > When the regression was initially discovered, I sent a patch to revert
> > commit 9425c591e06a.  Andrew has picked up this change.  And, Andrew has
> > also picked up this patch.
> Oh. I didn't notice that you sent revert patch. My understanding is that
> commit 9425c591e06a is a good change.
> 
> > 
> > I have not verified yet, but I suspect that this patch is going to cause
> > a regression because it depends on the behavior of page_cache_next_miss
> > in 9425c591e06a which has been reverted.
> Yes. If the 9425c591e06a was reverted, this patch could introduce regression.
> Which fixing do you prefer? reverting 9425c591e06a or this patch? Then we
> can suggest to Andrew to take it.

For now, I suggest we go with the revert.  Why?
- The revert is already going into stable trees.
- I may not be remembering correctly, but I seem to recall Matthew
  mentioning plans to redo/redesign the page cache and possibly
  readahead code.  If this is the case, then better to keep the legacy
  behavior for now.  But, I am not sure if this is actually part of any
  plan or work in progress.

-- 
Mike Kravetz