Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565AbXJWKBt (ORCPT ); Tue, 23 Oct 2007 06:01:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752267AbXJWKB3 (ORCPT ); Tue, 23 Oct 2007 06:01:29 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:55479 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbXJWKB1 (ORCPT ); Tue, 23 Oct 2007 06:01:27 -0400 Message-ID: <471DC66D.6000909@garzik.org> Date: Tue, 23 Oct 2007 06:01:17 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: David Miller CC: barkalow@iabervon.org, linas@austin.ibm.com, chunhao.huang@hotmail.com, gregkh@suse.de, htejun@gmail.com, brice.goglin@gmail.com, david.gaarenstroom@gmail.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, shane.huang@amd.com, linux-ide@vger.kernel.org, brice@myri.com Subject: Re: [patch] PCI: disable MSI on more ATI NorthBridges References: <471D0ADC.7000005@garzik.org> <20071022.171318.104036671.davem@davemloft.net> In-Reply-To: <20071022.171318.104036671.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 29 David Miller wrote: > My suggestion is: > > 1) Leave the pci_intx() twiddling code in drivers/pci/msi.c > > 2) Add quirks for "INTX_DISABLE turns off MSI too", this sets > a flag in the pci_dev. > > 3) The pci_intx() calls in drivers/pci/msi.c are skipped if this > flag from #2 is set. > > 4) Add quirk entries for drivers/net/tg3.c chips and these SATA > devices we are learning about here, as well as any others we > are aware of right now. > > 5) Remove the pci_intx() workaround code from drivers/net/tg3.c > and elsewhere. Sounds good to me also. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/