Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202307041023.bcdbbfc0-oliver.sang@intel.com> <CAHk-=wi3Nb4t-JH6BGE5TOynik=-0kXyBGi3bLKTA85rvqHngQ@mail.gmail.com>
 <b57f35f9-53ae-5a99-d8b7-f1915c1cd1d0@nvidia.com> <CAHk-=wgi--892SZiqC8JWvF-vE7C+82X0VPHTCwbUpmbJWT0fw@mail.gmail.com>
In-Reply-To: <CAHk-=wgi--892SZiqC8JWvF-vE7C+82X0VPHTCwbUpmbJWT0fw@mail.gmail.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 5 Jul 2023 10:15:11 -0700
Message-ID: <CAHk-=wjieeCJd+XYWHs9bR_-Bcw_OJiHDtK8NKGDeA_C_SuBng@mail.gmail.com>
Subject: Re: [linus:master] [gup] a425ac5365: WARNING:at_mm/gup.c:#__get_user_pages
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     kernel test robot <oliver.sang@intel.com>, oe-lkp@lists.linux.dev,
        lkp@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 5 Jul 2023 at 08:54, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I'll tighten it up, and switch the WARN_ON_ONCE() to just do a
> "dump_stack()" so that it won't cause problems with the syzbot tests
> either.

I pushed it out. It's based on the thing that Oliver already tested,
but expanded a bit from that (and with a better calling convention, so
that when we're done we can just delete the whole helper function and
replace it with "find_vma()" like it is supposed to just be).

It's lightly tested, but I no longer have any trivial ways to trigger
the warning, so the testing was literally "now it doesn't say anything
at all".

It should still trigger the warning by literally doing some direct-IO
GUP below the stack - but at least the obvious cases of false
positives hopefully don't trigger.

At least until somebody comes up with another obvious case that I
didn't think of ;)

               Linus