Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 19:26:21 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Lee Jones <lee@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rk808: Make MFD_RK8XX tristate
Message-ID: <20230705172621.iyg5tis5sfxekbqi@mercury.elektranox.org>
References: <d132363fc9228473e9e652b70a3761b94de32d70.1688475844.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="p2zwyd53z6ewu4ln"
Content-Disposition: inline
In-Reply-To: <d132363fc9228473e9e652b70a3761b94de32d70.1688475844.git.geert+renesas@glider.be>
Precedence: bulk


--p2zwyd53z6ewu4ln
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jul 04, 2023 at 03:07:48PM +0200, Geert Uytterhoeven wrote:
> There is no reason for MFD_RK8XX to be bool, all drivers that depend on
> it, or that select it, are tristate.
>=20
> Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, LGTM.

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6f5b259a6d6a0b9d..f6b519eaaa710e71 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1197,7 +1197,7 @@ config MFD_RC5T583
>  	  different functionality of the device.
> =20
>  config MFD_RK8XX
> -	bool
> +	tristate
>  	select MFD_CORE
> =20
>  config MFD_RK8XX_I2C
> --=20
> 2.34.1
>=20

--p2zwyd53z6ewu4ln
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmSlp6wACgkQ2O7X88g7
+pr0PQ/+MQYjyvQhRDIMkDMDbjd0Fawh/wLBAzyqgYng0sJHxKXqwVt+FBssz1v3
uRuhhhd0MX5PbcvGwzteWYYpcquKKJChoXsQmq3gzrtFA1X6620sk1nl+f/Mg9SP
t79BI49pbaShD7sOlR8dEK6mkGjDMNTUYm4hjiF1v6IvQ1ViQtMJfCrnAQklsnh5
ex2gy/0birMKKJd59UhV5pwPNZEun1+6iJ9pNONqK9eD3iwYEj5jEV66TRtdgpiC
dCDH9paiW0DUcOpRQPxn2APpDoHz8RYtVzHwfVpwuGfq+4L9pBQNJqrPqr1EfhAg
b6mYc8PCLsoB7hsg0BLKnrQPemNQapcQwDl1xT3/GMGUBPyoi/zC+8VwdJKiNdJu
8e74LfG93GaLLtdMJ+1K4Ruo+Xpe/0C/Q6uU9b2SZsD8dBtXDEt9nLyqDSVkdCYM
mzVZnA/+mc7neGwsgajp+9UXZmUIEqcPq+HKMinSKK6OmFuMAjp39NmqhR1xMYCW
tS70Xf/+FFmGkltXufKZha88w3nKDT8LUxhMOqJc8cK5tzusJGVEfehlUYWJskuP
E0s+ubp5S0r8De586V+Dd62sX7pqJ6FQmeLAVmHp3bhtcHjrHBN8Alfj9Yx1uxbV
RMhNs/cXvcrHyZ3qy20Sj/vOV03nCRGHq/9l1R2GBmkN0XPl9Ew=
=2/JM
-----END PGP SIGNATURE-----

--p2zwyd53z6ewu4ln--