Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Jul 2023 18:48:36 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Boqun Feng <boqun.feng@gmail.com>
Cc:     Benno Lossin <benno.lossin@proton.me>,
        Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <aliceryhl@google.com>,
        Andreas Hindborg <nmi@metaspace.dk>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev, Asahi Lina <lina@asahilina.net>
Subject: Re: [PATCH 5/7] rust: init: add `..Zeroable::zeroed()` syntax for
 zeroing all missing fields
Message-ID: <20230705184836.363c8c8b.gary@garyguo.net>
In-Reply-To: <ZKMQW4UGPQZ8yF39@boqun-archlinux>
References: <20230624092330.157338-1-benno.lossin@proton.me>
        <20230624092330.157338-5-benno.lossin@proton.me>
        <ZKMQW4UGPQZ8yF39@boqun-archlinux>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hRh38Vc+EpDAMnx5cIuhYvvJLzxgUJNE1nsjWGPZWAvfuMjgcyEJTONr9h2X?=
 =?us-ascii?Q?KWMMn+d+pD4llNvVxuKd3gAJGiky8j8YVjuDTsPh63l+Ka9jNEevOQlf+Mom?=
 =?us-ascii?Q?dLMP35iHSv4zeafGq4gV+0gdIo8h74ZIZ73gOp3i4MK4IfgMoEvfAinsRk5L?=
 =?us-ascii?Q?TwapNrebnRJkGXD85FaEF48xvrqEJYd4XwESxGsJruviGdlYIm+0zGBdiVi3?=
 =?us-ascii?Q?eRitLuibI8ebGB7P/frRLn0DYhWaitnPYFO/k6rto6yhKDRTTiBZ1TKiKId8?=
 =?us-ascii?Q?pmu0YkE4NafgMzHvPIpbY8ajw1ClXLGtz7A+6azFBub3jf1kaWs5MF0QMmcB?=
 =?us-ascii?Q?DzrPMVyyJa2eOyK95zKejFrRT1pUWoC/y8+P3zYjBZSKou1Zb/1SkDo7tExX?=
 =?us-ascii?Q?Rzr3m8AVyuOiLRwqyQrqMW7ooJ9rTMSYqqdGirhnAxDliCytgYSA601vFkYN?=
 =?us-ascii?Q?UqfG3GTsAgMUAmTRCcs9BqkpaKSmEjp+jE6RdBBZ0uGg6eexUwjmNxcZ0JlD?=
 =?us-ascii?Q?QfEzkr0lqprsz/VC5WXntPfLRPNvyLpnqtHlt26Hh1Szlw7pIM74pYJGKbb9?=
 =?us-ascii?Q?kdvYQWTfC1fxPycStZ0m9Ie9aqwdBJFNlBNTXCjpJJKydGeM14OI3lFT3Kb3?=
 =?us-ascii?Q?QmpVM2Q7oPn4S2D5G7c467xtfAXXU9+o5W+UG81RccSLwHY9rbkp6GiOz5x2?=
 =?us-ascii?Q?LjyI2gD2NtA5wVkmaiARswuhHSjxhtylWErCojG8SovUjZHvzd7+0RgLxl9v?=
 =?us-ascii?Q?S0KLAZITXs8etSYWn3046fiVTeEi2lQhmbT7f0uykpOP0kQPcVa+krQDZjHC?=
 =?us-ascii?Q?Vf+UhpaGneU3P5iBUdGqfbxiX7kv/ZiYC9I9ci9tIALuns6NJOGQbG2pLEB7?=
 =?us-ascii?Q?MADf+oh7gRkm5V0nAohriL8UhtwBCDGYBFKVQyjdNnyZReciFJwiKeT5/nKU?=
 =?us-ascii?Q?I3FepOafPzt/d9F5XK6HCJNRCWErqRA/npRZsLIIrLZUe05gEcO5+qya8+kl?=
 =?us-ascii?Q?HGKQ1UTjAnAraXU+nSudHKRK8L2649x7zj2+HczlppUZWDceDzya6NF+fyxd?=
 =?us-ascii?Q?zrQu9SJUUKNactPCs/vjl3IhQBVjzJFG6mx0oK27D8RkC3tehiQ10u5wB3rn?=
 =?us-ascii?Q?XYDQIBfCi7XcuUmi+ulltWTVKdDcR64nX2Uw2oWd/9IszaBXEcq97XX2U6+A?=
 =?us-ascii?Q?kDq4osy8mXvSVC1AMq0NV1yzZk75BRfFjcjd0s0ijLNxxuxfMSzoqEe50aQ0?=
 =?us-ascii?Q?Bz4Rs3yA43rK4Q5d/Z3544wvtTsrWTh2jzVDi0XxmsXGOa5JDlNRE96vok6m?=
 =?us-ascii?Q?FNASyKlQ3zT+SeHhCtLYHQRwIFJHJ7YeN5HK/JOuomaZgf6906YQru6EhR2Q?=
 =?us-ascii?Q?NdsxdnHE1ueyWxJ1oMRqFh06Jf4VWjMTtbL042t36zQW8rKrzNhhHjPK9FVQ?=
 =?us-ascii?Q?vVcod8l66mkNxgSk3Ojif8nPiPbxPWo5f7JV65QEbqZXeufPTQ21/Tyt67Ic?=
 =?us-ascii?Q?lZROoJq6rmAr3pl1uNukeS+liOUJDVsHnV1IKf73dXMgZIAoXvjV89TdO3u0?=
 =?us-ascii?Q?hGNLnTwBRB2iUhFVxJhFRbP3DRQ61gWpNc/1n3Zr?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b1d0610-6c92-44a9-05cf-08db7d800fef
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 17:48:38.1570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2zq9sb/kvYmwoMb9VOFNooQL7G2HiDetdFijPpRD3HpRzjgTla0N0jFap16wXyhZnzUK4LYV+jzwRcY6GrqD+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB6333
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 3 Jul 2023 11:15:55 -0700
Boqun Feng <boqun.feng@gmail.com> wrote:

> On Sat, Jun 24, 2023 at 09:25:19AM +0000, Benno Lossin wrote:
> [...]
> (this is `init_slot`)
> > @@ -1064,7 +1152,7 @@ macro_rules! __init_internal {
> >          @data($data:ident),
> >          @slot($slot:ident),
> >          @guards($($guards:ident,)*),
> > -        @munch_fields($(,)?),
> > +        @munch_fields($(..Zeroable::zeroed())? $(,)?),  
> 
> since you append an unconditional comma ',' to init_slot and
> make_initializer when "calling" them in with_update_parsed, shouldn't
> this be:
> 
> +        @munch_fields($(..Zeroable::zeroed(),)? $(,)?),
> 
> , and..
> 
> >      ) => {
> >          // Endpoint of munching, no fields are left. If execution reaches this point, all fields
> >          // have been initialized. Therefore we can now dismiss the guards by forgetting them.
> > @@ -1157,6 +1245,30 @@ macro_rules! __init_internal {
> >              @munch_fields($($rest)*),
> >          );
> >      };
> > +    (make_initializer:
> > +        @slot($slot:ident),
> > +        @type_name($t:ident),
> > +        @munch_fields(..Zeroable::zeroed() $(,)?),  
> 
> this should be:
> 
> +        @munch_fields(..Zeroable::zeroed() , $(,)?),
> 
> Otherwise the example before `pin_init!()` wouldn't compile:
> 
> 	/// pin_init!(Buf {
> 	///     buf: [1; 64],
> 	///     ..Zeroable::zeroed(),
> 	/// });

Comma is not allowed after base struct.

> 
> Regards,
> Boqun
> 
> > +        @acc($($acc:tt)*),
> > +    ) => {
> > +        // Endpoint, nothing more to munch, create the initializer. Since the users specified
> > +        // `..Zeroable::zeroed()`, the slot will already have been zeroed and all field that have
> > +        // not been overwritten are thus zero and initialized. We still check that all fields are
> > +        // actually accessible by using the struct update syntax ourselves.
> > +        // Since we are in the `if false` branch, this will never get executed. We abuse `slot` to
> > +        // get the correct type inference here:
> > +        unsafe {
> > +            let mut zeroed = ::core::mem::zeroed();
> > +            // We have to use type inference her to make zeroed have the correct type. This does
> > +            // not get executed, so it has no effect.
> > +            ::core::ptr::write($slot, zeroed);
> > +            zeroed = ::core::mem::zeroed();
> > +            ::core::ptr::write($slot, $t {
> > +                $($acc)*
> > +                ..zeroed
> > +            });
> > +        }
> > +    };
> >      (make_initializer:
> >          @slot($slot:ident),
> >          @type_name($t:ident),
> > --
> > 2.41.0
> > 
> >