Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4ba1aeba-d744-4296-811f-71140e9c66d9@intel.com>
Date:   Wed, 5 Jul 2023 11:43:42 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.12.0
Subject: Re: [PATCH] ACPI: NFIT: add helper to_nfit_mem() to take device to
 nfit_mem
To:     Ben Dooks <ben.dooks@codethink.co.uk>, <nvdimm@lists.linux.dev>
CC:     <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lenb@kernel.org>
References: <20230703131729.1009861-1-ben.dooks@codethink.co.uk>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230703131729.1009861-1-ben.dooks@codethink.co.uk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmRodkEyV2dtblVaTDFlQkNhdUN6dkE5dFVkbUpQb2JoUStjYUZlUEtYRWI3?=
 =?utf-8?B?ZjhaOVJMY1RwVXIyaHV4b1JTdzk0SFZyWWxUTGpBMUhLRGJzMUlhWGcvZEZC?=
 =?utf-8?B?OHR4aitGQWRXemFFWloyMjZ3SGJSUEZDcnl6STgxU1NlbGZML3VwMjNsNDVv?=
 =?utf-8?B?TFlHKzlqODhQQi9ISFJPOGMyL2k3MTlpYkhsN1V0eW9VbEJydDJjcEpKMXJ2?=
 =?utf-8?B?ZjZWY0NCMlpWVXQvM09QekV5S1RVVFR6bk1za2xXaXhtQWJacy9xQ2c2eTBp?=
 =?utf-8?B?eUgzYWZuT242eStUWW5GWFFORUtpellvMmdpdHkycS9kaUNuem93SmpZc3lW?=
 =?utf-8?B?Mkc0OXgvaW9zQ0NCekVkRXpJZmlJQVp0ejgyWm5qYVltNkM5cmFuN3V5RFl0?=
 =?utf-8?B?UWYxNCt0T3hhb3FjTEFoNkdERHNpUGlJTzZjOFQ5ZVljRXl2dEhTdDFWVGxG?=
 =?utf-8?B?RlgrcTIzU0R2ei9kcjIyejZrM2VBMTV0VkYxNHc0L1RNYUY4RVgvTEhkdlVV?=
 =?utf-8?B?RWJsN1dYNUZNV2xaWXN5bVhjaGJTMnhLNzJqRitkR3RLSU81SXBPOW9RWjcz?=
 =?utf-8?B?WkFGaUVHVjFCMVRpT2Z5N1JXdE5xTjQ5OXUwN1pCa2w4Tlc1MDhYQmYrQlZl?=
 =?utf-8?B?ZjJ0Njk5RER0QW1zQitDQmNaTEYwaEdVOW16YkJPKzFoWWlrRGo1V2wvbkVT?=
 =?utf-8?B?eGdzcWVaTVI4dEtieG40bkdWeHVjOE5VRGk5K0s5R25wYVpVTDdlcStVOTRs?=
 =?utf-8?B?Y291VEdiYWF2RTdRN1l6VUlLSmd2amlVamNNSTN1V3ZJZlgwTEpwalQzMmVz?=
 =?utf-8?B?QjF3aFVVQmRlRERYNGZodU1ySDVmYUwwbE5VNVJ5MnpMek84dXZ3OHJhOTFC?=
 =?utf-8?B?MEUxWWlwb0tneFVBTXJQL0JGcVhiNGxFUTRyVXBrT04zVnNuZFRuZTcwTjhi?=
 =?utf-8?B?TVhidnVnMFF3cHIzSm1LdnorcFpzcnVpZlZRblBIQis4eGVRK2d1SmZwY1Zi?=
 =?utf-8?B?SFp0akg3eTFIbVdKN01UMHZ4dk5ad3psS2s4bkNlcVdGT1NOM3dGTWd1ZGlk?=
 =?utf-8?B?cWFmMUhzSUJ1NXBpRVp0eXBsOWdnWlFMV3ZFelRzSHZBSGhPeHlpR2JpdVZn?=
 =?utf-8?B?b1kvQUNDOE1sellaM214UDFvaXA4b0xBTmFsazA5QmVXRG8rRU9VTlp1YTg4?=
 =?utf-8?B?L2hhKzdDaUF5dE5PQUVwSE4yWVQ2aGlyVzRxVFlhckUxWjZKTmZrUE5YSHVW?=
 =?utf-8?B?YWRVNW1RaEZLTVl2QUNXTmtUWTNCSWlXWWkrbS9YdnBTS0xyTXZ3VG1HR2tr?=
 =?utf-8?B?dkVjcWhZb2w1Wm96N1hUWUFrMmR6STdkb2c3cmJBemtCaWxNcHozMGg4d2RV?=
 =?utf-8?B?ZlpDVDMzb2pHbVQ4cXhVZGhsYTg4NFFXdEtFV3lVZEhjQ3pOS3k3ZElkRXNo?=
 =?utf-8?B?b0RTZTNwL2NLNHVRMFZLbFdmWG5Fc3RUUzVWRkVwQ2VkaFduWURhWEVaQy9y?=
 =?utf-8?B?VlFvRGZDWVVhMjZVQTJyaXhzZVhIbmhndkw0Nk9vZGNlc1ZBQnZXNWxXYlJF?=
 =?utf-8?B?NThrSFB4RE5semQrNmNLT016c2wvZHY1dGJza0JaUHpyelFTK3gwUy9RdWZR?=
 =?utf-8?B?eTRJVmVPdkFlREJWSElWS1lVbUY1NjdpeHRUSHlZakZwQWtqSVhBOWNIR3BN?=
 =?utf-8?B?VlQvNm9IQnh3V0xQQjBLOW5zNVcwVi92cHRTaG5STk9jQWRLMTRuUzBzNllI?=
 =?utf-8?B?VU9vd3VDT3hYZVFodUllSEQ1QzdhbEdaVG0rN0xlUFhnSXhSZis5TXZRZUtW?=
 =?utf-8?B?TUNJZW5mcUUwTUtKVW15OG5EUVBldnNBQndWWTZPYUFZUzdMeU1QSVFYOUpS?=
 =?utf-8?B?UWJucDVqeURCVEpWMVpWbFd4YVpmVkw3RnVRcTZiQ2krellIVTJuTzlySmtz?=
 =?utf-8?B?NmtQdG5RRm5nMGUxeklqcklMOFZIaVJ3d3YwbjZhZk9WM1FzNUpKM2ZWYjdI?=
 =?utf-8?B?czJ0ZHFTQ3U3c3BEdlV0VnhON3N4WWZSTThrRiswZFVDQUNDVGQxY3NJc1Ar?=
 =?utf-8?B?ZktTVDVxRSt4NElTbTZrUUlsZ1VYdXZnMklVUituWlJMRFFLUFArQTNBaVAy?=
 =?utf-8?B?alNvMUZVOUUyNk8xK0lzbzBaS0g0cjhpU2xCejRmWHZkQ1dOVzlSTEJhTzRv?=
 =?utf-8?B?bkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6240286e-f585-4919-3fc4-08db7d87c339
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 18:43:45.3665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HaTsaTF21W9+83HkC47jGGxgla6h5VvPuMCuI/WbgZrr+3675LnbqsSQ4ZGLuolrIWUEoaeXbO0f/OCoENg+9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5502
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/3/23 06:17, Ben Dooks wrote:
> Add a quick helper to just do struct device to the struct nfit_mem
> field it should be referencing. This reduces the number of code
> lines in some of the followgn code as it removes the intermediate

s/followgn/following/

> struct nvdimm.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   drivers/acpi/nfit/core.c | 27 +++++++++++++--------------
>   1 file changed, 13 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 0fcc247fdfac..9213b426b125 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1361,18 +1361,22 @@ static const struct attribute_group *acpi_nfit_attribute_groups[] = {
>   	NULL,
>   };
>   
> -static struct acpi_nfit_memory_map *to_nfit_memdev(struct device *dev)
> +static struct nfit_mem *to_nfit_mem(struct device *dev)
>   {
>   	struct nvdimm *nvdimm = to_nvdimm(dev);
> -	struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> +	return  nvdimm_provider_data(nvdimm);
> +}
> +
> +static struct acpi_nfit_memory_map *to_nfit_memdev(struct device *dev)
> +{
> +	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
>   	return __to_nfit_memdev(nfit_mem);
>   }
>   
>   static struct acpi_nfit_control_region *to_nfit_dcr(struct device *dev)
>   {
> -	struct nvdimm *nvdimm = to_nvdimm(dev);
> -	struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> +	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
>   	return nfit_mem->dcr;
>   }
> @@ -1531,8 +1535,7 @@ static DEVICE_ATTR_RO(serial);
>   static ssize_t family_show(struct device *dev,
>   		struct device_attribute *attr, char *buf)
>   {
> -	struct nvdimm *nvdimm = to_nvdimm(dev);
> -	struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> +	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
>   	if (nfit_mem->family < 0)
>   		return -ENXIO;
> @@ -1543,8 +1546,7 @@ static DEVICE_ATTR_RO(family);
>   static ssize_t dsm_mask_show(struct device *dev,
>   		struct device_attribute *attr, char *buf)
>   {
> -	struct nvdimm *nvdimm = to_nvdimm(dev);
> -	struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> +	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
>   	if (nfit_mem->family < 0)
>   		return -ENXIO;
> @@ -1555,8 +1557,7 @@ static DEVICE_ATTR_RO(dsm_mask);
>   static ssize_t flags_show(struct device *dev,
>   		struct device_attribute *attr, char *buf)
>   {
> -	struct nvdimm *nvdimm = to_nvdimm(dev);
> -	struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> +	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   	u16 flags = __to_nfit_memdev(nfit_mem)->flags;
>   
>   	if (test_bit(NFIT_MEM_DIRTY, &nfit_mem->flags))
> @@ -1576,8 +1577,7 @@ static DEVICE_ATTR_RO(flags);
>   static ssize_t id_show(struct device *dev,
>   		struct device_attribute *attr, char *buf)
>   {
> -	struct nvdimm *nvdimm = to_nvdimm(dev);
> -	struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> +	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
>   	return sprintf(buf, "%s\n", nfit_mem->id);
>   }
> @@ -1586,8 +1586,7 @@ static DEVICE_ATTR_RO(id);
>   static ssize_t dirty_shutdown_show(struct device *dev,
>   		struct device_attribute *attr, char *buf)
>   {
> -	struct nvdimm *nvdimm = to_nvdimm(dev);
> -	struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> +	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
>   	return sprintf(buf, "%d\n", nfit_mem->dirty_shutdown);
>   }